Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Retry generated discount codes on unique conflicts and emit deleted webhooks.

Kiran K9588e86aae4f
diff --git a/apps/web/app/(ee)/api/cron/discount-codes/create/route.ts b/apps/web/app/(ee)/api/cron/discount-codes/create/route.ts
index 4888d4eafe..444e7e29b8 100644
--- a/apps/web/app/(ee)/api/cron/discount-codes/create/route.ts
+++ b/apps/web/app/(ee)/api/cron/discount-codes/create/route.ts
@@ -1,3 +1,4 @@
+import { DubApiError } from "@/lib/api/errors";
import { withCron } from "@/lib/cron/with-cron";
import { createDiscountCode } from "@/lib/discounts/create-discount-code";
import { isNonRecoverableDiscountError } from "@/lib/discounts/discount-error";
@@ -44,6 +45,7 @@ export const POST = withCron(async ({ rawBody }) => {
project: {
select: {
id: true,
+ webhookEnabled: true,
stripeConnectId: true,
shopifyStoreId: true,
},
@@ -94,6 +96,13 @@ export const POST = withCron(async ({ rawBody }) => {
return logAndRespond(error.message, { logLevel: "warn" });
}
+ if (
+ error instanceof DubApiError &&
+ (error.code === "conflict" || error.code === "bad_request")
+ ) {
+ return logAndRespond(error.message, { logLevel: "warn" });
+ }
+
throw error;
}
diff --git a/apps/web/app/(ee)/api/cron/groups/remap-discount-codes/route.ts b/apps/web/app/(ee)/api/cron/groups/remap-discount-codes/route.ts
index a49f8dd9f6..208b409767 100644
--- a/apps/web/app/(ee)/api/cron/groups/remap-discount-codes/route.ts
+++ b/apps/web/app/(ee)/api/cron/groups/remap-discount-codes/route.ts
@@ -149,6 +149,7 @@ export const POST = withCron(async ({ rawBody }) => {
},
select: {
id: true,
+ webhookEnabled: true,
stripeConnectId: true,
shopifyStoreId: true,
},
diff --git a/apps/web/lib/api/links/bulk-delete-links.ts b/apps/web/lib/api/links/bulk-delete-links.ts
index 1a16a84e5c..bec5e954d1 100644
--- a/apps/web/lib/api/links/bulk-delete-links.ts
+++ b/apps/web/lib/api/links/bulk-delete-links.ts
@@ -79,11 +79,7 @@ async function deleteLinksBatch(links: ExpandedLink[]): Promise<number> {
},
},
include: {
- discount: {
- select: {
- provider: true,
- },
- },
+ discount: true,
},
});
diff --git a/apps/web/lib/discounts/create-discount-code.ts b/apps/web/lib/discounts/create-discount-code.ts
index e30fda7a33..0c2801ffc0 100644
--- a/apps/web/lib/discounts/create-discount-code.ts
+++ b/apps/web/lib/discounts/create-discount-code.ts
@@ -1,12 +1,15 @@
import { createId } from "@/lib/api/create-id";
import { DubApiError } from "@/lib/api/errors";
import { prisma } from "@/lib/prisma";
+import { nanoid } from "@dub/utils";
import { Discount, Link, Partner, Prisma, Project } from "@prisma/client";
import { waitUntil } from "@vercel/functions";
import { constructDiscountCode } from "./construct-discount-code";
import { sendDiscountCodeWebhook } from "./discount-code-webhook";
import { getDiscountProvider } from "./discount-provider";
+const MAX_ATTEMPTS = 3;
+
interface CreateDiscountCodeArgs {
workspace: Pick<
Project,
@@ -53,23 +56,86 @@ export async function createDiscountCode({
}
const discountProvider = getDiscountProvider(discount.provider);
+ const shouldRetry = !code;
const externalDiscountCode = await discountProvider.createDiscountCode({
workspace,
discount,
code: finalCode,
- shouldRetry: code ? false : true,
+ shouldRetry,
});
- let discountCode: Prisma.DiscountCodeGetPayload<{
- include: { discount: true };
- }>;
+ let currentCode = externalDiscountCode.code;
+ let discountCode: DiscountCodeWithDiscount | undefined;
+ for (let attempt = 0; attempt < (shouldRetry ? MAX_ATTEMPTS : 1); attempt++) {
+ const result = await createDiscountCodeRecord({
+ workspace,
+ partner,
+ link,
+ discount,
+ code: currentCode,
+ canRetry: shouldRetry && attempt < MAX_ATTEMPTS - 1,
+ discountProvider,
+ });
+
+ if (result.discountCode) {
+ discountCode = result.discountCode;
+ break;
+ }
+
+ currentCode = result.nextCode;
+ }
+
+ if (!discountCode) {
+ throw new DubApiError({
+ code: "conflict",
+ message:
+ "This discount code is already in use, or this link already has a code. Please refresh and try again.",
+ });
+ }
+
+ waitUntil(
+ sendDiscountCodeWebhook({
+ trigger: "discount_code.created",
+ data: discountCode,
+ workspace,
+ }),
+ );
+
+ return discountCode;
+}
+
+type DiscountCodeWithDiscount = Prisma.DiscountCodeGetPayload<{
+ include: { discount: true };
+}>;
+
+type CreateDiscountCodeRecordResult =
+ | { discountCode: DiscountCodeWithDiscount; nextCode?: never }
+ | { nextCode: string; discountCode?: never };
+
+async function createDiscountCodeRecord({
+ workspace,
+ partner,
+ link,
+ discount,
+ code,
+ canRetry,
+ discountProvider,
+}: {
+ workspace: CreateDiscountCodeArgs["workspace"];
+ partner: CreateDiscountCodeArgs["partner"];
+ link: CreateDiscountCodeArgs["link"];
+ discount: Discount;
+ code: string;
+ canRetry: boolean;
+ discountProvider: ReturnType<typeof getDiscountProvider>;
+}): Promise<CreateDiscountCodeRecordResult> {
try {
- discountCode = await prisma.discountCode.create({
+ const discountCode = await prisma.discountCode.create({
data: {
id: createId({ prefix: "dcode_" }),
- code: externalDiscountCode.code,
+ code,
programId: discount.programId,
partnerId: partner.id,
linkId: link.id,
@@ -79,23 +145,62 @@ export async function createDiscountCode({
discount: true,
},
});
+
+ return {
+ discountCode,
+ };
} catch (error) {
- try {
- await discountProvider.disableDiscountCode({
+ const isUniqueConflict =
+ error instanceof Prisma.PrismaClientKnownRequestError &&
+ error.code === "P2002";
+
+ if (isUniqueConflict && canRetry) {
+ const existingForLink = await prisma.discountCode.findUnique({
+ where: {
+ linkId: link.id,
+ },
+ select: {
+ code: true,
+ },
+ });
+
+ if (existingForLink) {
+ throw new DubApiError({
+ code: "bad_request",
+ message: `This link already has a discount code (${existingForLink.code}) assigned.`,
+ });
+ }
+
+ await rollbackExternalDiscountCode({
+ discountProvider,
workspace,
- code: externalDiscountCode.code,
+ code,
});
- } catch (rollbackError) {
- console.error("Failed to rollback external discount code", {
- code: externalDiscountCode.code,
- rollbackError,
+
+ const nextCode = `${code}${nanoid(2)}`;
+ console.warn(
+ `Discount code "${code}" already exists. Retrying with "${nextCode}".`,
+ );
+
+ const retried = await discountProvider.createDiscountCode({
+ workspace,
+ discount,
+ code: nextCode,
+ shouldRetry: false,
});
+
+ return {
+ nextCode: retried.code,
+ };
}
- if (
- error instanceof Prisma.PrismaClientKnownRequestError &&
- error.code === "P2002"
- ) {
+ await rollbackExternalDiscountCode({
+ discountProvider,
+ workspace,
+ code,
+ });
+
+ if (isUniqueConflict) {
throw new DubApiError({
code: "conflict",
message:
@@ -105,14 +210,26 @@ export async function createDiscountCode({
throw error;
}
+}
- waitUntil(
- sendDiscountCodeWebhook({
- trigger: "discount_code.created",
- data: discountCode,
+async function rollbackExternalDiscountCode({
+ discountProvider,
+ workspace,
+ code,
+}: {
+ discountProvider: ReturnType<typeof getDiscountProvider>;
+ workspace: CreateDiscountCodeArgs["workspace"];
+ code: string;
+}) {
+ try {
+ await discountProvider.disableDiscountCode({
workspace,
- }),
- );
-
- return discountCode;
+ code,
+ });
+ } catch (rollbackError) {
+ console.error("Failed to rollback external discount code", {
+ code,
+ rollbackError,
+ });
+ }
}
diff --git a/apps/web/lib/discounts/delete-discount-code.ts b/apps/web/lib/discounts/delete-discount-code.ts
index 72d8c5d374..a300444c35 100644
--- a/apps/web/lib/discounts/delete-discount-code.ts
+++ b/apps/web/lib/discounts/delete-discount-code.ts
@@ -1,11 +1,14 @@
import { prisma } from "@/lib/prisma";
+import { DiscountCodeWebhookSchema } from "@/lib/zod/schemas/discount";
import { APP_DOMAIN_WITH_NGROK, chunk } from "@dub/utils";
import { Discount, DiscountCode } from "@prisma/client";
+import { waitUntil } from "@vercel/functions";
import { enqueueBatchJobs } from "../cron/enqueue-batch-jobs";
+import { sendDiscountCodeWebhook } from "./discount-code-webhook";
type DeleteDiscountCodesParams = Pick<
DiscountCode,
- "id" | "code" | "programId"
+ "id" | "code" | "programId" | "partnerId" | "linkId" | "disabledAt"
> & {
discount: Pick<Discount, "provider"> | null;
};
@@ -68,6 +71,10 @@ export async function deleteDiscountCodes(
);
}
+ if (!isSoftDelete) {
+ waitUntil(sendDiscountCodeDeletedWebhooks(discountCodes));
+ }
+
await enqueueDeleteDiscountCode(discountCodes);
}
@@ -105,4 +112,41 @@ export async function enqueueDeleteDiscountCode(
}
}
-// TODO: Send webhook when a discount code is deleted
+async function sendDiscountCodeDeletedWebhooks(
+ discountCodes: DeleteDiscountCodesParams[],
+) {
+ const programIds = [...new Set(discountCodes.map((dc) => dc.programId))];
+
+ const workspaces = await prisma.project.findMany({
+ where: {
+ defaultProgramId: {
+ in: programIds,
+ },
+ },
+ select: {
+ id: true,
+ webhookEnabled: true,
+ defaultProgramId: true,
+ },
+ });
+
+ const workspaceByProgramId = new Map(
+ workspaces.map((workspace) => [workspace.defaultProgramId, workspace]),
+ );
+
+ await Promise.all(
+ discountCodes.map((discountCode) => {
+ const workspace = workspaceByProgramId.get(discountCode.programId);
+
+ if (!workspace) {
+ return;
+ }
+
+ return sendDiscountCodeWebhook({
+ trigger: "discount_code.deleted",
+ workspace,
+ data: DiscountCodeWebhookSchema.parse(discountCode),
+ });
+ }),
+ );
+}