Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

invoice.paid webhook when discount has no promotion code (#3992)

Pedro Ladeira95d92455ceaf
diff --git a/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts b/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts
index 13e1aaf95d..fc240af326 100644
--- a/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts
+++ b/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts
@@ -455,9 +455,9 @@ async function resolvePromotionCodeIdFromInvoice({
{
stripeAccount: stripeAccountId,
},
- )) as Stripe.Invoice & {
+ )) as Omit<Stripe.Invoice, "discounts"> & {
discounts: {
- promotion_code: Stripe.PromotionCode;
+ promotion_code: Stripe.PromotionCode | null;
}[];
};
@@ -475,8 +475,19 @@ async function resolvePromotionCodeIdFromInvoice({
};
}
+ const discountWithPromotionCode = expandedInvoice.discounts.find((discount) =>
+ Boolean(discount?.promotion_code?.id),
+ );
+
+ if (!discountWithPromotionCode) {
+ return {
+ promotionCodeId: null,
+ resolvePromotionCodeError: "No promotion code found on invoice discounts",
+ };
+ }
+
return {
- promotionCodeId: expandedInvoice.discounts[0].promotion_code.id,
+ promotionCodeId: discountWithPromotionCode.promotion_code!.id,
resolvePromotionCodeError: null,
};
}