Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Only run detectAndRecordFraudEvent if commission created for track-lead (#3391)

Steven Tey9676a1dd4fd5
diff --git a/apps/web/lib/api/conversions/track-lead.ts b/apps/web/lib/api/conversions/track-lead.ts
index ddc78344ad..1e7369f053 100644
--- a/apps/web/lib/api/conversions/track-lead.ts
+++ b/apps/web/lib/api/conversions/track-lead.ts
@@ -319,7 +319,8 @@ export const trackLead = async ({
},
});
- const { webhookPartner, programEnrollment } = createdCommission;
+ const { commission, webhookPartner, programEnrollment } =
+ createdCommission;
await Promise.allSettled([
executeWorkflows({
@@ -339,7 +340,9 @@ export const trackLead = async ({
eventType: "lead",
}),
- webhookPartner &&
+ // only run fraud checks if the commission was created
+ commission &&
+ webhookPartner &&
detectAndRecordFraudEvent({
program: { id: link.programId },
partner: pick(webhookPartner, ["id", "email", "name"]),