Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Use IP-based restriction for Singular postback events (#3701)

Steven Tey98b44834773f
diff --git a/apps/web/app/(ee)/api/singular/webhook/route.ts b/apps/web/app/(ee)/api/singular/webhook/route.ts
index e5978c0e2f..5c8aecf8c7 100644
--- a/apps/web/app/(ee)/api/singular/webhook/route.ts
+++ b/apps/web/app/(ee)/api/singular/webhook/route.ts
@@ -1,8 +1,12 @@
+import { isLocalDev } from "@/lib/api/environment";
import { DubApiError, handleAndReturnErrorResponse } from "@/lib/api/errors";
+import { getIP } from "@/lib/api/utils/get-ip";
import { normalizeWorkspaceId } from "@/lib/api/workspaces/workspace-id";
import { withAxiom } from "@/lib/axiom/server";
+import { SINGULAR_IP_RANGES } from "@/lib/integrations/singular/singular-ip-ranges";
import { trackSingularLeadEvent } from "@/lib/integrations/singular/track-lead";
import { trackSingularSaleEvent } from "@/lib/integrations/singular/track-sale";
+import { isIpInRange } from "@/lib/middleware/utils/is-ip-in-range";
import { prisma } from "@dub/prisma";
import { getSearchParams } from "@dub/utils";
import { NextResponse } from "next/server";
@@ -20,11 +24,7 @@ const singularToDubEvent = {
const supportedEvents = Object.keys(singularToDubEvent);
-const authSchema = z.object({
- dub_token: z
- .string()
- .min(1, "dub_token is required")
- .describe("Global token to identify Singular events."),
+const querySchema = z.object({
dub_workspace_id: z
.string()
.min(1, "dub_workspace_id is required")
@@ -34,30 +34,26 @@ const authSchema = z.object({
.transform((v) => normalizeWorkspaceId(v)),
});
-const singularWebhookToken = process.env.SINGULAR_WEBHOOK_TOKEN;
-
// GET /api/singular/webhook – listen to Postback events from Singular
export const GET = withAxiom(async (req) => {
try {
- if (!singularWebhookToken) {
- throw new DubApiError({
- code: "bad_request",
- message:
- "SINGULAR_WEBHOOK_TOKEN is not set in the environment variables.",
- });
+ if (!isLocalDev) {
+ const ip = await getIP();
+ const isAllowed = SINGULAR_IP_RANGES.some((range) =>
+ isIpInRange(ip, range),
+ );
+
+ if (!isAllowed) {
+ throw new DubApiError({
+ code: "forbidden",
+ message: `IP address ${ip} is not allowed.`,
+ });
+ }
}
const queryParams = getSearchParams(req.url);
- const { dub_token: token, dub_workspace_id: workspaceId } =
- authSchema.parse(queryParams);
-
- if (token !== singularWebhookToken) {
- throw new DubApiError({
- code: "unauthorized",
- message: "Invalid Singular webhook token. Skipping event processing.",
- });
- }
+ const { dub_workspace_id: workspaceId } = querySchema.parse(queryParams);
const { event_name: eventName } = queryParams;
@@ -96,7 +92,6 @@ export const GET = withAxiom(async (req) => {
const dubEvent = singularToDubEvent[eventName];
- delete queryParams.dub_token;
delete queryParams.dub_workspace_id;
if (dubEvent === "lead") {
diff --git a/apps/web/lib/integrations/appsflyer/constants.ts b/apps/web/lib/integrations/appsflyer/constants.ts
index ee9193c1c0..496baab85a 100644
--- a/apps/web/lib/integrations/appsflyer/constants.ts
+++ b/apps/web/lib/integrations/appsflyer/constants.ts
@@ -39,6 +39,7 @@ export const APPSFLYER_REQUIRED_PARAMETERS = [
},
];
+// @see: https://support.appsflyer.com/hc/en-us/articles/207447093-AppsFlyer-server-IP-address-ranges-allowlisting
export const APPSFLYER_IP_RANGES = ["45.92.116.0/22", "194.28.46.0/23"];
export const APPSFLYER_MACROS = [
diff --git a/apps/web/lib/integrations/singular/singular-ip-ranges.ts b/apps/web/lib/integrations/singular/singular-ip-ranges.ts
new file mode 100644
index 0000000000..5aa3cadfe3
--- /dev/null
+++ b/apps/web/lib/integrations/singular/singular-ip-ranges.ts
@@ -0,0 +1,16 @@
+// @see: https://support.singular.net/hc/en-us/articles/360058106812-Postback-Server-IP-Addresses
+export const SINGULAR_IP_RANGES = [
+ "198.134.6.0/23",
+ "44.239.146.125/32",
+ "54.200.124.61/32",
+ "54.69.245.48/32",
+ "34.208.244.242/32",
+ "34.212.94.34/32",
+ "44.239.107.210/32",
+ "44.237.116.233/32",
+ "44.240.64.97/32",
+ "35.85.128.184/32",
+ "35.160.64.114/32",
+ "44.235.165.174/32",
+ "35.155.194.216/32",
+];