Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Harden sandbox payouts: block production Tremendous campaigns and mock completion.

Kiran K9a893de7c994
diff --git a/apps/web/app/(ee)/api/cron/payouts/charge-succeeded/route.ts b/apps/web/app/(ee)/api/cron/payouts/charge-succeeded/route.ts
index 1128c98e28..0fb0fd61e2 100644
--- a/apps/web/app/(ee)/api/cron/payouts/charge-succeeded/route.ts
+++ b/apps/web/app/(ee)/api/cron/payouts/charge-succeeded/route.ts
@@ -153,8 +153,8 @@ export async function POST(req: Request) {
...(!isProductionWorkspace
? [
mockPayoutCompletion({
- invoice,
workspace,
+ invoice,
}),
]
: []),
diff --git a/apps/web/app/(ee)/api/cron/payouts/process/process-payouts.ts b/apps/web/app/(ee)/api/cron/payouts/process/process-payouts.ts
index dccac1eb5a..1840c88c5f 100644
--- a/apps/web/app/(ee)/api/cron/payouts/process/process-payouts.ts
+++ b/apps/web/app/(ee)/api/cron/payouts/process/process-payouts.ts
@@ -304,13 +304,13 @@ export async function processPayouts({
}
// Non-production workspaces skip the Stripe payment intent above.
- // Simulate that flow here with a 30 second delay so
+ // Simulate that flow here with a 10 second delay so
// sandbox payouts behave like a settled ACH charge.
if (!isProductionWorkspace) {
await qstash.publishJSON({
url: `${APP_DOMAIN_WITH_NGROK}/api/cron/payouts/charge-succeeded`,
method: "POST",
- delay: "30s",
+ delay: "10s",
flowControl: {
key: invoice.id,
rate: 1,
diff --git a/apps/web/lib/actions/partners/confirm-payouts.ts b/apps/web/lib/actions/partners/confirm-payouts.ts
index 03b3d0b6bc..6cbdc3b892 100644
--- a/apps/web/lib/actions/partners/confirm-payouts.ts
+++ b/apps/web/lib/actions/partners/confirm-payouts.ts
@@ -231,7 +231,7 @@ export const confirmPayoutsAction = authActionClient
});
});
- if (!program.tremendousCampaignId) {
+ if (isProductionWorkspace && !program.tremendousCampaignId) {
waitUntil(
createTremendousCampaignJob.dispatch(
{
diff --git a/apps/web/lib/jobs/handlers/create-tremendous-campaign-job.ts b/apps/web/lib/jobs/handlers/create-tremendous-campaign-job.ts
index 77b25f349e..bb5b845d9a 100644
--- a/apps/web/lib/jobs/handlers/create-tremendous-campaign-job.ts
+++ b/apps/web/lib/jobs/handlers/create-tremendous-campaign-job.ts
@@ -1,4 +1,5 @@
import { prisma } from "@/lib/prisma";
+import { assertProductionWorkspace } from "@/lib/sandbox/workspace-guards";
import { createTremendousCampaign } from "@/lib/tremendous/create-tremendous-campaign";
import * as z from "zod/v4";
import { defineJob } from "../index";
@@ -25,6 +26,11 @@ export const createTremendousCampaignJob = defineJob({
name: true,
logo: true,
tremendousCampaignId: true,
+ workspace: {
+ select: {
+ environment: true,
+ },
+ },
},
});
@@ -35,6 +41,8 @@ export const createTremendousCampaignJob = defineJob({
return;
}
+ assertProductionWorkspace(program.workspace);
+
if (program.tremendousCampaignId) {
console.log(
`[createTremendousCampaignJob] Program ${programId} already has a Tremendous campaign. Skipping...`,
diff --git a/apps/web/lib/sandbox/mock-payout-completion.ts b/apps/web/lib/sandbox/mock-payout-completion.ts
index ac4a739a6c..f02294df99 100644
--- a/apps/web/lib/sandbox/mock-payout-completion.ts
+++ b/apps/web/lib/sandbox/mock-payout-completion.ts
@@ -10,7 +10,7 @@ import {
Project,
} from "@prisma/client";
import { trackCommissionStatusUpdate } from "../api/commissions/track-commission-update-activity-log";
-import { assertStagingWorkspace } from "./workspace-guards";
+import { assertNotProductionWorkspace } from "./workspace-guards";
interface MockPayoutCompletionParams {
invoice: Invoice;
@@ -22,7 +22,9 @@ export async function mockPayoutCompletion({
invoice,
workspace,
}: MockPayoutCompletionParams) {
- assertStagingWorkspace(workspace);
+ assertNotProductionWorkspace(workspace, {
+ message: "Mock payout completion is not available in production.",
+ });
const payouts = await prisma.payout.findMany({
where: {
@@ -110,13 +112,6 @@ export async function mockPayoutCompletion({
}),
]);
- await trackCommissionStatusUpdate({
- workspaceId: workspace.id,
- programId: payouts[0].programId,
- commissions,
- newStatus: CommissionStatus.paid,
- });
-
// Group partner -> payouts so we send only one email per partner when there are multiple payouts
const partnerPayouts = payouts.reduce(
(acc, payout) => {
@@ -126,23 +121,32 @@ export async function mockPayoutCompletion({
{} as Record<string, typeof payouts>,
);
- await sendBatchEmail(
- Object.values(partnerPayouts)
- .filter((partnerPayoutList) => partnerPayoutList[0].partner.email)
- .map((partnerPayoutList) => {
- const { partner, program, ...payout } = partnerPayoutList[0];
+ await Promise.allSettled([
+ trackCommissionStatusUpdate({
+ workspaceId: workspace.id,
+ programId: payouts[0].programId,
+ commissions,
+ newStatus: CommissionStatus.paid,
+ }),
- return {
- variant: "notifications",
- to: partner.email!,
- subject: `You've received a ${currencyFormatter(payout.amount)} payout from ${program.name}`,
- react: PartnerPayoutProcessed({
- email: partner.email!,
- workspace: program.workspace,
- program,
- payout,
- }),
- };
- }),
- );
+ sendBatchEmail(
+ Object.values(partnerPayouts)
+ .filter((partnerPayoutList) => partnerPayoutList[0].partner.email)
+ .map((partnerPayoutList) => {
+ const { partner, program, ...payout } = partnerPayoutList[0];
+
+ return {
+ variant: "notifications",
+ to: partner.email!,
+ subject: `You've received a ${currencyFormatter(payout.amount)} payout from ${program.name}`,
+ react: PartnerPayoutProcessed({
+ email: partner.email!,
+ workspace: program.workspace,
+ program,
+ payout,
+ }),
+ };
+ }),
+ ),
+ ]);
}
diff --git a/apps/web/lib/sandbox/workspace-guards.ts b/apps/web/lib/sandbox/workspace-guards.ts
index 7ded67b6c0..7970f852ff 100644
--- a/apps/web/lib/sandbox/workspace-guards.ts
+++ b/apps/web/lib/sandbox/workspace-guards.ts
@@ -61,3 +61,22 @@ export function assertProductionWorkspace(
});
}
}
+
+export function assertNotProductionWorkspace(
+ workspace: Pick<Project, "environment">,
+ options?: {
+ when?: boolean;
+ message?: string;
+ },
+) {
+ const shouldCheck = options?.when ?? true;
+
+ if (shouldCheck && isProductionEnvironment(workspace.environment)) {
+ throw new DubApiError({
+ code: "bad_request",
+ message:
+ options?.message ??
+ "This action is not available in production workspaces.",
+ });
+ }
+}