Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

set appName to fallback to destination link domain

Steven Tey9c04b8be5b8b
diff --git a/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/brand-logo-badge.tsx b/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/brand-logo-badge.tsx
index 1e550a0a82..c41e848782 100644
--- a/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/brand-logo-badge.tsx
+++ b/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/brand-logo-badge.tsx
@@ -8,18 +8,19 @@ export function BrandLogoBadge({
appName,
}: {
link: Pick<Link, "shortLink" | "url">;
- appName?: string;
+ appName: string;
}) {
return (
<div className="flex flex-col items-center justify-center gap-4">
<div className="rounded-2xl border border-neutral-100 bg-white p-6 shadow-lg">
<img
src={`${GOOGLE_FAVICON_URL}${getApexDomain(link.url)}`}
+ alt={`${appName} logo`}
className="size-8 shrink-0 overflow-visible rounded-full p-px"
/>
</div>
<div className="pr-1.5 text-lg font-semibold text-neutral-900">
- {appName ?? getApexDomain(link.url)}
+ {appName}
</div>
</div>
);
diff --git a/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/page.tsx b/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/page.tsx
index e8e6c77696..ec0fd72044 100644
--- a/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/page.tsx
+++ b/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/page.tsx
@@ -12,7 +12,7 @@ import {
IOSAppStore,
MobilePhone,
} from "@dub/ui/icons";
-import { cn } from "@dub/utils";
+import { cn, getApexDomain } from "@dub/utils";
import { headers } from "next/headers";
import Link from "next/link";
import { redirect } from "next/navigation";
@@ -97,15 +97,12 @@ export default async function DeepLinkPreviewPage(props: {
const {
hidePoweredByBadge = false,
- appName,
- variant = "default",
+ appName = getApexDomain(link.url),
+ variant,
buttonClassnames,
} = deepViewData ?? {};
- const description = t.description.replace(
- "{appName}",
- appName ?? t.appNameFallback,
- );
+ const description = t.description.replace("{appName}", appName);
return (
<>
diff --git a/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/translations.ts b/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/translations.ts
index c706548090..ae0d23e1b7 100644
--- a/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/translations.ts
+++ b/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/translations.ts
@@ -2,50 +2,42 @@ export const translations = {
en: {
poweredBy: "Powered by",
description: "Click below to open the page in {appName}.",
- appNameFallback: "the application",
openInApp: "Open in the app",
},
zh: {
poweredBy: "由",
description: "点击下方在 {appName} 中打开页面。",
- appNameFallback: "应用",
openInApp: "在应用中打开",
},
es: {
poweredBy: "Desarrollado por",
description: "Haz clic abajo para abrir la página en {appName}.",
- appNameFallback: "la aplicación",
openInApp: "Abrir en la aplicación",
},
fr: {
poweredBy: "Propulsé par",
description: "Cliquez ci-dessous pour ouvrir la page dans {appName}.",
- appNameFallback: "l'application",
openInApp: "Ouvrir dans l'application",
},
it: {
poweredBy: "Offerto da",
description: "Clicca qui sotto per aprire la pagina in {appName}.",
- appNameFallback: "l'applicazione",
openInApp: "Apri nell'app",
},
pt: {
poweredBy: "Desenvolvido por",
description: "Clique abaixo para abrir a página no {appName}.",
- appNameFallback: "o aplicativo",
openInApp: "Abrir no aplicativo",
},
de: {
poweredBy: "Bereitgestellt von",
description: "Klicke unten, um die Seite in {appName} zu öffnen.",
- appNameFallback: "der App",
openInApp: "In der App öffnen",
},
tr: {
poweredBy: "tarafından desteklenmektedir",
poweredByOrder: "inverted",
description: "Sayfayı {appName} içinde açmak için aşağıya tıklayın.",
- appNameFallback: "uygulama",
openInApp: "Uygulamada aç",
},
} as const;