Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Reject applications for removed partners without changing their enrollment.

Kiran Ka6fd72f13ebc
diff --git a/apps/web/lib/jobs/handlers/auto-reject-program-application-job.ts b/apps/web/lib/jobs/handlers/auto-reject-program-application-job.ts
index 390f5d1b09..4226cbb33a 100644
--- a/apps/web/lib/jobs/handlers/auto-reject-program-application-job.ts
+++ b/apps/web/lib/jobs/handlers/auto-reject-program-application-job.ts
@@ -5,7 +5,6 @@ import { rejectProgramApplication } from "@/lib/program-applications/reject-prog
import {
ProgramApplicationRejectionReason,
ProgramApplicationStatus,
- ProgramEnrollmentStatus,
} from "@prisma/client";
import * as z from "zod/v4";
import { defineJob } from "../index";
@@ -14,11 +13,6 @@ const inputSchema = z.object({
applicationId: z.string(),
});
-const AUTO_REJECTABLE_ENROLLMENT_STATUSES: ProgramEnrollmentStatus[] = [
- ProgramEnrollmentStatus.pending,
- ProgramEnrollmentStatus.approved,
-];
-
// This job is used to auto-reject a program application (e.g. when eligibility requirements are not met)
export const autoRejectProgramApplicationJob = defineJob({
name: "auto-reject-program-application-job",
@@ -86,15 +80,6 @@ export const autoRejectProgramApplicationJob = defineJob({
return;
}
- if (
- !AUTO_REJECTABLE_ENROLLMENT_STATUSES.includes(programEnrollment.status)
- ) {
- console.warn(
- `Application ${applicationId} was not auto-rejected because partner ${partnerId} is in ${programEnrollment.status} status.`,
- );
- return;
- }
-
const result = evaluateApplicationRequirements({
applicationRequirements: program.applicationRequirements,
context: {
diff --git a/apps/web/lib/program-applications/approve-program-application.ts b/apps/web/lib/program-applications/approve-program-application.ts
index 149f3881ef..4a6e66d727 100644
--- a/apps/web/lib/program-applications/approve-program-application.ts
+++ b/apps/web/lib/program-applications/approve-program-application.ts
@@ -178,9 +178,12 @@ export async function approveProgramApplication({
},
});
- await tx.programApplication.update({
+ const { count } = await tx.programApplication.updateMany({
where: {
id: programApplication.id,
+ status: {
+ in: APPROVABLE_APPLICATION_STATUSES,
+ },
},
data: {
status: ProgramApplicationStatus.approved,
@@ -191,6 +194,14 @@ export async function approveProgramApplication({
},
});
+ if (count === 0) {
+ throw new DubApiError({
+ code: "conflict",
+ message:
+ "This application was already reviewed. Refresh and try again.",
+ });
+ }
+
if (isNewEnrollment) {
await tx.project.update({
where: {
diff --git a/apps/web/lib/program-applications/reject-program-application.ts b/apps/web/lib/program-applications/reject-program-application.ts
index 80e1b09e46..9d3c3d0d20 100644
--- a/apps/web/lib/program-applications/reject-program-application.ts
+++ b/apps/web/lib/program-applications/reject-program-application.ts
@@ -114,27 +114,15 @@ export async function rejectProgramApplication({
const isApplyingToAdditionalGroup =
existingEnrollment?.status === ProgramEnrollmentStatus.approved;
- const enrollmentToReject = isApplyingToAdditionalGroup
- ? null
- : existingEnrollment;
+ // Banned, deactivated, and archived partners were already removed, so only
+ // the application is rejected and their enrollment is left untouched
+ const enrollmentToReject =
+ existingEnrollment &&
+ REJECTABLE_ENROLLMENT_STATUSES.includes(existingEnrollment.status)
+ ? existingEnrollment
+ : null;
- if (
- enrollmentToReject &&
- !REJECTABLE_ENROLLMENT_STATUSES.includes(enrollmentToReject.status)
- ) {
- throw new DubApiError({
- code: "bad_request",
- message: `This application cannot be rejected because the partner is ${enrollmentToReject.status}.`,
- });
- }
-
- if (isApplyingToAdditionalGroup && flagForFraud) {
- throw new DubApiError({
- code: "bad_request",
- message:
- "Cannot flag for fraud when rejecting an application to join another group.",
- });
- }
+ const isNewApplication = !existingEnrollment || !!enrollmentToReject;
await prisma.$transaction(async (tx) => {
await tx.programApplication.update({
@@ -150,7 +138,7 @@ export async function rejectProgramApplication({
},
});
- if (isApplyingToAdditionalGroup) {
+ if (!isNewApplication) {
return;
}
@@ -233,14 +221,14 @@ export async function rejectProgramApplication({
},
}),
- !isApplyingToAdditionalGroup &&
+ isNewApplication &&
trackApplicationEvents({
event: "rejected",
programId,
partnerIds: [partnerId],
}),
- !isApplyingToAdditionalGroup &&
+ isNewApplication &&
resolveFraudGroups({
where: {
programId,
@@ -251,7 +239,12 @@ export async function rejectProgramApplication({
"Resolved automatically because the partner application was rejected.",
}),
+ // Email when there is no enrollment or it is pending/rejected (program
+ // application), or when the partner is approved and applying to another
+ // group. Banned, deactivated, archived, invited, and declined enrollments
+ // are left unchanged, so those partners are not emailed.
partner?.email &&
+ (isNewApplication || isApplyingToAdditionalGroup) &&
sendEmail({
to: partner.email,
subject: isApplyingToAdditionalGroup