Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Hide events metadata from partner (#3653)

Kiran Ka74770224ffc
diff --git a/apps/web/app/(ee)/api/cron/export/events/partner/route.ts b/apps/web/app/(ee)/api/cron/export/events/partner/route.ts
index 6f38dcdbb4..c59cfd9372 100644
--- a/apps/web/app/(ee)/api/cron/export/events/partner/route.ts
+++ b/apps/web/app/(ee)/api/cron/export/events/partner/route.ts
@@ -113,6 +113,7 @@ export async function POST(req: Request) {
const eventsFilters = {
...parsedParams,
workspaceId: program.workspaceId,
+ includeMetadata: false,
...(parsedParams.linkId
? { linkId: parsedParams.linkId }
: links.length > MAX_PARTNER_LINKS_FOR_LOCAL_FILTERING
diff --git a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/customers/[customerId]/route.ts b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/customers/[customerId]/route.ts
index b6500d652c..fa95f850c0 100644
--- a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/customers/[customerId]/route.ts
+++ b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/customers/[customerId]/route.ts
@@ -69,6 +69,7 @@ export const GET = withPartnerProfile(async ({ partner, params }) => {
const events = await getCustomerEvents({
customerId: customer.id,
linkIds: links.map((link) => link.id),
+ includeMetadata: false,
});
if (events.length === 0) {
diff --git a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/events/export/route.ts b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/events/export/route.ts
index 0442e7fa82..c004073f05 100644
--- a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/events/export/route.ts
+++ b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/events/export/route.ts
@@ -192,6 +192,7 @@ export const GET = withPartnerProfile(
const events = await getEvents({
...parsedParams,
workspaceId: program.workspaceId,
+ includeMetadata: false,
...(parsedParams.linkId
? { linkId: parsedParams.linkId }
: links.length > MAX_PARTNER_LINKS_FOR_LOCAL_FILTERING
diff --git a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/events/route.ts b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/events/route.ts
index dc4a42c8b7..af6281286f 100644
--- a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/events/route.ts
+++ b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/events/route.ts
@@ -100,6 +100,7 @@ export const GET = withPartnerProfile(
const events = await getEvents({
...parsedParams,
workspaceId: program.workspaceId,
+ includeMetadata: false,
...(parsedParams.linkId
? { linkId: parsedParams.linkId }
: links.length > MAX_PARTNER_LINKS_FOR_LOCAL_FILTERING
diff --git a/apps/web/lib/analytics/get-customer-events.ts b/apps/web/lib/analytics/get-customer-events.ts
index 2367d543b6..fb62e4e4cf 100644
--- a/apps/web/lib/analytics/get-customer-events.ts
+++ b/apps/web/lib/analytics/get-customer-events.ts
@@ -13,9 +13,11 @@ import { saleEventResponseSchema } from "../zod/schemas/sales";
export const getCustomerEvents = async ({
customerId,
linkIds,
+ includeMetadata = true,
}: {
customerId: string;
linkIds?: string[];
+ includeMetadata?: boolean;
}) => {
const response = await getCustomerEventsTB({
customerId,
@@ -53,7 +55,10 @@ export const getCustomerEvents = async ({
? {
eventId: evt.event_id,
eventName: evt.event_name,
- metadata: evt.metadata ? JSON.parse(evt.metadata) : undefined,
+ metadata:
+ !includeMetadata || !evt.metadata
+ ? undefined
+ : JSON.parse(evt.metadata),
...(evt.event === "sale"
? {
sale: {
diff --git a/apps/web/lib/analytics/get-events.ts b/apps/web/lib/analytics/get-events.ts
index ac169f748e..d58669cf00 100644
--- a/apps/web/lib/analytics/get-events.ts
+++ b/apps/web/lib/analytics/get-events.ts
@@ -48,6 +48,7 @@ export const getEvents = async (params: EventsFilters) => {
sortOrder,
dataAvailableFrom,
query,
+ includeMetadata = true,
} = params;
const { startDate, endDate } = getStartEndDates({
@@ -209,7 +210,10 @@ export const getEvents = async (params: EventsFilters) => {
? {
eventId: evt.event_id,
eventName: evt.event_name,
- metadata: evt.metadata ? JSON.parse(evt.metadata) : undefined,
+ metadata:
+ !includeMetadata || !evt.metadata
+ ? undefined
+ : JSON.parse(evt.metadata),
customer: customersMap[evt.customer_id] ?? {
id: evt.customer_id,
name: "Deleted Customer",
diff --git a/apps/web/lib/analytics/types.ts b/apps/web/lib/analytics/types.ts
index e6bedd41ef..04e304b2ce 100644
--- a/apps/web/lib/analytics/types.ts
+++ b/apps/web/lib/analytics/types.ts
@@ -75,6 +75,7 @@ export type EventsFilters = Partial<
// Accept plain string (from partner-profile/cron routes) or ParsedFilter (from API schema)
partnerId?: string | ParsedFilter;
linkId?: string | ParsedFilter;
+ includeMetadata?: boolean;
};
const partnerAnalyticsSchema = analyticsQuerySchema