The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Improve transient error message
Rafia83c368d2244
diff --git a/apps/web/lib/api/partners/search/providers/resilience.ts b/apps/web/lib/api/partners/search/providers/resilience.tsindex 28f65e0a33..047f90d4a4 100644--- a/apps/web/lib/api/partners/search/providers/resilience.ts+++ b/apps/web/lib/api/partners/search/providers/resilience.ts@@ -1,11 +1,19 @@const TRANSIENT_RETRY_ATTEMPTS = 2;function isTransientError(error: unknown): boolean {+ const message = error instanceof Error ? error.message : String(error);++ // fetch network failures surface as TypeError ("fetch failed"), but so do+ // ordinary programming errors — only the network ones deserve a retry.if (error instanceof TypeError) {- return true;+ const normalized = message.toLowerCase();+ return (+ normalized.includes("fetch failed") ||+ normalized.includes("network") ||+ normalized.includes("load failed")+ );}- const message = error instanceof Error ? error.message : String(error);return /\b(429|500|502|503|504)\b|rate.?limit|timeout|timed out|fetch failed|network|ECONNRESET|ETIMEDOUT/i.test(message,);diff --git a/apps/web/tests/partners/turbopuffer-partner-search-provider.test.ts b/apps/web/tests/partners/turbopuffer-partner-search-provider.test.tsindex 312a550d6b..2f7e13cafd 100644--- a/apps/web/tests/partners/turbopuffer-partner-search-provider.test.ts+++ b/apps/web/tests/partners/turbopuffer-partner-search-provider.test.ts@@ -7,7 +7,7 @@ import {deleteTurbopufferPartnerSearchNamespace,type TurbopufferNamespace,} from "@/lib/api/partners/search/providers/turbopuffer";-import { beforeEach, describe, expect, it, vi } from "vitest";+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";const document: PartnerSearchDocument = {id: "pge_test",@@ -55,6 +55,12 @@ describe("Turbopuffer partner search provider", () => {mocks.multiQuery.mockResolvedValue({ results: [] });});+ // In afterEach rather than the test body, so a failed assertion cannot leak+ // a stubbed env var into later tests.+ afterEach(() => {+ vi.unstubAllEnvs();+ });+it("flattens every searchable field into one BM25 attribute", async () => {await createProvider().upsert([document]);@@ -243,6 +249,5 @@ describe("Turbopuffer partner search provider", () => {});expect(namespaceName).toBe("partner-search-v1");- vi.unstubAllEnvs();});});diff --git a/apps/web/tests/partners/upstash-redis-partner-search-provider.test.ts b/apps/web/tests/partners/upstash-redis-partner-search-provider.test.tsindex 14ca8cbaf5..5ba751c7e1 100644--- a/apps/web/tests/partners/upstash-redis-partner-search-provider.test.ts+++ b/apps/web/tests/partners/upstash-redis-partner-search-provider.test.ts@@ -8,7 +8,7 @@ import {upstashPartnerSearchSchema,} from "@/lib/api/partners/search/providers/upstash-redis";import type { Redis } from "@upstash/redis";-import { beforeEach, describe, expect, it, vi } from "vitest";+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";const document: PartnerSearchDocument = {id: "pge_test",@@ -75,6 +75,12 @@ describe("Upstash Redis partner search provider", () => {mocks.waitIndexing.mockResolvedValue(1);});+ // In afterEach rather than the test body, so a failed assertion cannot leak+ // a stubbed env var into later tests.+ afterEach(() => {+ vi.unstubAllEnvs();+ });+it("retrieves bounded relevance candidates without business filters", async () => {mocks.query.mockResolvedValue([{@@ -173,6 +179,45 @@ describe("Upstash Redis partner search provider", () => {expect(mocks.query).toHaveBeenCalledTimes(1);});+ it("retries a network TypeError", async () => {+ // undici surfaces network failures as `TypeError: fetch failed`.+ mocks.query+ .mockRejectedValueOnce(new TypeError("fetch failed"))+ .mockResolvedValueOnce([]);+ const provider = createUpstashRedisPartnerSearchProvider({+ redisClient: createRedisMock(),+ indexName: "test-index",+ });++ await expect(+ provider.searchCandidates({+ programId: document.programId,+ query: "rafi",+ limit: 10,+ }),+ ).resolves.toEqual({ hits: [] });+ expect(mocks.query).toHaveBeenCalledTimes(2);+ });++ it("does not retry a programming TypeError", async () => {+ mocks.query.mockRejectedValue(+ new TypeError("Cannot read properties of undefined (reading 'query')"),+ );+ const provider = createUpstashRedisPartnerSearchProvider({+ redisClient: createRedisMock(),+ indexName: "test-index",+ });++ await expect(+ provider.searchCandidates({+ programId: document.programId,+ query: "rafi",+ limit: 10,+ }),+ ).rejects.toThrow("Cannot read properties of undefined");+ expect(mocks.query).toHaveBeenCalledTimes(1);+ });+it("does not retry a request timeout after it consumes the query budget", async () => {mocks.query.mockRejectedValue(new DOMException(@@ -376,7 +421,6 @@ describe("Upstash Redis partner search provider", () => {expect(mocks.jsonMset).toHaveBeenCalledWith(expect.objectContaining({ key: "partner-search-v1:partner:pge_test" }),);- vi.unstubAllEnvs();},);});