Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Fix missing activity logs when due commissions are processed.

Kiran Ka898fd078dc6
diff --git a/apps/web/app/(ee)/api/cron/payouts/aggregate-due-commissions/process/route.ts b/apps/web/app/(ee)/api/cron/payouts/aggregate-due-commissions/process/route.ts
index ab68bf6b07..5bc20bbc10 100644
--- a/apps/web/app/(ee)/api/cron/payouts/aggregate-due-commissions/process/route.ts
+++ b/apps/web/app/(ee)/api/cron/payouts/aggregate-due-commissions/process/route.ts
@@ -329,13 +329,13 @@ async function aggregateDueCommissionsForPartner({
if (updatedPayout === 0) {
console.warn(
- `Payout ${payoutToUse.id} is no longer mutable after claim for partner ${partnerId}. Skipping...`,
+ `Payout ${payoutToUse.id} is no longer mutable after claim for partner ${partnerId}. Skipping payout amount update...`,
);
- return false;
}
// Only activity-log commissions we actually claimed (handles partial races).
- const claimedCommissions = await prisma.commission.findMany({
+ // Pass the pre-update rows so the status diff is pending → processed.
+ const claimedCommissionIds = await prisma.commission.findMany({
where: {
id: {
in: commissionIds,
@@ -345,12 +345,14 @@ async function aggregateDueCommissionsForPartner({
},
select: {
id: true,
- amount: true,
- earnings: true,
- status: true,
},
});
+ const claimedIds = new Set(claimedCommissionIds.map(({ id }) => id));
+ const claimedCommissions = sortedCommissions.filter((commission) =>
+ claimedIds.has(commission.id),
+ );
+
await trackCommissionStatusUpdate({
workspaceId: program.workspaceId,
programId: program.id,
@@ -358,5 +360,5 @@ async function aggregateDueCommissionsForPartner({
newStatus: CommissionStatus.processed,
});
- return true;
+ return updatedPayout !== 0;
}