Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Null sale amounts in referrals embed when revenue sharing is disabled.

Kiran Ka968c5a86591
diff --git a/apps/web/app/(ee)/api/embed/referrals/analytics/route.ts b/apps/web/app/(ee)/api/embed/referrals/analytics/route.ts
index 84d1869eef..cc37386511 100644
--- a/apps/web/app/(ee)/api/embed/referrals/analytics/route.ts
+++ b/apps/web/app/(ee)/api/embed/referrals/analytics/route.ts
@@ -1,6 +1,6 @@
import { getAnalytics } from "@/lib/analytics/get-analytics";
import { withReferralsEmbedToken } from "@/lib/embed/referrals/auth";
-import { omitSaleAmount } from "@/lib/partners/hide-partner-revenue";
+import { nullAnalyticsSaleAmounts } from "@/lib/partners/hide-partner-revenue";
import { isPartnerRevenueHidden } from "@/lib/partners/is-partner-revenue-hidden";
import { partnerProfileAnalyticsQuerySchema } from "@/lib/zod/schemas/partner-profile";
import { parseFilterValue } from "@dub/utils";
@@ -31,28 +31,10 @@ export const GET = withReferralsEmbedToken(
dataAvailableFrom: program.startedAt ?? program.createdAt,
});
- if (!isPartnerRevenueHidden(group)) {
- return NextResponse.json(analytics);
- }
-
- if (Array.isArray(analytics)) {
- return NextResponse.json(
- analytics.map((row) =>
- row && typeof row === "object" && "saleAmount" in row
- ? omitSaleAmount(row)
- : row,
- ),
- );
- }
-
- if (
- analytics &&
- typeof analytics === "object" &&
- "saleAmount" in analytics
- ) {
- return NextResponse.json(omitSaleAmount(analytics));
- }
-
- return NextResponse.json(analytics);
+ return NextResponse.json(
+ isPartnerRevenueHidden(group)
+ ? nullAnalyticsSaleAmounts(analytics)
+ : analytics,
+ );
},
);
diff --git a/apps/web/app/(ee)/api/embed/referrals/events/route.ts b/apps/web/app/(ee)/api/embed/referrals/events/route.ts
index 85b601018d..66609a3485 100644
--- a/apps/web/app/(ee)/api/embed/referrals/events/route.ts
+++ b/apps/web/app/(ee)/api/embed/referrals/events/route.ts
@@ -2,6 +2,8 @@ import { getEvents } from "@/lib/analytics/get-events";
import { obfuscateCustomerEmail } from "@/lib/api/partner-profile/obfuscate-customer-email";
import { withReferralsEmbedToken } from "@/lib/embed/referrals/auth";
import { generateRandomName } from "@/lib/names";
+import { nullPartnerEventRevenue } from "@/lib/partners/hide-partner-revenue";
+import { isPartnerRevenueHidden } from "@/lib/partners/is-partner-revenue-hidden";
import {
partnerProfileEventsQuerySchema,
PartnerProfileLinkSchema,
@@ -22,7 +24,7 @@ const querySchema = partnerProfileEventsQuerySchema.pick({
// GET /api/embed/referrals/events – get paginated events for a partner
export const GET = withReferralsEmbedToken(
- async ({ links, program, programEnrollment, searchParams }) => {
+ async ({ links, program, programEnrollment, group, searchParams }) => {
if (links.length === 0) {
return NextResponse.json([]);
}
@@ -37,6 +39,7 @@ export const GET = withReferralsEmbedToken(
});
const { customerDataSharingEnabledAt } = programEnrollment;
+ const hidePartnerRevenue = isPartnerRevenueHidden(group);
const response = events.map((event) => {
// don't return ip address for partner profile
@@ -44,7 +47,7 @@ export const GET = withReferralsEmbedToken(
const { ip, click, customer, ...eventRest } = event;
const { ip: _, ...clickRest } = click;
- return {
+ const mapped = {
...eventRest,
click: clickRest,
link: event?.link ? PartnerProfileLinkSchema.parse(event.link) : null,
@@ -68,6 +71,8 @@ export const GET = withReferralsEmbedToken(
}),
}),
};
+
+ return hidePartnerRevenue ? nullPartnerEventRevenue(mapped) : mapped;
});
return NextResponse.json(response);
diff --git a/apps/web/app/(ee)/app.dub.co/embed/referrals/bounties/performance-section.tsx b/apps/web/app/(ee)/app.dub.co/embed/referrals/bounties/performance-section.tsx
index dcf41526f3..5db00171e3 100644
--- a/apps/web/app/(ee)/app.dub.co/embed/referrals/bounties/performance-section.tsx
+++ b/apps/web/app/(ee)/app.dub.co/embed/referrals/bounties/performance-section.tsx
@@ -3,6 +3,7 @@
import { formatDateTooltip } from "@/lib/analytics/format-date-tooltip";
import { isCurrencyAttribute } from "@/lib/api/workflows/utils";
import { PERFORMANCE_BOUNTY_SCOPE_ATTRIBUTES } from "@/lib/bounty/api/performance-bounty-scope-attributes";
+import { isPartnerRevenueHidden } from "@/lib/partners/is-partner-revenue-hidden";
import {
LeadEvent,
PartnerBountyProps,
@@ -33,6 +34,7 @@ import { ColumnDef } from "@tanstack/react-table";
import { useMemo, useState } from "react";
import useSWR from "swr";
import { useEmbedToken } from "../../use-embed-token";
+import { useReferralsEmbedData } from "../page-client";
type PerformanceAttribute = keyof typeof PERFORMANCE_BOUNTY_SCOPE_ATTRIBUTES;
@@ -96,6 +98,15 @@ export function EmbedBountyPerformanceSection({
bounty: PartnerBountyProps;
programEnrollment: Pick<ProgramEnrollmentProps, "createdAt">;
}) {
+ const { group } = useReferralsEmbedData();
+ const attribute = bounty.performanceCondition?.attribute as
+ | PerformanceAttribute
+ | undefined;
+
+ if (attribute === "totalSaleAmount" && isPartnerRevenueHidden(group)) {
+ return null;
+ }
+
return (
<div className="flex flex-col gap-6">
<div className="flex flex-col gap-3">
diff --git a/apps/web/app/(ee)/app.dub.co/embed/referrals/get-referrals-embed-data.ts b/apps/web/app/(ee)/app.dub.co/embed/referrals/get-referrals-embed-data.ts
index 7d952b9450..b772ff1d2c 100644
--- a/apps/web/app/(ee)/app.dub.co/embed/referrals/get-referrals-embed-data.ts
+++ b/apps/web/app/(ee)/app.dub.co/embed/referrals/get-referrals-embed-data.ts
@@ -3,6 +3,7 @@ import { getProgramEnrollmentOrThrow } from "@/lib/api/programs/get-program-enro
import { getBountiesForPartner } from "@/lib/bounty/api/get-bounties-for-partner";
import { referralsEmbedToken } from "@/lib/embed/referrals/token-class";
import { aggregatePartnerLinksStats } from "@/lib/partners/aggregate-partner-links-stats";
+import { hidePartnerTotalSaleAmount } from "@/lib/partners/hide-partner-revenue";
import { prisma } from "@/lib/prisma";
import { getResolvedPartnerLinkRewards } from "@/lib/rewards/get-resolved-partner-link-rewards";
import { PartnerGroupAdditionalLink } from "@/lib/types";
@@ -180,7 +181,11 @@ export const getReferralsEmbedData = async (token: string) => {
maxPartnerLinks: group.maxPartnerLinks,
linkStructure: group.linkStructure,
holdingPeriodDays: group.holdingPeriodDays,
+ revenueDataSharingDisabledAt: group.revenueDataSharingDisabledAt,
},
- bounties,
+ bounties: bounties.map((bounty) => ({
+ ...bounty,
+ partner: hidePartnerTotalSaleAmount(bounty.partner, group),
+ })),
};
};
diff --git a/apps/web/app/(ee)/app.dub.co/embed/referrals/page-client.tsx b/apps/web/app/(ee)/app.dub.co/embed/referrals/page-client.tsx
index eed976fb78..218dc188f8 100644
--- a/apps/web/app/(ee)/app.dub.co/embed/referrals/page-client.tsx
+++ b/apps/web/app/(ee)/app.dub.co/embed/referrals/page-client.tsx
@@ -115,6 +115,7 @@ type ReferralsEmbedData = {
| "maxPartnerLinks"
| "linkStructure"
| "holdingPeriodDays"
+ | "revenueDataSharingDisabledAt"
>;
links: ReferralsEmbedLink[];
rewards: RewardProps[];
diff --git a/apps/web/lib/partners/hide-partner-revenue.ts b/apps/web/lib/partners/hide-partner-revenue.ts
new file mode 100644
index 0000000000..8653ceb9ca
--- /dev/null
+++ b/apps/web/lib/partners/hide-partner-revenue.ts
@@ -0,0 +1,76 @@
+import {
+ isPartnerRevenueHidden,
+ type PartnerRevenueVisibilityGroup,
+} from "./is-partner-revenue-hidden";
+
+/** Set `saleAmount` to null without mutating the original. */
+export function nullSaleAmount<T extends object>(data: T): T {
+ return { ...data, saleAmount: null };
+}
+
+/** Set `amount` to null without mutating the original. */
+export function nullAmount<T extends object>(data: T): T {
+ return { ...data, amount: null };
+}
+
+/** Null `saleAmount` when revenue data sharing is disabled. */
+export function hidePartnerSaleAmount<T extends object>(
+ data: T,
+ group: PartnerRevenueVisibilityGroup,
+): T {
+ return isPartnerRevenueHidden(group) ? nullSaleAmount(data) : data;
+}
+
+/** Null `totalSaleAmount` when revenue data sharing is disabled. */
+export function hidePartnerTotalSaleAmount<T extends object>(
+ data: T,
+ group: PartnerRevenueVisibilityGroup,
+): T {
+ return isPartnerRevenueHidden(group)
+ ? { ...data, totalSaleAmount: null }
+ : data;
+}
+
+/**
+ * Null sale/revenue amounts on a partner-facing event
+ * (`saleAmount`, nested `sale.amount`, and `link.saleAmount`).
+ * Caller should only invoke when revenue is hidden.
+ */
+export function nullPartnerEventRevenue<T extends object>(event: T): T {
+ const next = { ...event } as T & {
+ saleAmount?: unknown;
+ sale?: Record<string, unknown> | null;
+ link?: object | null;
+ };
+
+ if ("saleAmount" in next) {
+ next.saleAmount = null;
+ }
+
+ if (next.sale && typeof next.sale === "object") {
+ next.sale = { ...next.sale, amount: null };
+ }
+
+ if (next.link && typeof next.link === "object") {
+ next.link = nullSaleAmount(next.link);
+ }
+
+ return next;
+}
+
+/** Null `saleAmount` on analytics responses that include it. */
+export function nullAnalyticsSaleAmounts<T>(data: T): T {
+ if (Array.isArray(data)) {
+ return data.map((row) =>
+ row && typeof row === "object" && "saleAmount" in row
+ ? nullSaleAmount(row)
+ : row,
+ ) as T;
+ }
+
+ if (data && typeof data === "object" && "saleAmount" in data) {
+ return nullSaleAmount(data);
+ }
+
+ return data;
+}