Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

improve merge logic to avoid relational updates from hitting transaction limits

Steven Teyaa1adfcf6b08
diff --git a/apps/web/app/(ee)/api/cron/partners/merge-accounts/route.ts b/apps/web/app/(ee)/api/cron/partners/merge-accounts/route.ts
index 564517dd6f..f0d85d0916 100644
--- a/apps/web/app/(ee)/api/cron/partners/merge-accounts/route.ts
+++ b/apps/web/app/(ee)/api/cron/partners/merge-accounts/route.ts
@@ -76,7 +76,6 @@ export async function POST(req: Request) {
userId: true,
},
},
- partnerRewinds: true,
},
});
@@ -119,29 +118,6 @@ export async function POST(req: Request) {
const { id: targetPartnerId, programs: targetPartnerEnrollments } =
targetAccount;
- // Find new enrollments that are not in the target partner enrollments
- const newEnrollments = sourcePartnerEnrollments.filter(
- ({ programId }) =>
- !targetPartnerEnrollments.some(
- ({ programId: targetProgramId }) => programId === targetProgramId,
- ),
- );
-
- // Update program enrollments
- if (newEnrollments.length > 0) {
- await prisma.programEnrollment.updateMany({
- where: {
- programId: {
- in: newEnrollments.map(({ programId }) => programId),
- },
- partnerId: sourcePartnerId,
- },
- data: {
- partnerId: targetPartnerId,
- },
- });
- }
-
const programIdsToTransfer = sourcePartnerEnrollments.map(
({ programId }) => programId,
);
@@ -158,8 +134,8 @@ export async function POST(req: Request) {
},
};
- // update links and payouts
if (programIdsToTransfer.length > 0) {
+ // update links and payouts
const [updatedLinksRes, updatedPayoutsRes] = await Promise.all([
prisma.link.updateMany(updateManyPayload),
prisma.payout.updateMany(updateManyPayload),
@@ -264,6 +240,29 @@ export async function POST(req: Request) {
console.log(prettyPrint(res));
}
+ // Update program enrollments – we do this last to avoid relational updates on Commission, Customer, etc. from running into transaction limits
+ // First, we start with new enrollments (enrollments that are not duplicate in both source and target)
+ const newEnrollments = sourcePartnerEnrollments.filter(
+ ({ programId }) =>
+ !targetPartnerEnrollments.some(
+ ({ programId: targetProgramId }) => programId === targetProgramId,
+ ),
+ );
+ if (newEnrollments.length > 0) {
+ await prisma.programEnrollment.updateMany({
+ where: {
+ programId: {
+ in: newEnrollments.map(({ programId }) => programId),
+ },
+ partnerId: sourcePartnerId,
+ },
+ data: {
+ partnerId: targetPartnerId,
+ },
+ });
+ }
+
+ // Then, we transfer existing enrollments (enrollments that are duplicate in both source and target) – needs to be handled delicately via a for loop
const existingEnrollments = sourcePartnerEnrollments.filter(
({ programId }) =>
targetPartnerEnrollments.some(
@@ -324,16 +323,6 @@ export async function POST(req: Request) {
}
}
- // If source account has rewind, need to delete and recalculate for the target account
- if (sourceAccount.partnerRewinds.length > 0) {
- const deletedRewinds = await prisma.partnerRewind.deleteMany({
- where: {
- partnerId: sourcePartnerId,
- },
- });
- console.log(`Deleted ${deletedRewinds.count} partner rewinds`);
- }
-
// Remove the user if there are no workspaces left
// TODO: we need to handle deleting multiple users when we allow partners to invite their team members in the future
const sourcePartnerUser = sourcePartnerUsers[0];