Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Hard-delete orphaned rewards only when no references remain.

Kiran Kaa883b8a31aa
diff --git a/apps/web/app/(ee)/api/cron/cleanup/orphaned-rewards/route.ts b/apps/web/app/(ee)/api/cron/cleanup/orphaned-rewards/route.ts
index f2de40087b..84fecfd483 100644
--- a/apps/web/app/(ee)/api/cron/cleanup/orphaned-rewards/route.ts
+++ b/apps/web/app/(ee)/api/cron/cleanup/orphaned-rewards/route.ts
@@ -1,6 +1,7 @@
import { PRISMA_UPDATEMANY_LIMIT } from "@/lib/cron";
import { withCron } from "@/lib/cron/with-cron";
import { prisma } from "@/lib/prisma";
+import { deleteOrphanedRewards } from "@/lib/rewards/delete-orphaned-rewards";
import { subMinutes } from "date-fns";
import { logAndRespond } from "../../utils";
@@ -32,75 +33,6 @@ export const POST = withCron(async () => {
);
});
-async function deleteOrphanedRewards(cutoff: Date) {
- const rewards = await prisma.reward.findMany({
- where: {
- programId: null,
- updatedAt: {
- lt: cutoff,
- },
- },
- select: {
- id: true,
- clickPartnerGroup: true,
- leadPartnerGroup: true,
- salePartnerGroup: true,
- referralPartnerGroup: true,
- customPartnerGroup: true,
- _count: {
- select: {
- clickEnrollments: true,
- leadEnrollments: true,
- saleEnrollments: true,
- referralEnrollments: true,
- customEnrollments: true,
- },
- },
- },
- orderBy: {
- updatedAt: "asc",
- },
- take: 100,
- });
-
- if (rewards.length === 0) {
- return 0;
- }
-
- const rewardsToDelete = rewards.filter((reward) => {
- return (
- reward.clickPartnerGroup === null &&
- reward.leadPartnerGroup === null &&
- reward.salePartnerGroup === null &&
- reward.referralPartnerGroup === null &&
- reward.customPartnerGroup === null &&
- reward._count.clickEnrollments === 0 &&
- reward._count.leadEnrollments === 0 &&
- reward._count.saleEnrollments === 0 &&
- reward._count.referralEnrollments === 0 &&
- reward._count.customEnrollments === 0
- );
- });
-
- console.log(
- `Found ${rewardsToDelete.length} rewards to delete out of ${rewards.length} rewards (some of them are referenced by partner groups or program enrollments).`,
- );
-
- if (rewardsToDelete.length === 0) {
- return 0;
- }
-
- const deletedRewards = await prisma.reward.deleteMany({
- where: {
- id: {
- in: rewardsToDelete.map((reward) => reward.id),
- },
- },
- });
-
- return deletedRewards.count;
-}
-
async function deleteEmptyLinkRewards() {
let deletedCount = 0;
diff --git a/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/route.ts b/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/route.ts
index 5844b755c3..c48e1e8cc9 100644
--- a/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/route.ts
+++ b/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/route.ts
@@ -1,6 +1,6 @@
import { recordAuditLog } from "@/lib/api/audit-logs/record-audit-log";
import { DubApiError } from "@/lib/api/errors";
-import { deletePartnerGroup } from "@/lib/api/groups/delete-partner-group";
+import { deletePartnerGroup } from "@/lib/api/groups/delete-group";
import { getGroupOrThrow } from "@/lib/api/groups/get-group-or-throw";
import { upsertGroupMoveRules } from "@/lib/api/groups/upsert-group-move-rules";
import { getDefaultProgramIdOrThrow } from "@/lib/api/programs/get-default-program-id-or-throw";
diff --git a/apps/web/lib/api/groups/delete-partner-group.ts b/apps/web/lib/api/groups/delete-group.ts
similarity index 98%
rename from apps/web/lib/api/groups/delete-partner-group.ts
rename to apps/web/lib/api/groups/delete-group.ts
index 79c4cb9e40..29699d1d93 100644
--- a/apps/web/lib/api/groups/delete-partner-group.ts
+++ b/apps/web/lib/api/groups/delete-group.ts
@@ -55,6 +55,7 @@ export async function deletePartnerGroup(
},
data: {
programId: null,
+ groupId: null,
},
}),
diff --git a/apps/web/lib/rewards/delete-orphaned-rewards.ts b/apps/web/lib/rewards/delete-orphaned-rewards.ts
new file mode 100644
index 0000000000..0b40740906
--- /dev/null
+++ b/apps/web/lib/rewards/delete-orphaned-rewards.ts
@@ -0,0 +1,130 @@
+import { pluck } from "@dub/utils";
+import { prisma } from "../prisma";
+import { REWARD_EVENT_COLUMN_MAPPING } from "../zod/schemas/rewards";
+
+const LINK_REWARD_EVENT_COLUMNS = new Set([
+ "clickRewardId",
+ "leadRewardId",
+ "saleRewardId",
+]);
+
+// Delete rewards that are orphaned (not associated with a program or partner group or commissions)
+export async function deleteOrphanedRewards(cutoff: Date) {
+ const rewards = await prisma.reward.findMany({
+ where: {
+ programId: null,
+ updatedAt: {
+ lt: cutoff,
+ },
+ },
+ orderBy: {
+ updatedAt: "asc",
+ },
+ take: 50,
+ });
+
+ if (rewards.length === 0) {
+ return 0;
+ }
+
+ const rewardsByEvent = Object.groupBy(rewards, (reward) => reward.event);
+ const rewardIdsToHardDelete: string[] = [];
+
+ for (const [event, eventRewards] of Object.entries(rewardsByEvent)) {
+ if (!eventRewards?.length) {
+ continue;
+ }
+
+ const rewardIdColumn = REWARD_EVENT_COLUMN_MAPPING[event];
+ const rewardIds = pluck(eventRewards, "id");
+
+ // Not all reward type support link rewards
+ const canReferenceLinkReward =
+ LINK_REWARD_EVENT_COLUMNS.has(rewardIdColumn);
+
+ const [enrollments, groups, linkRewards, commissions] = await Promise.all([
+ prisma.programEnrollment.findMany({
+ where: {
+ [rewardIdColumn]: {
+ in: rewardIds,
+ },
+ },
+ select: {
+ [rewardIdColumn]: true,
+ },
+ }),
+
+ prisma.partnerGroup.findMany({
+ where: {
+ [rewardIdColumn]: {
+ in: rewardIds,
+ },
+ },
+ select: {
+ [rewardIdColumn]: true,
+ },
+ }),
+
+ canReferenceLinkReward
+ ? prisma.linkReward.findMany({
+ where: {
+ [rewardIdColumn]: {
+ in: rewardIds,
+ },
+ },
+ select: {
+ [rewardIdColumn]: true,
+ },
+ })
+ : Promise.resolve([]),
+
+ prisma.commission.findMany({
+ where: {
+ rewardId: {
+ in: rewardIds,
+ },
+ },
+ select: {
+ rewardId: true,
+ },
+ }),
+ ]);
+
+ // Collect all reward IDs that are referenced by enrollments, groups, link rewards, or commissions
+ const referencedRewardIds = new Set<string>();
+
+ for (const row of [...enrollments, ...groups, ...linkRewards]) {
+ const rewardId = row[rewardIdColumn];
+ if (typeof rewardId === "string") {
+ referencedRewardIds.add(rewardId);
+ }
+ }
+
+ for (const { rewardId } of commissions) {
+ if (rewardId) {
+ referencedRewardIds.add(rewardId);
+ }
+ }
+
+ // If the reward is not referenced by any enrollments, groups, link rewards, or commissions, it can be hard deleted
+ for (const reward of eventRewards) {
+ if (!referencedRewardIds.has(reward.id)) {
+ rewardIdsToHardDelete.push(reward.id);
+ }
+ }
+ }
+
+ if (rewardIdsToHardDelete.length === 0) {
+ return 0;
+ }
+
+ const { count } = await prisma.reward.deleteMany({
+ where: {
+ id: {
+ in: rewardIdsToHardDelete,
+ },
+ },
+ });
+
+ return count;
+}