Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

discountId → idOrCode

Steven Teyab8dc977db1f
diff --git a/apps/web/app/(ee)/api/discount-codes/[discountCodeId]/route.ts b/apps/web/app/(ee)/api/discount-codes/[idOrCode]/route.ts
similarity index 63%
rename from apps/web/app/(ee)/api/discount-codes/[discountCodeId]/route.ts
rename to apps/web/app/(ee)/api/discount-codes/[idOrCode]/route.ts
index 26ed37d546..8a0d07b5b3 100644
--- a/apps/web/app/(ee)/api/discount-codes/[discountCodeId]/route.ts
+++ b/apps/web/app/(ee)/api/discount-codes/[idOrCode]/route.ts
@@ -1,26 +1,44 @@
import { recordAuditLog } from "@/lib/api/audit-logs/record-audit-log";
+import { DubApiError } from "@/lib/api/errors";
import { getDefaultProgramIdOrThrow } from "@/lib/api/programs/get-default-program-id-or-throw";
import { withWorkspace } from "@/lib/auth";
-import { getDiscountCodeOrThrow } from "@/lib/discount-codes/get-discount-code-or-throw";
import { deleteDiscountCodes } from "@/lib/discounts/delete-discount-code";
import { prisma } from "@/lib/prisma";
import { waitUntil } from "@vercel/functions";
import { NextResponse } from "next/server";
-// DELETE /api/discount-codes/[discountCodeId] - delete a discount code
+// DELETE /api/discount-codes/[idOrCode] - delete a discount code
export const DELETE = withWorkspace(
async ({ workspace, params, session }) => {
- const { discountCodeId } = params;
+ const { idOrCode } = params;
const programId = getDefaultProgramIdOrThrow(workspace);
- const discountCode = await getDiscountCodeOrThrow({
- discountCodeId,
- programId,
+ const discountCode = await prisma.discountCode.findUnique({
+ where: idOrCode.startsWith("dcode_")
+ ? { id: idOrCode }
+ : { programId_code: { programId, code: idOrCode } },
+ include: {
+ discount: true,
+ },
});
+ if (!discountCode || !discountCode.discount) {
+ throw new DubApiError({
+ code: "not_found",
+ message: `Discount code (${idOrCode}) not found.`,
+ });
+ }
+
+ if (discountCode.programId !== programId) {
+ throw new DubApiError({
+ code: "not_found",
+ message: `Discount code (${idOrCode}) not found.`,
+ });
+ }
+
await prisma.discountCode.update({
where: {
- id: discountCodeId,
+ id: discountCode.id,
},
data: {
discountId: null,
diff --git a/apps/web/lib/discount-codes/get-discount-code-or-throw.ts b/apps/web/lib/discount-codes/get-discount-code-or-throw.ts
deleted file mode 100644
index 8af87ac13b..0000000000
--- a/apps/web/lib/discount-codes/get-discount-code-or-throw.ts
+++ /dev/null
@@ -1,40 +0,0 @@
-import { prisma } from "@/lib/prisma";
-import { DubApiError } from "../api/errors";
-
-export async function getDiscountCodeOrThrow({
- discountCodeId,
- programId,
-}: {
- discountCodeId: string;
- programId: string;
-}) {
- const discountCode = await prisma.discountCode.findUnique({
- where: {
- id: discountCodeId,
- },
- include: {
- discount: true,
- },
- });
-
- if (!discountCode || !discountCode.discount) {
- throw new DubApiError({
- code: "not_found",
- message: `Discount code (${discountCodeId}) not found.`,
- });
- }
-
- if (discountCode.programId !== programId) {
- throw new DubApiError({
- code: "not_found",
- message: `Discount code (${discountCodeId}) not found.`,
- });
- }
-
- const { discount, ...rest } = discountCode;
-
- return {
- ...rest,
- discount,
- };
-}
diff --git a/apps/web/lib/openapi/discount-codes/delete-discount-code.ts b/apps/web/lib/openapi/discount-codes/delete-discount-code.ts
index 9f4d41a7d3..06d8d21887 100644
--- a/apps/web/lib/openapi/discount-codes/delete-discount-code.ts
+++ b/apps/web/lib/openapi/discount-codes/delete-discount-code.ts
@@ -9,17 +9,17 @@ export const deleteDiscountCode: ZodOpenApiOperationObject = {
"x-speakeasy-max-method-params": 1,
summary: "Delete a discount code",
description:
- "Delete a discount code for a partner. This will also disable the code in your connected discount provider (Stripe, Shopify, or custom via `disccount.deleted` webhook).",
+ "Delete a discount code for a partner by its unique ID or alphanumeric code. This will also disable the code in your connected discount provider (Stripe, Shopify, or custom via `disccount.deleted` webhook).",
requestParams: {
path: z.object({
- id: DiscountCodeSchema.shape.id.describe(
- "The ID of the discount code to delete.",
+ idOrCode: DiscountCodeSchema.shape.id.describe(
+ "The unique ID (e.g. `dcode_...`) or alphanumeric code (e.g. `ABC123`) of the discount code to delete.",
),
}),
},
responses: {
"200": {
- description: "The deleted discount code ID.",
+ description: "The deleted discount code unique ID (e.g. `dcode_...`).",
content: {
"application/json": {
schema: DiscountCodeSchema.pick({ id: true }),
diff --git a/apps/web/lib/openapi/discount-codes/index.ts b/apps/web/lib/openapi/discount-codes/index.ts
index 01eafc4392..f5ec228406 100644
--- a/apps/web/lib/openapi/discount-codes/index.ts
+++ b/apps/web/lib/openapi/discount-codes/index.ts
@@ -8,7 +8,7 @@ export const discountCodesPaths: ZodOpenApiPathsObject = {
get: listDiscountCodes,
post: createDiscountCode,
},
- "/discount-codes/{id}": {
+ "/discount-codes/{idOrCode}": {
delete: deleteDiscountCode,
},
};