Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

code improvements

Pedro Ladeiraac492640725d
diff --git a/apps/web/app/(ee)/api/admin/fraud-alerts/[id]/route.ts b/apps/web/app/(ee)/api/admin/fraud-alerts/[id]/route.ts
index 2ea817d249..c8a0b61562 100644
--- a/apps/web/app/(ee)/api/admin/fraud-alerts/[id]/route.ts
+++ b/apps/web/app/(ee)/api/admin/fraud-alerts/[id]/route.ts
@@ -25,6 +25,7 @@ export const PATCH = withAdmin(
},
select: {
partnerId: true,
+ status: true,
},
});
@@ -32,6 +33,12 @@ export const PATCH = withAdmin(
return new Response("Fraud alert not found.", { status: 404 });
}
+ if (newStatus === "confirmed" && fraudAlert.status !== "pending") {
+ return new Response("Fraud alert has already been reviewed.", {
+ status: 409,
+ });
+ }
+
const reviewData: Prisma.FraudAlertUpdateManyArgs["data"] = {
reviewedAt: new Date(),
reviewNote: reviewNote || null,
diff --git a/apps/web/app/(ee)/api/admin/partners/[partnerId]/flag-fraud/route.ts b/apps/web/app/(ee)/api/admin/partners/[partnerId]/flag-fraud/route.ts
index 77566550d5..e8248b25ca 100644
--- a/apps/web/app/(ee)/api/admin/partners/[partnerId]/flag-fraud/route.ts
+++ b/apps/web/app/(ee)/api/admin/partners/[partnerId]/flag-fraud/route.ts
@@ -49,15 +49,26 @@ export const POST = withAdmin(
const anchorProgramId =
networkEnrollment?.programId ?? activeEnrollments[0].programId;
- await prisma.fraudAlert.create({
- data: {
+ const pendingAdminAlert = await prisma.fraudAlert.findFirst({
+ where: {
partnerId,
- programId: anchorProgramId,
- reason,
source: "admin",
+ status: "pending",
},
+ select: { id: true },
});
+ if (!pendingAdminAlert) {
+ await prisma.fraudAlert.create({
+ data: {
+ partnerId,
+ programId: anchorProgramId,
+ reason,
+ source: "admin",
+ },
+ });
+ }
+
const { confirmedCount } = await confirmPartnerFraudAlerts({
partnerId,
reviewedById: session.user.id,
@@ -69,14 +80,21 @@ export const POST = withAdmin(
return new Response("Failed to confirm fraud alert.", { status: 500 });
}
- const alertedProgramsCount = await reportAdminFraudToPrograms({
- partnerId,
- });
+ try {
+ const alertedProgramsCount = await reportAdminFraudToPrograms({
+ partnerId,
+ });
- return NextResponse.json({
- success: true,
- alertedProgramsCount,
- });
+ return NextResponse.json({
+ success: true,
+ alertedProgramsCount,
+ });
+ } catch {
+ return new Response(
+ "Fraud alert was confirmed but alerting enrolled programs failed. Please try again.",
+ { status: 500 },
+ );
+ }
},
{
requiredRoles: ["owner"],
diff --git a/apps/web/lib/api/fraud/confirm-partner-fraud-alerts.ts b/apps/web/lib/api/fraud/confirm-partner-fraud-alerts.ts
index 3ffa2561a5..482c421386 100644
--- a/apps/web/lib/api/fraud/confirm-partner-fraud-alerts.ts
+++ b/apps/web/lib/api/fraud/confirm-partner-fraud-alerts.ts
@@ -47,7 +47,7 @@ export async function confirmPartnerFraudAlerts({
return { confirmedCount: 0, alertedProgramsCount: 0 };
}
- await prisma.fraudAlert.updateMany({
+ const { count: confirmedCount } = await prisma.fraudAlert.updateMany({
where: {
id: {
in: pendingFraudAlerts.map((fa) => fa.id),
@@ -60,15 +60,44 @@ export async function confirmPartnerFraudAlerts({
},
});
+ if (confirmedCount === 0) {
+ return { confirmedCount: 0, alertedProgramsCount: 0 };
+ }
+
if (skipCrossProgramReporting) {
return {
- confirmedCount: pendingFraudAlerts.length,
+ confirmedCount,
alertedProgramsCount: 0,
};
}
- const alertCounts = await Promise.all(
- pendingFraudAlerts.map(({ programEnrollment, createdAt }) =>
+ const confirmedFraudAlerts = await prisma.fraudAlert.findMany({
+ where: {
+ id: { in: pendingFraudAlerts.map((fa) => fa.id) },
+ status: "confirmed",
+ reviewedById,
+ },
+ select: {
+ id: true,
+ createdAt: true,
+ programEnrollment: {
+ select: {
+ programId: true,
+ partnerId: true,
+ bannedReason: true,
+ bannedAt: true,
+ application: {
+ select: {
+ reviewedAt: true,
+ },
+ },
+ },
+ },
+ },
+ });
+
+ const alertResults = await Promise.allSettled(
+ confirmedFraudAlerts.map(({ programEnrollment, createdAt }) =>
reportCrossProgramBanToNetwork({
partnerId: programEnrollment.partnerId,
programId: programEnrollment.programId,
@@ -81,8 +110,21 @@ export async function confirmPartnerFraudAlerts({
),
);
+ const failedReports = alertResults.filter(
+ (result) => result.status === "rejected",
+ );
+ if (failedReports.length > 0) {
+ console.error(
+ "[confirmPartnerFraudAlerts] Failed to report cross-program bans",
+ failedReports,
+ );
+ }
+
return {
- confirmedCount: pendingFraudAlerts.length,
- alertedProgramsCount: alertCounts.reduce((sum, count) => sum + count, 0),
+ confirmedCount,
+ alertedProgramsCount: alertResults.reduce(
+ (sum, result) => sum + (result.status === "fulfilled" ? result.value : 0),
+ 0,
+ ),
};
}
diff --git a/apps/web/lib/api/fraud/report-admin-fraud-to-programs.ts b/apps/web/lib/api/fraud/report-admin-fraud-to-programs.ts
index 9d9d50b432..4c60b989f7 100644
--- a/apps/web/lib/api/fraud/report-admin-fraud-to-programs.ts
+++ b/apps/web/lib/api/fraud/report-admin-fraud-to-programs.ts
@@ -15,6 +15,9 @@ export async function reportAdminFraudToPrograms({
let affectedProgramEnrollments = await prisma.programEnrollment.findMany({
where: {
partnerId,
+ programId: {
+ not: NETWORK_PROGRAM_ID,
+ },
status: {
notIn: INACTIVE_ENROLLMENT_STATUSES,
},