Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

fix partner link key updates when the link has no details

Pedro Ladeiraaca8a989533c
diff --git a/apps/web/lib/api/links/update-link.ts b/apps/web/lib/api/links/update-link.ts
index 2134020cb8..096d5b2b99 100644
--- a/apps/web/lib/api/links/update-link.ts
+++ b/apps/web/lib/api/links/update-link.ts
@@ -38,7 +38,9 @@ export async function updateLink({
partnerId: string | null;
};
updatedLink: ProcessedLinkProps &
- Pick<LinkProps, "id" | "clicks" | "lastClicked" | "updatedAt">;
+ Pick<LinkProps, "id" | "clicks" | "lastClicked" | "updatedAt"> & {
+ partnerLinkDetails?: unknown;
+ };
}) {
let {
id,
@@ -76,6 +78,7 @@ export async function updateLink({
testCompletedAt,
partnerLinkTitle,
partnerLinkComments,
+ partnerLinkDetails: _partnerLinkDetails,
...rest
} = updatedLink;
diff --git a/apps/web/playwright/api/partner-profile/links.spec.ts b/apps/web/playwright/api/partner-profile/links.spec.ts
index 51054f7eb9..7d634d86e9 100644
--- a/apps/web/playwright/api/partner-profile/links.spec.ts
+++ b/apps/web/playwright/api/partner-profile/links.spec.ts
@@ -191,6 +191,60 @@ test("POST /partner-profile/programs/:id/links - allowed additionalLinks domain"
}
});
+test("PATCH /partner-profile/programs/:id/links/:linkId - update key", async ({
+ api,
+ program,
+ playwright,
+}) => {
+ let partnerId: string | undefined;
+ let userId: string | undefined;
+
+ try {
+ const { data: partner } = await createPartner(api);
+ partnerId = partner.id;
+ const auth = await createPartnerProfileAuth(partner);
+ userId = auth.userId;
+
+ const { api: partnerApi, dispose } = await createBearerApiClient({
+ playwright,
+ token: auth.token,
+ });
+
+ try {
+ const { data: links } = await partnerApi.get<PartnerProfileLink[]>(
+ `/api/partner-profile/programs/${program.id}/links`,
+ );
+ const link =
+ links.find((link) => link.partnerGroupDefaultLinkId) ?? links[0];
+
+ expect(
+ await prisma.partnerLinkDetails.findUnique({
+ where: { linkId: link.id },
+ }),
+ ).toBeNull();
+
+ const key = nanoid(8);
+ const { status, data } = await partnerApi.patch<PartnerProfileLink>(
+ `/api/partner-profile/programs/${program.id}/links/${link.id}`,
+ { key },
+ );
+
+ expect(status).toEqual(200);
+ expect(data).toMatchObject({
+ id: link.id,
+ domain: TEST_WORKSPACE.program.domain,
+ key,
+ shortLink: `https://${TEST_WORKSPACE.program.domain}/${key}`,
+ });
+ } finally {
+ await dispose();
+ }
+ } finally {
+ if (userId) await prisma.user.delete({ where: { id: userId } });
+ await deletePartner(partnerId);
+ }
+});
+
test("PATCH /partner-profile/programs/:id/links/:linkId - cannot change default link URL", async ({
api,
program,