Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

code improvements

Pedro Ladeiraaec9d02c13b7
diff --git a/apps/web/lib/swr/use-partner-links-display.tsx b/apps/web/lib/swr/use-partner-links-display.tsx
index 08cbf38b92..1d09260737 100644
--- a/apps/web/lib/swr/use-partner-links-display.tsx
+++ b/apps/web/lib/swr/use-partner-links-display.tsx
@@ -107,10 +107,14 @@ export function PartnerLinksDisplayProvider({
return false;
}, [displayOption, displayProperties, resolvedPersisted]);
+ const effectiveDisplayOption = !showDetailedAnalytics
+ ? "cards"
+ : displayOption;
+
return (
<PartnerLinksDisplayContext.Provider
value={{
- displayOption,
+ displayOption: effectiveDisplayOption,
setDisplayOption,
displayProperties,
setDisplayProperties,
diff --git a/apps/web/scripts/migrations/backfill-partner-link-comments.ts b/apps/web/scripts/migrations/backfill-partner-link-comments.ts
index f3dab90a6c..83de0b5b8e 100644
--- a/apps/web/scripts/migrations/backfill-partner-link-comments.ts
+++ b/apps/web/scripts/migrations/backfill-partner-link-comments.ts
@@ -33,8 +33,8 @@ async function main() {
await Promise.all(
links.map(({ id, comments }) =>
- prisma.link.update({
- where: { id },
+ prisma.link.updateMany({
+ where: { id, partnerLinkComments: null },
data: { partnerLinkComments: comments },
}),
),
diff --git a/apps/web/ui/analytics/events/events-table.tsx b/apps/web/ui/analytics/events/events-table.tsx
index 69dbec1887..d0a458ea7e 100644
--- a/apps/web/ui/analytics/events/events-table.tsx
+++ b/apps/web/ui/analytics/events/events-table.tsx
@@ -179,13 +179,10 @@ export default function EventsTable({
shortLink?: string;
}) => {
if (partnerPage) {
- if (
- partnerDisplayProperties.includes("title") &&
- d.partnerLinkTitle
- ) {
+ if (partnerDisplayProperties.includes("title") && d.partnerLinkTitle) {
return d.partnerLinkTitle;
}
- return d.shortLink || "Unknown";
+ return d.shortLink ? getPrettyUrl(d.shortLink) : "Unknown";
}
const displayProperties = persisted?.displayProperties;
@@ -194,7 +191,7 @@ export default function EventsTable({
return d.title;
}
- return d.shortLink || "Unknown";
+ return d.shortLink ? getPrettyUrl(d.shortLink) : "Unknown";
},
[persisted, partnerPage, partnerDisplayProperties],
);
@@ -354,6 +351,7 @@ export default function EventsTable({
filterParams: ({ getValue }) => ({ linkId: getValue().id }),
},
cell: ({ getValue }) => {
+ const label = shortLinkTitle(getValue());
const content = (
<div
className={cn(
@@ -366,8 +364,8 @@ export default function EventsTable({
apexDomain={getApexDomain(getValue().url)}
className="size-4 shrink-0 sm:size-4"
/>
- <span className="truncate" title={shortLinkTitle(getValue())}>
- {getPrettyUrl(shortLinkTitle(getValue()))}
+ <span className="truncate" title={label}>
+ {label}
</span>
</div>
);
diff --git a/apps/web/ui/analytics/use-analytics-filters.tsx b/apps/web/ui/analytics/use-analytics-filters.tsx
index 462e86ff92..e0044ce8a2 100644
--- a/apps/web/ui/analytics/use-analytics-filters.tsx
+++ b/apps/web/ui/analytics/use-analytics-filters.tsx
@@ -910,6 +910,7 @@ export function useAnalyticsFilters({
utmData,
searchParamsObj.tagId,
searchParamsObj.domain,
+ partnerDisplayProperties,
],
);