Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

simplify deeplink page, improve application update email

Steven Teyafc8b88b5b48
diff --git a/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/action-buttons.tsx b/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/action-buttons.tsx
index 4b7401649f..63e37197e9 100644
--- a/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/action-buttons.tsx
+++ b/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/action-buttons.tsx
@@ -1,18 +1,16 @@
"use client";
import { Link } from "@dub/prisma/client";
-import { AndroidLogo, Button, IOSAppStore, useCopyToClipboard } from "@dub/ui";
+import { Button, useCopyToClipboard } from "@dub/ui";
import { useSearchParams } from "next/navigation";
import { getTranslations, Language } from "./translations";
export function DeepLinkActionButtons({
link,
language,
- platform,
}: {
link: Pick<Link, "shortLink">;
language: Language;
- platform: "ios" | "android";
}) {
const t = getTranslations(language);
const searchParams = useSearchParams();
@@ -20,34 +18,18 @@ export function DeepLinkActionButtons({
const [_copied, copyToClipboard] = useCopyToClipboard();
- const handleClick = async ({ withCopy }: { withCopy?: boolean } = {}) => {
- if (withCopy) {
- await copyToClipboard(
- `${link.shortLink}${searchParamsString ? `?${searchParamsString}` : ""}`,
- );
- }
-
+ const handleClick = async () => {
+ await copyToClipboard(
+ `${link.shortLink}${searchParamsString ? `?${searchParamsString}` : ""}`,
+ );
window.location.href = `${link.shortLink}?skip_deeplink_preview=1${searchParamsString ? `&${searchParamsString}` : ""}`;
};
- const Icon = platform === "android" ? AndroidLogo : IOSAppStore;
-
return (
- <div className="flex flex-col items-center gap-4">
- <Button
- text={t.openInApp}
- className="h-12 w-full rounded-xl bg-neutral-900 text-white"
- variant="primary"
- onClick={() => handleClick({ withCopy: true })}
- icon={<Icon className="size-6" />}
- />
-
- <button
- onClick={() => handleClick()}
- className="text-sm text-neutral-500"
- >
- {t.openInAppWithoutCopying}
- </button>
- </div>
+ <Button
+ text={t.openInApp}
+ className="h-12 w-full rounded-xl bg-neutral-900 text-white"
+ onClick={handleClick}
+ />
);
}
diff --git a/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/page.tsx b/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/page.tsx
index f76b15b909..37e2a4243b 100644
--- a/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/page.tsx
+++ b/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/page.tsx
@@ -179,11 +179,7 @@ export default async function DeepLinkPreviewPage(props: {
</div>
</div>
- <DeepLinkActionButtons
- link={link}
- language={language}
- platform={platform}
- />
+ <DeepLinkActionButtons link={link} language={language} />
</div>
</div>
</main>
diff --git a/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/translations.ts b/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/translations.ts
index 028f708841..9a941c98e2 100644
--- a/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/translations.ts
+++ b/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/translations.ts
@@ -3,34 +3,29 @@ export const translations = {
poweredBy: "Powered by",
description: "Clicking below will copy this page and open it in the app.",
openInApp: "Open in the app",
- openInAppWithoutCopying: "Open in the app without copying",
},
zh: {
poweredBy: "由",
description: "点击下方将复制此页面并在应用中打开。",
openInApp: "在应用中打开",
- openInAppWithoutCopying: "在应用中打开(不复制)",
},
es: {
poweredBy: "Desarrollado por",
description:
"Al hacer clic a continuación, se copiará esta página y se abrirá en la aplicación.",
openInApp: "Abrir en la aplicación",
- openInAppWithoutCopying: "Abrir en la aplicación sin copiar",
},
fr: {
poweredBy: "Propulsé par",
description:
"En cliquant ci-dessous, cette page sera copiée et ouverte dans l'application.",
openInApp: "Ouvrir dans l'application",
- openInAppWithoutCopying: "Ouvrir dans l'application sans copier",
},
tr: {
poweredBy: "tarafından desteklenmektedir",
poweredByOrder: "inverted",
description: "Linki uygulamada açmak için aşağıdaki butona tıklayın.",
openInApp: "Uygulamada aç",
- openInAppWithoutCopying: "Kopyalamadan uygulamada aç",
},
} as const;
diff --git a/packages/email/src/templates/network-partner-application-rejected.tsx b/packages/email/src/templates/network-partner-application-rejected.tsx
index b4a4bf31ef..d98f5f12f4 100644
--- a/packages/email/src/templates/network-partner-application-rejected.tsx
+++ b/packages/email/src/templates/network-partner-application-rejected.tsx
@@ -38,7 +38,8 @@ export default function NetworkPartnerApplicationRejected({
<Text className="text-sm leading-6 text-neutral-600">
{name ? `Hi ${name}, t` : "T"}hanks for your interest in joining
- the <strong>Dub Partner Network</strong>.
+ the{" "}
+ <strong className="text-neutral-800">Dub Partner Network</strong>.
</Text>
<Text className="text-sm leading-6 text-neutral-600">
@@ -46,6 +47,19 @@ export default function NetworkPartnerApplicationRejected({
approve your application at this time.
</Text>
+ <Text className="text-sm font-semibold leading-6 text-neutral-800">
+ Please note that this Dub Partner Network rejection only affects
+ your access to the{" "}
+ <Link
+ className="text-neutral-800 underline"
+ href="https://dub.co/help/article/program-marketplace"
+ >
+ program marketplace
+ </Link>
+ . It does not impact any existing program partnerships or payouts
+ you may already have.
+ </Text>
+
<Text className="text-sm leading-6 text-neutral-600">
Unfortunately, we cannot provide individual feedback about your
application. We encourage you to keep improving on your profile