Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Make partner group-change side effects idempotent across job retries.

Kiran Kb2cbbedf6ada
diff --git a/apps/web/lib/api/groups/move-partners-to-group.ts b/apps/web/lib/api/groups/move-partners-to-group.ts
index 2e9abdfb6f..dbdb0c6c6d 100644
--- a/apps/web/lib/api/groups/move-partners-to-group.ts
+++ b/apps/web/lib/api/groups/move-partners-to-group.ts
@@ -1,6 +1,6 @@
import { processPartnerGroupChangeJob } from "@/lib/jobs/handlers/process-partner-group-change-job";
import { prisma } from "@/lib/prisma";
-import { pluck } from "@dub/utils";
+import { nanoid, pluck } from "@dub/utils";
import { PartnerGroup, Prisma } from "@prisma/client";
import { buildProgramEnrollmentChangeSet } from "../activity-log/build-program-enrollment-change-set";
import { trackActivityLogsTx } from "../activity-log/track-activity-log";
@@ -190,6 +190,7 @@ export async function movePartnersToGroup({
groupId: group.id,
movedPartnerIds,
userId,
+ idempotencyKey: nanoid(10),
},
{
label: group.id,
diff --git a/apps/web/lib/api/partners/notify-partner-group-change.ts b/apps/web/lib/api/partners/notify-partner-group-change.ts
index f202068025..ad507e87fa 100644
--- a/apps/web/lib/api/partners/notify-partner-group-change.ts
+++ b/apps/web/lib/api/partners/notify-partner-group-change.ts
@@ -7,6 +7,7 @@ interface NotifyPartnerGroupChangeParams {
programId: string;
groupId: string;
partnerIds: string[];
+ idempotencyKey?: string;
}
// Send email to partners when they are moved to a new group
@@ -14,6 +15,7 @@ export async function notifyPartnerGroupChange({
programId,
groupId,
partnerIds,
+ idempotencyKey,
}: NotifyPartnerGroupChangeParams) {
if (partnerIds.length === 0) {
return;
@@ -58,5 +60,6 @@ export async function notifyPartnerGroupChange({
bounties,
},
})),
+ idempotencyKey ? { idempotencyKey } : undefined,
);
}
diff --git a/apps/web/lib/bounty/api/trigger-draft-bounty-submissions.ts b/apps/web/lib/bounty/api/trigger-draft-bounty-submissions.ts
index 93cc5acc98..b6c1c554b8 100644
--- a/apps/web/lib/bounty/api/trigger-draft-bounty-submissions.ts
+++ b/apps/web/lib/bounty/api/trigger-draft-bounty-submissions.ts
@@ -13,9 +13,11 @@ import {
export async function triggerDraftBountySubmissionCreation({
programId,
partnerIds,
+ idempotencyKey,
}: {
programId: string;
partnerIds: string[];
+ idempotencyKey?: string;
}) {
const programEnrollments = await prisma.programEnrollment.findMany({
where: {
@@ -134,6 +136,9 @@ export async function triggerDraftBountySubmissionCreation({
bountyId,
partnerIds,
},
+ ...(idempotencyKey && {
+ deduplicationId: `${idempotencyKey}-${bountyId}`,
+ }),
}),
),
);
diff --git a/apps/web/lib/jobs/handlers/process-partner-group-change-job.ts b/apps/web/lib/jobs/handlers/process-partner-group-change-job.ts
index 6c9266cb6d..b1919abc12 100644
--- a/apps/web/lib/jobs/handlers/process-partner-group-change-job.ts
+++ b/apps/web/lib/jobs/handlers/process-partner-group-change-job.ts
@@ -17,6 +17,7 @@ const inputSchema = z.object({
groupId: z.string(),
movedPartnerIds: z.array(z.string()).min(1),
userId: z.string().nullable(),
+ idempotencyKey: z.string(),
});
// Side effects after partners are moved to a group: search sync, remap default
@@ -24,7 +25,13 @@ const inputSchema = z.object({
export const processPartnerGroupChangeJob = defineJob({
name: "process-partner-group-change-job",
schema: inputSchema,
- async handle({ programId, groupId, movedPartnerIds, userId }) {
+ async handle({
+ programId,
+ groupId,
+ movedPartnerIds,
+ userId,
+ idempotencyKey,
+ }) {
const [partnerLinks, programEnrollments] = await Promise.all([
prisma.link.findMany({
where: {
@@ -87,11 +94,13 @@ export const processPartnerGroupChangeJob = defineJob({
partnerIds: pluck(activeProgramEnrollments, "partnerId"),
userId: workspaceUserId,
},
+ deduplicationId: idempotencyKey,
}),
triggerDraftBountySubmissionCreation({
programId,
partnerIds: movedPartnerIds,
+ idempotencyKey,
}),
recordLink(partnerLinks),
@@ -101,6 +110,7 @@ export const processPartnerGroupChangeJob = defineJob({
programId,
groupId,
partnerIds: movedPartnerIds,
+ idempotencyKey,
});
},
});