Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

code improvements

Pedro Ladeirab3ab10c9e9a9
diff --git a/apps/web/app/(ee)/app.dub.co/embed/referrals/get-referrals-embed-data.ts b/apps/web/app/(ee)/app.dub.co/embed/referrals/get-referrals-embed-data.ts
index 9048a0858b..3193c2eb0a 100644
--- a/apps/web/app/(ee)/app.dub.co/embed/referrals/get-referrals-embed-data.ts
+++ b/apps/web/app/(ee)/app.dub.co/embed/referrals/get-referrals-embed-data.ts
@@ -66,11 +66,7 @@ export const getReferralsEmbedData = async (token: string) => {
},
},
links: true,
- partnerGroup: {
- include: {
- referralReward: true,
- },
- },
+ partnerGroup: true,
clickReward: true,
leadReward: true,
saleReward: true,
@@ -95,8 +91,6 @@ export const getReferralsEmbedData = async (token: string) => {
partnerGroup: group,
} = programEnrollment;
- const effectiveReferralReward = referralReward ?? group.referralReward;
-
const { totalClicks, totalLeads, totalSales, totalSaleAmount } =
aggregatePartnerLinksStats(links);
@@ -136,7 +130,7 @@ export const getReferralsEmbedData = async (token: string) => {
},
partnerPlatforms: partner.platforms,
links: z.array(ReferralsEmbedLinkSchema).parse(links),
- rewards: [clickReward, leadReward, saleReward, effectiveReferralReward]
+ rewards: [clickReward, leadReward, saleReward, referralReward]
.filter((r): r is Reward => r !== null)
.map((r) => serializeReward(r)),
discount,
diff --git a/apps/web/app/(ee)/app.dub.co/embed/referrals/page-client.tsx b/apps/web/app/(ee)/app.dub.co/embed/referrals/page-client.tsx
index 01efad645c..9519d3f1bd 100644
--- a/apps/web/app/(ee)/app.dub.co/embed/referrals/page-client.tsx
+++ b/apps/web/app/(ee)/app.dub.co/embed/referrals/page-client.tsx
@@ -222,6 +222,9 @@ export function ReferralsEmbedPageClient({
[rewards],
);
+ const showPartnerReferralSection =
+ referralRewards.length > 0 && Boolean(partner.username);
+
const tabs = useMemo(
() => [
...(showQuickstart ? ["Quickstart"] : []),
@@ -309,7 +312,7 @@ export function ReferralsEmbedPageClient({
<ReferralLinkDisplay
termsHref={termsHref}
onSelectTab={setSelectedTab}
- hasPartnerReferralReward={referralRewards.length > 0}
+ hasPartnerReferralReward={showPartnerReferralSection}
/>
<div className="sm:max-w-[50%]">
@@ -333,7 +336,7 @@ export function ReferralsEmbedPageClient({
</div>
</div>
- {referralRewards.length > 0 && (
+ {showPartnerReferralSection && (
<PartnerReferralLinkDisplay referralRewards={referralRewards} />
)}