Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

code improvements

Pedro Ladeirab5d252f7ccd6
diff --git a/apps/web/lib/integrations/stripe/ui/settings.tsx b/apps/web/lib/integrations/stripe/ui/settings.tsx
index dce9710d06..f60aef34f3 100644
--- a/apps/web/lib/integrations/stripe/ui/settings.tsx
+++ b/apps/web/lib/integrations/stripe/ui/settings.tsx
@@ -1,5 +1,6 @@
"use client";
+import { clientAccessCheck } from "@/lib/client-access-check";
import useWorkspace from "@/lib/swr/use-workspace";
import { InstalledIntegrationInfoProps } from "@/lib/types";
import { MarkdownDescription } from "@/ui/shared/markdown-description";
@@ -22,7 +23,11 @@ export const StripeIntegrationSettings = ({
installed,
settings,
}: InstalledIntegrationInfoProps) => {
- const { id: workspaceId } = useWorkspace();
+ const { id: workspaceId, role } = useWorkspace();
+ const { error: permissionsError } = clientAccessCheck({
+ action: "integrations.write",
+ role,
+ });
const stripeSettings = stripeIntegrationSettingsSchema.parse({
...STRIPE_DEFAULT_SETTINGS,
@@ -188,7 +193,10 @@ export const StripeIntegrationSettings = ({
text="Save changes"
className="h-8 w-fit"
loading={isPending}
- disabled={!isDirty || isPending}
+ disabled={!isDirty || isPending || Boolean(permissionsError)}
+ {...(permissionsError && {
+ disabledTooltip: permissionsError,
+ })}
/>
</div>
</div>
diff --git a/apps/web/lib/integrations/stripe/update-stripe-settings.ts b/apps/web/lib/integrations/stripe/update-stripe-settings.ts
index 6f3bdce962..23a977c752 100644
--- a/apps/web/lib/integrations/stripe/update-stripe-settings.ts
+++ b/apps/web/lib/integrations/stripe/update-stripe-settings.ts
@@ -1,14 +1,21 @@
"use server";
import { authActionClient } from "@/lib/actions/safe-action";
+import { throwIfNoPermission } from "@/lib/actions/throw-if-no-permission";
import { prisma } from "@/lib/prisma";
import { STRIPE_INTEGRATION_ID } from "@dub/utils";
import { revalidatePath } from "next/cache";
import * as z from "zod/v4";
import { stripeIntegrationSettingsSchema } from "./schema";
-const schema = stripeIntegrationSettingsSchema.extend({
+const schema = z.object({
workspaceId: z.string(),
+ freeTrials: stripeIntegrationSettingsSchema.shape.freeTrials,
+ discountCodeRestrictions: z
+ .object({
+ firstTimeTransaction: z.boolean(),
+ })
+ .optional(),
});
export const updateStripeSettingsAction = authActionClient
@@ -17,6 +24,11 @@ export const updateStripeSettingsAction = authActionClient
const { workspace } = ctx;
const { freeTrials, discountCodeRestrictions } = parsedInput;
+ throwIfNoPermission({
+ role: workspace.role,
+ requiredPermissions: ["integrations.write"],
+ });
+
const installedIntegration = await prisma.installedIntegration.findFirst({
where: {
integrationId: STRIPE_INTEGRATION_ID,
@@ -38,7 +50,9 @@ export const updateStripeSettingsAction = authActionClient
settings: {
...current,
freeTrials,
- discountCodeRestrictions,
+ ...(discountCodeRestrictions !== undefined
+ ? { discountCodeRestrictions }
+ : {}),
},
},
});