Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Limit the program owners commission notifications for the first sale only (#3251)

Kiran Kb78876dee308
diff --git a/apps/web/lib/api/partners/notify-partner-commission.ts b/apps/web/lib/api/partners/notify-partner-commission.ts
index 961647035e..dcf54e0abc 100644
--- a/apps/web/lib/api/partners/notify-partner-commission.ts
+++ b/apps/web/lib/api/partners/notify-partner-commission.ts
@@ -6,7 +6,13 @@ import {
import NewCommissionAlertPartner from "@dub/email/templates/new-commission-alert-partner";
import NewSaleAlertProgramOwner from "@dub/email/templates/new-sale-alert-program-owner";
import { prisma } from "@dub/prisma";
-import { Commission, PartnerGroup, Program, Project } from "@dub/prisma/client";
+import {
+ Commission,
+ PartnerGroup,
+ Program,
+ Project,
+ User,
+} from "@dub/prisma/client";
import { chunk } from "@dub/utils";
// Send email to partner and program owners when a commission is created
@@ -15,6 +21,7 @@ export async function notifyPartnerCommission({
group,
workspace,
commission,
+ isFirstCommission,
}: {
program: Pick<Program, "name" | "slug" | "logo" | "supportEmail">;
group: Pick<PartnerGroup, "holdingPeriodDays">;
@@ -23,8 +30,14 @@ export async function notifyPartnerCommission({
Commission,
"type" | "amount" | "earnings" | "partnerId" | "linkId"
>;
+ isFirstCommission: boolean;
}) {
- let [partner, workspaceUsers, partnerLink] = await Promise.all([
+ // Workspace owner emails are sent:
+ // - only for sale commissions
+ // - only for the first commission per partner–customer combination
+ const shouldNotifyProgram = commission.type === "sale" && isFirstCommission;
+
+ const [partner, workspaceUsers, partnerLink] = await Promise.all([
prisma.partner.findUnique({
where: {
id: commission.partnerId,
@@ -48,27 +61,31 @@ export async function notifyPartnerCommission({
},
},
}),
- prisma.projectUsers.findMany({
- where: {
- projectId: workspace.id,
- notificationPreference: {
- newPartnerSale: true,
- },
- user: {
- email: {
- not: null,
+
+ shouldNotifyProgram
+ ? prisma.projectUsers.findMany({
+ where: {
+ projectId: workspace.id,
+ notificationPreference: {
+ newPartnerSale: true,
+ },
+ user: {
+ email: {
+ not: null,
+ },
+ },
},
- },
- },
- include: {
- user: {
- select: {
- name: true,
- email: true,
+ include: {
+ user: {
+ select: {
+ name: true,
+ email: true,
+ },
+ },
},
- },
- },
- }),
+ })
+ : Promise.resolve([] as { user: Pick<User, "name" | "email"> }[]),
+
commission.linkId
? Promise.resolve(
prisma.link.findUnique({
@@ -129,8 +146,8 @@ export async function notifyPartnerCommission({
}),
}) as ResendEmailOptions,
),
- // Workspace owner emails (only for sale commissions)
- ...(commission.type === "sale"
+
+ ...(shouldNotifyProgram
? workspaceUsers.map(
({ user }) =>
({
diff --git a/apps/web/lib/partners/create-partner-commission.ts b/apps/web/lib/partners/create-partner-commission.ts
index bc41098f93..74b5ee3a06 100644
--- a/apps/web/lib/partners/create-partner-commission.ts
+++ b/apps/web/lib/partners/create-partner-commission.ts
@@ -1,5 +1,6 @@
import { prisma } from "@dub/prisma";
import {
+ Commission,
CommissionStatus,
CommissionType,
EventType,
@@ -91,6 +92,11 @@ export const createPartnerCommission = async ({
},
});
+ let firstCommission: Pick<
+ Commission,
+ "rewardId" | "status" | "createdAt"
+ > | null = null;
+
if (event === "custom") {
earnings = amount;
amount = 0;
@@ -122,7 +128,7 @@ export const createPartnerCommission = async ({
// 1. if the partner has reached the max duration for the reward (if applicable)
// 2. if the previous commission were marked as fraud or canceled
} else {
- const firstCommission = await prisma.commission.findFirst({
+ firstCommission = await prisma.commission.findFirst({
where: {
partnerId,
customerId,
@@ -316,7 +322,6 @@ export const createPartnerCommission = async ({
});
const { workspace } = program;
-
const isClawback = earnings < 0;
const shouldTriggerWorkflow = !isClawback && !skipWorkflow;
@@ -342,6 +347,7 @@ export const createPartnerCommission = async ({
group: programEnrollment.partnerGroup ?? program.groups[0],
workspace,
commission,
+ isFirstCommission: firstCommission === null,
}),
// We only capture audit logs for manual commissions