Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Add per-customer label to sale spend limits and fix currency display (#4063)

Kiran Kbc7c27ae42ff
diff --git a/apps/web/ui/partners/format-reward-description.ts b/apps/web/ui/partners/format-reward-description.ts
index eb7938066c..603f108786 100644
--- a/apps/web/ui/partners/format-reward-description.ts
+++ b/apps/web/ui/partners/format-reward-description.ts
@@ -55,7 +55,7 @@ export function formatRewardDescription(
let description = parts.join(" ");
if (spendLimitParts && reward.spendLimitInterval) {
- description += `, with a ${spendLimitParts.amount} ${formatSpendLimitIntervalLabel(reward.spendLimitInterval)} limit`;
+ description += `, with a ${spendLimitParts.amount} ${formatSpendLimitIntervalLabel(reward.spendLimitInterval)} limit ${reward.event === "sale" ? "per customer" : ""}`;
}
return description;
diff --git a/apps/web/ui/partners/program-reward-description.tsx b/apps/web/ui/partners/program-reward-description.tsx
index 9b1a36d630..d81c1536c4 100644
--- a/apps/web/ui/partners/program-reward-description.tsx
+++ b/apps/web/ui/partners/program-reward-description.tsx
@@ -84,6 +84,7 @@ export function ProgramRewardDescription({
))}
<ProgramRewardSpendLimit
+ event={reward.event}
spendLimitAmount={reward.spendLimitAmount}
spendLimitInterval={reward.spendLimitInterval}
/>
diff --git a/apps/web/ui/partners/program-reward-spend-limit.tsx b/apps/web/ui/partners/program-reward-spend-limit.tsx
index cafd349d30..0b913f0cf3 100644
--- a/apps/web/ui/partners/program-reward-spend-limit.tsx
+++ b/apps/web/ui/partners/program-reward-spend-limit.tsx
@@ -1,6 +1,6 @@
import { RewardProps } from "@/lib/types";
import { currencyFormatter } from "@dub/utils";
-import { RewardSpendLimitInterval } from "@prisma/client";
+import { EventType, RewardSpendLimitInterval } from "@prisma/client";
export function getSpendLimitDescriptionParts({
spendLimitAmount,
@@ -22,9 +22,11 @@ export function getSpendLimitDescriptionParts({
}
export function ProgramRewardSpendLimit({
+ event,
spendLimitAmount,
spendLimitInterval,
}: {
+ event: EventType;
spendLimitAmount?: number | null;
spendLimitInterval?: RewardSpendLimitInterval | null;
}) {
@@ -37,7 +39,7 @@ export function ProgramRewardSpendLimit({
return null;
}
- return ` up to ${parts.amount} ${parts.interval}`;
+ return ` up to ${parts.amount} ${parts.interval} ${event === "sale" ? "per customer" : ""}`;
}
export function buildCommissionDescription({
diff --git a/apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx b/apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx
index c7d99b85e0..9b57c4bde1 100644
--- a/apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx
+++ b/apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx
@@ -37,7 +37,7 @@ import {
useLocalStorage,
useRouterStuff,
} from "@dub/ui";
-import { capitalize, cn, pluralize } from "@dub/utils";
+import { capitalize, cn, currencyFormatter, pluralize } from "@dub/utils";
import { EventType, RewardStructure } from "@prisma/client";
import { motion } from "motion/react";
import { useAction } from "next-safe-action/hooks";
@@ -572,7 +572,13 @@ function RewardSheetContent({
text={
spendLimitAmount != null &&
!isNaN(spendLimitAmount)
- ? `$${spendLimitAmount}`
+ ? currencyFormatter(
+ spendLimitAmount * 100,
+ {
+ trailingZeroDisplay:
+ "stripIfInteger",
+ },
+ )
: "amount"
}
invalid={