Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Exports skip the search field

Rafibd3f5e2fc0ce
diff --git a/apps/web/lib/zod/schemas/partners.ts b/apps/web/lib/zod/schemas/partners.ts
index 6f3aaa7ba2..2f0bc14398 100644
--- a/apps/web/lib/zod/schemas/partners.ts
+++ b/apps/web/lib/zod/schemas/partners.ts
@@ -322,8 +322,9 @@ export const getPartnersRouteQuerySchema = getPartnersQuerySchemaExtended
);
export const partnersExportQuerySchema = getPartnersQuerySchemaExtended
- .omit({ page: true, pageSize: true })
+ .omit({ page: true, pageSize: true, search: true })
.extend({
+ sortBy: getPartnersQuerySchema.shape.sortBy,
columns: z
.string()
.default(exportPartnersColumnsDefault.join(","))
diff --git a/apps/web/tests/partners/get-partners-route-query.test.ts b/apps/web/tests/partners/get-partners-route-query.test.ts
index d503b859ba..a59f71f129 100644
--- a/apps/web/tests/partners/get-partners-route-query.test.ts
+++ b/apps/web/tests/partners/get-partners-route-query.test.ts
@@ -1,4 +1,7 @@
-import { getPartnersRouteQuerySchema } from "@/lib/zod/schemas/partners";
+import {
+ getPartnersRouteQuerySchema,
+ partnersExportQuerySchema,
+} from "@/lib/zod/schemas/partners";
import { describe, expect, it } from "vitest";
const accepts = (params: Record<string, unknown>) =>
@@ -64,3 +67,25 @@ describe("getPartnersRouteQuerySchema", () => {
);
});
});
+
+describe("partnersExportQuerySchema", () => {
+ // Exports do not apply the search field: its provider results are capped at
+ // the candidate ceiling, so exporting them would silently truncate the file.
+ it("strips the search field", () => {
+ const result = partnersExportQuerySchema.safeParse({
+ sortBy: "totalSaleAmount",
+ search: "examp",
+ });
+
+ expect(result.success).toBe(true);
+ expect(result.data).not.toHaveProperty("search");
+ });
+
+ it("rejects relevance, which cannot exist without a search", () => {
+ expect(
+ partnersExportQuerySchema.safeParse({
+ sortBy: "relevance",
+ }).success,
+ ).toBe(false);
+ });
+});
diff --git a/apps/web/ui/modals/export-partners-modal.tsx b/apps/web/ui/modals/export-partners-modal.tsx
index 1e4cd2271c..96b9620082 100644
--- a/apps/web/ui/modals/export-partners-modal.tsx
+++ b/apps/web/ui/modals/export-partners-modal.tsx
@@ -8,7 +8,6 @@ import {
import {
Button,
Checkbox,
- InfoTooltip,
Modal,
Switch,
useRouterStuff,
@@ -72,7 +71,7 @@ function ExportPartnersModal({
};
const searchParams = data.useFilters
- ? getQueryString(params)
+ ? getQueryString(params, { exclude: ["search"] })
: "?" + new URLSearchParams(params);
const response = await fetch(`/api/partners/export${searchParams}`, {
@@ -167,11 +166,16 @@ function ExportPartnersModal({
name="useFilters"
control={control}
render={({ field }) => (
- <div className="flex items-center justify-between gap-2">
- <span className="flex select-none items-center gap-2 text-sm font-medium text-neutral-600 group-hover:text-neutral-800">
- Apply current filters
- <InfoTooltip content="Filter exported partners by your currently selected filters" />
- </span>
+ <div className="flex items-start justify-between gap-2">
+ <div className="flex select-none flex-col gap-1">
+ <span className="text-sm font-medium text-neutral-600 group-hover:text-neutral-800">
+ Apply current filters
+ </span>
+ <span className="text-xs text-neutral-500">
+ Filter exported partners by your currently selected
+ filters. The search field is not included.
+ </span>
+ </div>
<Switch checked={field.value} fn={field.onChange} />
</div>
)}