Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

fix gtm-client-sdk

Steven Teybe48ee1d8087
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/analytics/use-dynamic-guide.ts b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/analytics/use-dynamic-guide.ts
index 4eafce4c68..4ea15a1719 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/analytics/use-dynamic-guide.ts
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/analytics/use-dynamic-guide.ts
@@ -117,7 +117,7 @@ export function useDynamicGuide(
)
// for GTM installations - add data-publishable-key after script.src
.replaceAll(
- /^(\s+)(script\.src\s*=\s*"https:\/\/www\.dubcdn\.com\/analytics\/script[^"]+";)$/gm,
+ /^(\s+)(s\.src\s*=\s*"https:\/\/www\.dubcdn\.com\/analytics\/script[^"]+";)$/gm,
(match, indent, srcLine) => {
const idx = originalResult.indexOf(match);
if (idx >= 0) {
@@ -134,12 +134,12 @@ export function useDynamicGuide(
const parts = [
...(publishableKey
? [
- `script.setAttribute("data-publishable-key", "${publishableKey}");`,
+ `s.setAttribute("data-publishable-key", "${publishableKey}");`,
]
: []),
...(domainsConfigParts
? [
- `script.dataset.domains = JSON.stringify({${domainsConfigParts}});`,
+ `s.dataset.domains = JSON.stringify({${domainsConfigParts}});`,
]
: []),
].join(`\n${indent}`);
diff --git a/apps/web/guides/gtm-client-sdk.md b/apps/web/guides/gtm-client-sdk.md
index 4607b011f8..7152f7bd21 100644
--- a/apps/web/guides/gtm-client-sdk.md
+++ b/apps/web/guides/gtm-client-sdk.md
@@ -17,15 +17,30 @@ In the Custom HTML section, you’ll need to add the Dub client-side script. Cop
<!-- prettier-ignore -->
```html
<script>
- var script = document.createElement("script");
- script.defer = true;
- script.src = "https://www.dubcdn.com/analytics/script.js";
- document.getElementsByTagName("head")[0].appendChild(script);
+ (function (c, n) {
+ c[n] =
+ c[n] ||
+ function () {
+ (c[n].q = c[n].q || []).push(arguments);
+ };
+ var methods = ["trackClick", "trackLead", "trackSale"];
+ for (var i = 0; i < methods.length; i++) {
+ (function (method) {
+ c[n][method] = function () {
+ var args = Array.prototype.slice.call(arguments);
+ args.unshift(method);
+ c[n].apply(null, args);
+ };
+ })(methods[i]);
+ }
+ var s = document.createElement("script");
+ s.defer = 1;
+ s.src = "https://www.dubcdn.com/analytics/script.js";
+ document.head.appendChild(s);
+ })(window, "dubAnalytics");
</script>
```
-![Dub GTM add script](https://mintlify.s3.us-west-1.amazonaws.com/dub/images/conversions/google-tag-manager/gtm-add-dub-script.png)
-
## Step 3: Configure the Trigger
To ensure the analytics script loads on all pages: