Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Add E2E test for skipping group move on disabled partners

Kiran Kc167b748e60c
diff --git a/apps/web/tests/utils/resource.ts b/apps/web/tests/utils/resource.ts
index 72c670dbad..2492f65373 100644
--- a/apps/web/tests/utils/resource.ts
+++ b/apps/web/tests/utils/resource.ts
@@ -257,3 +257,7 @@ export const E2E_FRAUD_PARTNER = {
export const E2E_FRAUD_REFERRAL_SOURCE_BANNED_DOMAIN =
"test-hostname-for-referral-source-banned-do-not-delete.com";
+
+export const E2E_GROUP_MOVE_DISABLED_PARTNER = {
+ id: "pn_1K2J9DRWPPJ2F1RX53N92TSGG", // TODO: Update this
+} as const;
diff --git a/apps/web/tests/workflows/move-group-workflow.test.ts b/apps/web/tests/workflows/move-group-workflow.test.ts
index 12ee5e1589..f89c315910 100644
--- a/apps/web/tests/workflows/move-group-workflow.test.ts
+++ b/apps/web/tests/workflows/move-group-workflow.test.ts
@@ -2,6 +2,7 @@ import { EnrolledPartnerProps } from "@/lib/types";
import { RESOURCE_COLORS } from "@/ui/colors";
import { PartnerGroup } from "@dub/prisma/client";
import { randomValue } from "@dub/utils";
+import { E2E_GROUP_MOVE_DISABLED_PARTNER } from "tests/utils/resource";
import { describe, expect, onTestFinished, test } from "vitest";
import { randomEmail } from "../utils/helpers";
import { IntegrationHarness } from "../utils/integration";
@@ -488,4 +489,67 @@ describe.sequential("Workflow - MoveGroup", async () => {
expect(workflowConditions[1].attribute).toBe("totalConversions");
expect(workflowConditions[1].value).toStrictEqual({ min: 1, max: 2 });
});
+
+ test("Workflow skips partner with groupMoveDisabledAt set", async () => {
+ const slug = "e2e-target-skip-partner-move";
+
+ // Get the current group of E2E_GROUP_MOVE_DISABLED_PARTNER
+ const { data: partner, status: partnerStatus } =
+ await http.get<EnrolledPartnerProps>({
+ path: `/partners/${E2E_GROUP_MOVE_DISABLED_PARTNER.id}`,
+ });
+
+ expect(partnerStatus).toEqual(200);
+ expect(partner).not.toBeNull();
+
+ const partnerLink = partner.links![0];
+
+ // Create a new group
+ const { data: targetGroup } = await http.post<PartnerGroup>({
+ path: "/groups",
+ body: {
+ name: "E2E Target Group - Skip Partner Move",
+ slug,
+ color: randomValue(RESOURCE_COLORS),
+ },
+ });
+
+ expect(targetGroup).not.toBeNull();
+
+ onTestFinished(async () => {
+ await http.delete({
+ path: `/groups/${targetGroup.id}`,
+ });
+ });
+
+ // Update the group with move rule
+ const { status: patchStatus } = await http.patch({
+ path: `/groups/${targetGroup.id}`,
+ body: {
+ moveRules: [
+ {
+ attribute: "totalLeads",
+ operator: "between",
+ value: { min: 1, max: 2 },
+ },
+ ],
+ },
+ });
+
+ expect(patchStatus).toEqual(200);
+
+ await trackE2ELead(http, partnerLink);
+
+ await verifyPartnerGroupMove({
+ http,
+ partnerId: partner.id,
+ expectedGroupId: partner.groupId!,
+ });
+
+ const { data: partnerAfter } = await http.get<EnrolledPartnerProps>({
+ path: `/partners/${partner.id}`,
+ });
+
+ expect(partnerAfter.groupId).toBe(partner.groupId);
+ });
});