Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Keep merged fraud groups pending when another partner is still listed

Kiran Kc26a0d480b46
diff --git a/apps/web/app/(ee)/api/workflows/merge-partner-accounts/route.ts b/apps/web/app/(ee)/api/workflows/merge-partner-accounts/route.ts
index 9b1829978a..d3e3635587 100644
--- a/apps/web/app/(ee)/api/workflows/merge-partner-accounts/route.ts
+++ b/apps/web/app/(ee)/api/workflows/merge-partner-accounts/route.ts
@@ -989,6 +989,11 @@ async function cleanupFraudEvents({
},
select: {
id: true,
+ _count: {
+ select: {
+ fraudEvents: true,
+ },
+ },
},
});
@@ -1009,8 +1014,14 @@ async function cleanupFraudEvents({
// Bucket group ids by the partner whose held commissions should be released.
const groupIdsByPartnerId = new Map<string, string[]>();
- if (sourceFraudGroups.length > 0) {
- groupIdsByPartnerId.set(targetPartnerId, pluck(sourceFraudGroups, "id"));
+ // A source group with another partner still listed stays pending.
+ const sourceGroupIdsToResolve = pluck(
+ sourceFraudGroups.filter((group) => group._count.fraudEvents <= 1),
+ "id",
+ );
+
+ if (sourceGroupIdsToResolve.length > 0) {
+ groupIdsByPartnerId.set(targetPartnerId, sourceGroupIdsToResolve);
}
for (const event of fraudEventGroupsToResolve) {