Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Move orphaned cleanup cron and hard-delete soft-deleted default links

Kiran Kc3be4cfce10c
diff --git a/apps/web/app/(ee)/api/cron/cleanup/orphaned-rewards/route.ts b/apps/web/app/(ee)/api/cron/cleanup/orphaned/route.ts
similarity index 56%
rename from apps/web/app/(ee)/api/cron/cleanup/orphaned-rewards/route.ts
rename to apps/web/app/(ee)/api/cron/cleanup/orphaned/route.ts
index c5c5f077a4..8f866a7ee0 100644
--- a/apps/web/app/(ee)/api/cron/cleanup/orphaned-rewards/route.ts
+++ b/apps/web/app/(ee)/api/cron/cleanup/orphaned/route.ts
@@ -1,3 +1,4 @@
+import { deleteOrphanedDefaultLinks } from "@/lib/api/groups/delete-orphaned-default-links";
import { withCron } from "@/lib/cron/with-cron";
import { deleteOrphanedDiscounts } from "@/lib/discounts/delete-orphaned-discounts";
import { deleteEmptyLinkRewards } from "@/lib/rewards/delete-empty-link-rewards";
@@ -7,7 +8,7 @@ import { logAndRespond } from "../../utils";
export const dynamic = "force-dynamic";
-const STALE_AFTER_MINUTES = 30;
+const STALE_AFTER_MINUTES = 60; // 1 hour
// Hard-deletes leftover rows after request-path soft-deletes / unassigns:
// - Rewards: rewards/process clears enrollments on delete; this cron hard-deletes
@@ -16,29 +17,32 @@ const STALE_AFTER_MINUTES = 30;
// nothing still references the soft-deleted discount (programId null).
// - LinkReward: update-partner-link nulls override IDs instead of deleting the row.
// Discount deletes SetNull LinkReward.discountId the same way.
+// - PartnerGroupDefaultLink: group delete soft-deletes (groupId null) so in-flight
+// remap keeps partnerGroupDefaultLinkId; this cron hard-deletes once no links
+// still reference the row.
-// POST /api/cron/cleanup/orphaned-rewards
+// POST /api/cron/cleanup/orphaned
export const POST = withCron(async () => {
const cutoff = subMinutes(new Date(), STALE_AFTER_MINUTES);
- const [deletedRewardsCount, deletedDiscountsCount, deletedLinkRewardsCount] =
- await Promise.all([
- deleteOrphanedRewards(cutoff),
- deleteOrphanedDiscounts(cutoff),
- deleteEmptyLinkRewards(),
- ]);
+ const [
+ deletedRewardsCount,
+ deletedDiscountsCount,
+ deletedLinkRewardsCount,
+ deletedDefaultLinksCount,
+ ] = await Promise.all([
+ deleteOrphanedRewards(cutoff),
+ deleteOrphanedDiscounts(cutoff),
+ deleteEmptyLinkRewards(),
+ deleteOrphanedDefaultLinks(cutoff),
+ ]);
- if (
- deletedRewardsCount === 0 &&
- deletedDiscountsCount === 0 &&
- deletedLinkRewardsCount === 0
- ) {
- return logAndRespond(
- "No orphaned rewards, discounts, or empty link rewards found.",
- );
- }
+ console.log({
+ deletedRewardsCount,
+ deletedDiscountsCount,
+ deletedLinkRewardsCount,
+ deletedDefaultLinksCount,
+ });
- return logAndRespond(
- `Finished cleanup (${deletedRewardsCount} rewards, ${deletedDiscountsCount} discounts, ${deletedLinkRewardsCount} empty link rewards deleted).`,
- );
+ return logAndRespond("OK");
});
diff --git a/apps/web/app/(ee)/api/workflows/detach-discount/route.ts b/apps/web/app/(ee)/api/workflows/detach-discount/route.ts
index bec459d360..5ee8a29f60 100644
--- a/apps/web/app/(ee)/api/workflows/detach-discount/route.ts
+++ b/apps/web/app/(ee)/api/workflows/detach-discount/route.ts
@@ -24,7 +24,7 @@ type Input = z.infer<typeof inputSchema>;
* 1. detach-discount-from-enrollments + detach-discount-from-link-rewards (parallel)
* 2. remap-discount-codes
*
- * Hard-delete is deferred to /api/cron/cleanup/orphaned-rewards once remaps
+ * Hard-delete is deferred to /api/cron/cleanup/orphaned once remaps
* finish and nothing still references the soft-deleted discount.
*/
diff --git a/apps/web/lib/api/groups/delete-group.ts b/apps/web/lib/api/groups/delete-group.ts
index e9d2324e4d..5405108f36 100644
--- a/apps/web/lib/api/groups/delete-group.ts
+++ b/apps/web/lib/api/groups/delete-group.ts
@@ -51,7 +51,7 @@ export async function deletePartnerGroup(
},
});
- // Soft delete discounts (orphaned-rewards cron hard-deletes after remapping)
+ // Soft delete discounts (orphaned cleanup cron hard-deletes after remapping)
await tx.discount.updateMany({
where: {
groupId: group.id,
diff --git a/apps/web/lib/api/groups/delete-orphaned-default-links.ts b/apps/web/lib/api/groups/delete-orphaned-default-links.ts
new file mode 100644
index 0000000000..d01b7d3813
--- /dev/null
+++ b/apps/web/lib/api/groups/delete-orphaned-default-links.ts
@@ -0,0 +1,41 @@
+import { prisma } from "@/lib/prisma";
+import { pluck } from "@dub/utils";
+
+// Hard-delete soft-deleted PartnerGroupDefaultLink rows (groupId null) once
+// no links still reference them. Group delete soft-deletes first so in-flight
+// remap can keep partnerGroupDefaultLinkId; this cron finishes cleanup after
+// the stale cutoff.
+export async function deleteOrphanedDefaultLinks(cutoff: Date) {
+ const defaultLinks = await prisma.partnerGroupDefaultLink.findMany({
+ where: {
+ groupId: null,
+ updatedAt: {
+ lt: cutoff,
+ },
+ links: {
+ none: {},
+ },
+ },
+ select: {
+ id: true,
+ },
+ orderBy: {
+ updatedAt: "desc",
+ },
+ take: 50,
+ });
+
+ if (defaultLinks.length === 0) {
+ return 0;
+ }
+
+ const { count } = await prisma.partnerGroupDefaultLink.deleteMany({
+ where: {
+ id: {
+ in: pluck(defaultLinks, "id"),
+ },
+ },
+ });
+
+ return count;
+}