Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Add bank account requirements modal to payout flow (#3355)

Marcus Farrellc6412d3c42f7
diff --git a/apps/web/app/(ee)/partners.dub.co/(onboarding)/onboarding/verify/page.tsx b/apps/web/app/(ee)/partners.dub.co/(onboarding)/onboarding/verify/page.tsx
index a6b329c524..ad2b9ba8cb 100644
--- a/apps/web/app/(ee)/partners.dub.co/(onboarding)/onboarding/verify/page.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(onboarding)/onboarding/verify/page.tsx
@@ -50,7 +50,7 @@ function PayoutProvider({ provider }: { provider: "stripe" | "paypal" }) {
</div>
<div className="bg-white px-6 py-4 text-sm text-neutral-600">
We use {label} to ensure you get paid on time and to keep your
- personal bank details secure. Click <strong>Save and continue</strong>{" "}
+ personal bank details secure. Click <strong>Connect payouts</strong>{" "}
to connect your bank account.
<br />
<br />
@@ -68,7 +68,7 @@ function PayoutProvider({ provider }: { provider: "stripe" | "paypal" }) {
</div>
</div>
<div className="mt-10 grid gap-4">
- <ConnectPayoutButton text="Save and continue" />
+ <ConnectPayoutButton text="Connect payouts" />
<Link
href="/programs"
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/integrations/[integrationSlug]/page-client.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/integrations/[integrationSlug]/page-client.tsx
index 25a342025e..065187bd4f 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/integrations/[integrationSlug]/page-client.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/integrations/[integrationSlug]/page-client.tsx
@@ -343,7 +343,9 @@ export default function IntegrationPageClient({
</Carousel>
) : null}
- {integration.readme && <Markdown>{integration.readme}</Markdown>}
+ {integration.readme && (
+ <Markdown className="p-6">{integration.readme}</Markdown>
+ )}
</div>
{SettingsComponent && <SettingsComponent {...integration} />}
diff --git a/apps/web/app/app.dub.co/(onboarding)/onboarding/(steps)/usage/form.tsx b/apps/web/app/app.dub.co/(onboarding)/onboarding/(steps)/usage/form.tsx
index 490ac1888a..b22a18b363 100644
--- a/apps/web/app/app.dub.co/(onboarding)/onboarding/(steps)/usage/form.tsx
+++ b/apps/web/app/app.dub.co/(onboarding)/onboarding/(steps)/usage/form.tsx
@@ -146,7 +146,7 @@ function RadioGroup<T extends string>({
return (
<div>
{label && (
- <Markdown className="prose-a:underline-offset-2 mb-1.5 p-0 text-sm font-medium">
+ <Markdown className="prose-a:underline-offset-2 mb-1.5 text-sm font-medium">
{label}
</Markdown>
)}
diff --git a/apps/web/ui/partners/bank-account-requirements-modal.tsx b/apps/web/ui/partners/bank-account-requirements-modal.tsx
new file mode 100644
index 0000000000..8ec83999c1
--- /dev/null
+++ b/apps/web/ui/partners/bank-account-requirements-modal.tsx
@@ -0,0 +1,118 @@
+"use client";
+
+import usePartnerProfile from "@/lib/swr/use-partner-profile";
+import { Button, Modal } from "@dub/ui";
+import { TriangleWarning } from "@dub/ui/icons";
+import { COUNTRIES, COUNTRY_CURRENCY_CODES } from "@dub/utils";
+import { Dispatch, SetStateAction, useMemo, useState } from "react";
+import { Markdown } from "../shared/markdown";
+
+function BankAccountRequirementsModal({
+ showModal,
+ setShowModal,
+ onContinue,
+}: {
+ showModal: boolean;
+ setShowModal: Dispatch<SetStateAction<boolean>>;
+ onContinue: () => Promise<void>;
+}) {
+ const { partner } = usePartnerProfile();
+
+ const BANK_ACCOUNT_REQUIREMENTS = useMemo(() => {
+ return [
+ `1. Bank account must be in your local currency.${partner?.country ? ` Since you're based in [${COUNTRIES[partner.country]}](/profile), you need to connect a **${COUNTRY_CURRENCY_CODES[partner.country]} bank account** to receive payouts.` : ""}`,
+ "2. Bank account must be a **checking account** (not a savings account or debit card).",
+ "3. Bank account holder name must match your partner account name.",
+ "4. Bank account details are 100% accurate (no typos or missing numbers).",
+ ];
+ }, [partner?.country]);
+
+ const [acknowledged, setAcknowledged] = useState(false);
+
+ const [isLoading, setIsLoading] = useState(false);
+
+ return (
+ <Modal showModal={showModal} setShowModal={setShowModal}>
+ <div className="flex items-center justify-between p-6">
+ <h3 className="text-lg font-semibold text-neutral-900">
+ Bank account requirements
+ </h3>
+ </div>
+
+ <div className="flex flex-col gap-6 border-t border-neutral-200 bg-neutral-50 p-6">
+ <div className="flex flex-col gap-2.5 rounded-lg border border-amber-200 bg-amber-50 p-3">
+ <TriangleWarning className="size-3.5 text-amber-500" />
+ <p className="text-sm leading-5 text-amber-900">
+ If your bank account does not meet these requirements, payouts may
+ be delayed or rejected.
+ </p>
+ </div>
+
+ <div className="flex flex-col gap-2 text-sm text-neutral-800">
+ <p className="font-semibold">Requirements:</p>
+ <Markdown className="list-decimal space-y-1">
+ {BANK_ACCOUNT_REQUIREMENTS.join("\n")}
+ </Markdown>
+
+ <label className="flex cursor-pointer gap-3 rounded-lg border border-neutral-300 p-3">
+ <div className="flex h-5 items-center">
+ <input
+ type="checkbox"
+ checked={acknowledged}
+ onChange={(e) => setAcknowledged(e.target.checked)}
+ className="h-4 w-4 rounded border-neutral-300 text-neutral-900 focus:ring-neutral-900"
+ />
+ </div>
+ <span className="text-sm leading-5 text-neutral-900">
+ I confirm that my bank account meets all of the above
+ requirements.
+ </span>
+ </label>
+ </div>
+
+ <Button
+ text="Continue"
+ onClick={async () => {
+ setIsLoading(true);
+ await onContinue();
+ setIsLoading(false);
+ }}
+ loading={isLoading}
+ disabled={!acknowledged}
+ disabledTooltip={
+ !acknowledged
+ ? "You must acknowledge the requirements before continuing."
+ : undefined
+ }
+ />
+ </div>
+ </Modal>
+ );
+}
+
+export function useBankAccountRequirementsModal({
+ onContinue,
+}: {
+ onContinue: () => Promise<void>;
+}) {
+ const [showModal, setShowModal] = useState(false);
+
+ const BankAccountRequirementsModalElement = useMemo(
+ () => (
+ <BankAccountRequirementsModal
+ showModal={showModal}
+ setShowModal={setShowModal}
+ onContinue={onContinue}
+ />
+ ),
+ [showModal, onContinue],
+ );
+
+ return useMemo(
+ () => ({
+ setShowBankAccountRequirementsModal: setShowModal,
+ BankAccountRequirementsModal: BankAccountRequirementsModalElement,
+ }),
+ [BankAccountRequirementsModalElement],
+ );
+}
diff --git a/apps/web/ui/partners/bounties/claim-bounty-modal.tsx b/apps/web/ui/partners/bounties/claim-bounty-modal.tsx
index fc37a1fa32..c84ccb1dca 100644
--- a/apps/web/ui/partners/bounties/claim-bounty-modal.tsx
+++ b/apps/web/ui/partners/bounties/claim-bounty-modal.tsx
@@ -430,7 +430,7 @@ function ClaimBountyModalContent({ bounty }: ClaimBountyModalProps) {
Details
</span>
<p className="text-content-subtle font-medium">
- <Markdown className={cn("p-0", PROSE_STYLES.default)}>
+ <Markdown className={PROSE_STYLES.default}>
{bounty.description}
</Markdown>
</p>
diff --git a/apps/web/ui/partners/connect-payout-button.tsx b/apps/web/ui/partners/connect-payout-button.tsx
index 9af3f278d3..7dd32af8f0 100644
--- a/apps/web/ui/partners/connect-payout-button.tsx
+++ b/apps/web/ui/partners/connect-payout-button.tsx
@@ -4,6 +4,7 @@ import { generatePaypalOAuthUrl } from "@/lib/actions/partners/generate-paypal-o
import { generateStripeAccountLink } from "@/lib/actions/partners/generate-stripe-account-link";
import { hasPermission } from "@/lib/auth/partner-users/partner-user-permissions";
import usePartnerProfile from "@/lib/swr/use-partner-profile";
+import { useBankAccountRequirementsModal } from "@/ui/partners/bank-account-requirements-modal";
import { Button, ButtonProps, TooltipContent } from "@dub/ui";
import { COUNTRIES } from "@dub/utils";
import { useAction } from "next-safe-action/hooks";
@@ -43,7 +44,7 @@ export function ConnectPayoutButton(props: ButtonProps) {
},
});
- const onClick = useCallback(async () => {
+ const connectPayout = useCallback(async () => {
if (!partner) {
toast.error("Invalid partner profile. Please log out and log back in.");
return;
@@ -68,6 +69,11 @@ export function ConnectPayoutButton(props: ButtonProps) {
}
}, [executeStripeAsync, executePaypalAsync, partner, payoutMethod]);
+ const { setShowBankAccountRequirementsModal, BankAccountRequirementsModal } =
+ useBankAccountRequirementsModal({
+ onContinue: connectPayout,
+ });
+
const errorMessage = useMemo(
() =>
!partner?.country
@@ -83,22 +89,31 @@ export function ConnectPayoutButton(props: ButtonProps) {
}
return (
- <Button
- onClick={onClick}
- loading={isStripePending || isPaypalPending}
- text={
- payoutMethod === "paypal" ? "Connect PayPal" : "Connect bank account"
- }
- disabledTooltip={
- errorMessage && (
- <TooltipContent
- title={errorMessage}
- cta="Update profile settings"
- href="/profile"
- />
- )
- }
- {...props}
- />
+ <>
+ {BankAccountRequirementsModal}
+ <Button
+ onClick={() => {
+ if (payoutMethod === "stripe") {
+ setShowBankAccountRequirementsModal(true);
+ } else {
+ connectPayout();
+ }
+ }}
+ loading={isStripePending || isPaypalPending}
+ text={
+ payoutMethod === "paypal" ? "Connect PayPal" : "Connect bank account"
+ }
+ disabledTooltip={
+ errorMessage && (
+ <TooltipContent
+ title={errorMessage}
+ cta="Update profile settings"
+ href="/profile"
+ />
+ )
+ }
+ {...props}
+ />
+ </>
);
}
diff --git a/apps/web/ui/shared/markdown.tsx b/apps/web/ui/shared/markdown.tsx
index f429ccbc9e..e671ceb315 100644
--- a/apps/web/ui/shared/markdown.tsx
+++ b/apps/web/ui/shared/markdown.tsx
@@ -16,9 +16,9 @@ export function Markdown({
return (
<ReactMarkdown
className={cn(
- "prose prose-sm prose-gray max-w-none p-6 transition-all",
+ "prose prose-sm prose-neutral max-w-none transition-all",
"prose-headings:leading-tight",
- "prose-a:font-medium prose-a:text-neutral-500 prose-a:underline-offset-4 hover:prose-a:text-black",
+ "prose-a:font-medium prose-a:text-neutral-900 prose-a:underline-offset-2 prose-a:decoration-dotted prose-a:cursor-alias",
className,
)}
components={{