Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Fix partners with payoutsEnabledAt set but defaultPayoutMethod null (#3973)

Pedro Ladeiracda421d79b61
diff --git a/apps/web/app/(ee)/api/admin/partners/delete-account/route.ts b/apps/web/app/(ee)/api/admin/partners/delete-account/route.ts
index 15e35c43de..008efe25c1 100644
--- a/apps/web/app/(ee)/api/admin/partners/delete-account/route.ts
+++ b/apps/web/app/(ee)/api/admin/partners/delete-account/route.ts
@@ -77,6 +77,7 @@ export const POST = withAdmin(
stripeConnectId: null,
payoutsEnabledAt: null,
payoutMethodHash: null,
+ defaultPayoutMethod: null,
},
});
console.log(`Updated partner ${partner.email} with stripeConnectId null`);
diff --git a/apps/web/app/(ee)/api/stripe/connect/webhook/account-updated.ts b/apps/web/app/(ee)/api/stripe/connect/webhook/account-updated.ts
index 8048d9659a..9027878437 100644
--- a/apps/web/app/(ee)/api/stripe/connect/webhook/account-updated.ts
+++ b/apps/web/app/(ee)/api/stripe/connect/webhook/account-updated.ts
@@ -46,13 +46,9 @@ export async function accountUpdated(event: Stripe.AccountUpdatedEvent) {
return `Partner with stripeConnectId ${account.id} not found, skipping...`;
}
- const { payoutsEnabledAt, defaultPayoutMethod } =
+ const { payoutsEnabledAt, defaultPayoutMethod, hasPayoutStateChanged } =
await recomputePartnerPayoutState(partner);
- const payoutStateChanged =
- partner.payoutsEnabledAt !== payoutsEnabledAt ||
- partner.defaultPayoutMethod !== defaultPayoutMethod;
-
const nextProfileType: PartnerProfileType | undefined =
business_type === "individual"
? "individual"
@@ -103,14 +99,14 @@ export async function accountUpdated(event: Stripe.AccountUpdatedEvent) {
...(partnerChangeHistoryLog.length > 0 && {
changeHistoryLog: partnerChangeHistoryLog,
}),
- ...(payoutStateChanged && {
+ ...(hasPayoutStateChanged && {
payoutsEnabledAt,
defaultPayoutMethod,
}),
},
});
- if (!payoutStateChanged) {
+ if (!hasPayoutStateChanged) {
return `No change in payout state for partner ${partner.email} (${partner.stripeConnectId}), skipping...`;
}
@@ -130,9 +126,6 @@ export async function accountUpdated(event: Stripe.AccountUpdatedEvent) {
stripeConnectId: account.id,
},
data: {
- payoutsEnabledAt: partner.payoutsEnabledAt
- ? undefined // Don't update if already set
- : new Date(),
payoutMethodHash: bankAccount.fingerprint,
},
});
diff --git a/apps/web/lib/partners/create-stablecoin-payout.ts b/apps/web/lib/partners/create-stablecoin-payout.ts
index c8d1c2bcd7..abcbaa052e 100644
--- a/apps/web/lib/partners/create-stablecoin-payout.ts
+++ b/apps/web/lib/partners/create-stablecoin-payout.ts
@@ -173,6 +173,7 @@ export const createStablecoinPayout = async ({
data: {
stripeRecipientId: null,
payoutsEnabledAt: null,
+ defaultPayoutMethod: null,
},
});
diff --git a/apps/web/lib/partners/create-stripe-transfer.ts b/apps/web/lib/partners/create-stripe-transfer.ts
index 7b94f621db..4cdd94ce6e 100644
--- a/apps/web/lib/partners/create-stripe-transfer.ts
+++ b/apps/web/lib/partners/create-stripe-transfer.ts
@@ -154,8 +154,10 @@ export const createStripeTransfer = async ({
},
data: {
payoutsEnabledAt: null,
+ defaultPayoutMethod: null,
},
});
+
console.log(`Updated partner ${partner.email} with payoutsEnabledAt null`);
await markPayoutsAsProcessed(currentInvoicePayouts);
diff --git a/apps/web/lib/payouts/recompute-partner-payout-state.ts b/apps/web/lib/payouts/recompute-partner-payout-state.ts
index 87c3fe3b4b..72d3a77644 100644
--- a/apps/web/lib/payouts/recompute-partner-payout-state.ts
+++ b/apps/web/lib/payouts/recompute-partner-payout-state.ts
@@ -74,22 +74,26 @@ export async function recomputePartnerPayoutState(
}
});
- const defaultPayoutMethod =
+ const hasValidDefaultPayoutMethod =
partner.defaultPayoutMethod &&
- activePayoutMethods.includes(partner.defaultPayoutMethod)
- ? partner.defaultPayoutMethod
- : activePayoutMethods[0] ?? null;
+ activePayoutMethods.includes(partner.defaultPayoutMethod);
+
+ const defaultPayoutMethod = hasValidDefaultPayoutMethod
+ ? partner.defaultPayoutMethod
+ : activePayoutMethods[0] ?? null;
+
let payoutsEnabledAt: Date | null = null;
if (defaultPayoutMethod) {
// if default payout method has changed, set payoutsEnabledAt to today
// otherwise, use the existing payoutsEnabledAt (or today if null)
- payoutsEnabledAt =
- defaultPayoutMethod !== partner.defaultPayoutMethod
- ? new Date()
- : partner.payoutsEnabledAt ?? new Date();
- } else {
- payoutsEnabledAt = null;
+ if (defaultPayoutMethod !== partner.defaultPayoutMethod) {
+ payoutsEnabledAt = new Date();
+ } else if (partner.payoutsEnabledAt) {
+ payoutsEnabledAt = partner.payoutsEnabledAt;
+ } else {
+ payoutsEnabledAt = new Date();
+ }
}
console.log(
@@ -109,6 +113,10 @@ export async function recomputePartnerPayoutState(
: cryptoWalletAddress
: null;
+ const hasPayoutStateChanged =
+ partner.payoutsEnabledAt !== payoutsEnabledAt ||
+ partner.defaultPayoutMethod !== defaultPayoutMethod;
+
return {
payoutsEnabledAt,
defaultPayoutMethod,
@@ -116,5 +124,6 @@ export async function recomputePartnerPayoutState(
cryptoWalletAddress,
cryptoWalletNetwork,
maskedCryptoWalletAddress,
+ hasPayoutStateChanged,
};
}
diff --git a/apps/web/scripts/migrations/backfill-default-payout-method.ts b/apps/web/scripts/migrations/backfill-default-payout-method.ts
new file mode 100644
index 0000000000..72398a90b6
--- /dev/null
+++ b/apps/web/scripts/migrations/backfill-default-payout-method.ts
@@ -0,0 +1,92 @@
+import { prisma } from "@dub/prisma";
+import "dotenv-flow/config";
+
+// Reconciles partners that ended up with payoutsEnabledAt set while defaultPayoutMethod is null.
+async function main() {
+ await scriptOne();
+ await scriptTwo();
+}
+
+// Backfills `defaultPayoutMethod` to "connect" for partners who have payouts enabled
+// via a Stripe Connect account but are missing a default payout method.
+async function scriptOne() {
+ const partners = await prisma.partner.findMany({
+ where: {
+ payoutsEnabledAt: {
+ not: null,
+ },
+ stripeConnectId: {
+ not: null,
+ },
+ defaultPayoutMethod: null,
+ paypalEmail: null,
+ stripeRecipientId: null,
+ },
+ select: {
+ id: true,
+ stripeConnectId: true,
+ stripeRecipientId: true,
+ paypalEmail: true,
+ payoutsEnabledAt: true,
+ defaultPayoutMethod: true,
+ },
+ orderBy: {
+ id: "asc",
+ },
+ });
+
+ console.table(partners);
+
+ if (partners.length === 0) {
+ console.log("No partners found");
+ return;
+ }
+
+ const { count } = await prisma.partner.updateMany({
+ where: {
+ id: {
+ in: partners.map((partner) => partner.id),
+ },
+ },
+ data: {
+ defaultPayoutMethod: "connect",
+ },
+ });
+
+ console.log(`Updated ${count} partners`);
+}
+
+// Clears `defaultPayoutMethod` for partners who no longer have payouts enabled,
+// processing in batches of 500 to avoid long-running queries.
+async function scriptTwo() {
+ while (true) {
+ const partners = await prisma.partner.findMany({
+ where: {
+ payoutsEnabledAt: null,
+ defaultPayoutMethod: {
+ not: null,
+ },
+ },
+ take: 500,
+ });
+
+ if (partners.length === 0) {
+ break;
+ }
+
+ const { count } = await prisma.partner.updateMany({
+ where: {
+ id: {
+ in: partners.map((partner) => partner.id),
+ },
+ },
+ data: {
+ defaultPayoutMethod: null,
+ },
+ });
+
+ console.log(`Updated ${count} partners`);
+ }
+}
+
+main();