Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Improve partner search filtering and reset behavior

Rafice40e68e56d8
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/partners-table.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/partners-table.tsx
index f615aab7fd..ea66d9aa25 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/partners-table.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/partners-table.tsx
@@ -117,6 +117,8 @@ const partnersColumns = {
],
};
+const PARTNER_SEARCH_RESET_PARAMS = ["sortBy", "sortOrder"];
+
const getPartnerUrl = ({
workspaceSlug,
id,
@@ -159,6 +161,7 @@ export function PartnersTable() {
data: partners,
error,
isLoading,
+ isValidating,
} = useSWR<EnrolledPartnerProps[]>(
`/api/partners${getQueryString({
workspaceId,
@@ -508,7 +511,12 @@ export function PartnersTable() {
return (
<div className="flex flex-col gap-4">
- <PartnersFilters sortBy={sortBy} sortOrder={sortOrder} status={status} />
+ <PartnersFilters
+ sortBy={sortBy}
+ sortOrder={sortOrder}
+ status={status}
+ searchLoading={isValidating}
+ />
{partners?.length !== 0 ? (
<Table {...tableProps} table={table} />
) : (
@@ -535,10 +543,12 @@ function PartnersFilters({
sortBy,
sortOrder,
status,
+ searchLoading,
}: {
sortBy: string;
sortOrder: "asc" | "desc";
status: ProgramEnrollmentStatus | undefined;
+ searchLoading: boolean;
}) {
const { queryParams, searchParams } = useRouterStuff();
@@ -601,8 +611,10 @@ function PartnersFilters({
) : null}
</div>
<SearchBoxPersisted
- placeholder="Search by name, email, or company"
+ placeholder="Search name, email, company, platform, or link"
inputClassName="md:w-80"
+ loading={searchLoading}
+ resetParamsOnChange={PARTNER_SEARCH_RESET_PARAMS}
/>
</div>
<AnimatedSizeContainer height>
diff --git a/apps/web/ui/shared/search-box.tsx b/apps/web/ui/shared/search-box.tsx
index 505a125756..6e4f865e15 100644
--- a/apps/web/ui/shared/search-box.tsx
+++ b/apps/web/ui/shared/search-box.tsx
@@ -96,6 +96,7 @@ export const SearchBox = forwardRef(
{showClearButton && value.length > 0 && (
<button
onClick={() => {
+ debounced.cancel();
onChange("");
onChangeDebounced?.("");
}}
@@ -111,10 +112,14 @@ export const SearchBox = forwardRef(
export function SearchBoxPersisted({
urlParam = "search",
+ resetParamsOnChange = [],
onChange,
onChangeDebounced,
...props
-}: { urlParam?: string } & Partial<SearchBoxProps>) {
+}: {
+ urlParam?: string;
+ resetParamsOnChange?: string[];
+} & Partial<SearchBoxProps>) {
const { queryParams, searchParams } = useRouterStuff();
const [value, setValue] = useState(searchParams.get(urlParam) ?? "");
@@ -122,11 +127,14 @@ export function SearchBoxPersisted({
// Set URL param when debounced value changes
useEffect(() => {
- if (searchParams.get(urlParam) ?? "" !== debouncedValue)
+ if ((searchParams.get(urlParam) ?? "") !== debouncedValue)
queryParams(
debouncedValue === ""
- ? { del: [urlParam, "page"] }
- : { set: { [urlParam]: debouncedValue }, del: "page" },
+ ? { del: [urlParam, "page", ...resetParamsOnChange] }
+ : {
+ set: { [urlParam]: debouncedValue },
+ del: ["page", ...resetParamsOnChange],
+ },
);
}, [debouncedValue]);
@@ -134,7 +142,7 @@ export function SearchBoxPersisted({
useEffect(() => {
const search = searchParams.get(urlParam);
// Only update if the value and debouncedValue are synced (the user isn't actively typing)
- if ((search ?? "" !== value) && value === debouncedValue)
+ if ((search ?? "") !== value && value === debouncedValue)
setValue(search ?? "");
}, [searchParams.get(urlParam)]);