Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Hold pending commissions for fraud-affected partner enrollments

Kiran Kcf887f1a488d
diff --git a/apps/web/lib/api/fraud/create-fraud-events.ts b/apps/web/lib/api/fraud/create-fraud-events.ts
index 78b40e1dc6..23a669d4ab 100644
--- a/apps/web/lib/api/fraud/create-fraud-events.ts
+++ b/apps/web/lib/api/fraud/create-fraud-events.ts
@@ -1,7 +1,7 @@
import { prisma } from "@/lib/prisma";
import { CreateFraudEventInput } from "@/lib/types";
import { prettyPrint } from "@dub/utils";
-import { Prisma } from "@prisma/client";
+import { FraudEventGroup, Prisma } from "@prisma/client";
import { createId } from "../create-id";
import {
createFraudEventHash,
@@ -10,12 +10,21 @@ import {
sanitizeFraudEventMetadata,
} from "./utils";
-export async function createFraudEvents(fraudEvents: CreateFraudEventInput[]) {
+type CreateFraudEventsResult = {
+ affectedGroups: Pick<FraudEventGroup, "partnerId" | "programId" | "type">[];
+};
+
+export async function createFraudEvents(
+ fraudEvents: CreateFraudEventInput[],
+): Promise<CreateFraudEventsResult> {
const startTime = performance.now();
if (fraudEvents.length === 0) {
console.log(`[createFraudEvents] No fraud events to create`);
- return;
+
+ return {
+ affectedGroups: [],
+ };
}
const eventsWithHash = fraudEvents.map((e) => ({
@@ -54,7 +63,10 @@ export async function createFraudEvents(fraudEvents: CreateFraudEventInput[]) {
if (newEvents.length === 0) {
console.log(`[createFraudEvents] No new fraud events to create`);
- return;
+
+ return {
+ affectedGroups: [],
+ };
}
// Find existing groups to avoid creating duplicates and maintain group continuity
@@ -136,6 +148,7 @@ export async function createFraudEvents(fraudEvents: CreateFraudEventInput[]) {
console.info(
`[createFraudEvents] Created ${createdEvents.count} fraud events ${prettyPrint(newEventsWithGroup)}`,
);
+
await Promise.allSettled(
finalGroups.map((group) =>
prisma.fraudEventGroup.update({
@@ -158,4 +171,8 @@ export async function createFraudEvents(fraudEvents: CreateFraudEventInput[]) {
console.info(
`[createFraudEvents] completed in ${(endTime - startTime).toFixed(2)}ms`,
);
+
+ return {
+ affectedGroups: finalGroups,
+ };
}
diff --git a/apps/web/lib/api/fraud/detect-duplicate-identity-fraud.ts b/apps/web/lib/api/fraud/detect-duplicate-identity-fraud.ts
index c2b92abe81..b5c9740ab5 100644
--- a/apps/web/lib/api/fraud/detect-duplicate-identity-fraud.ts
+++ b/apps/web/lib/api/fraud/detect-duplicate-identity-fraud.ts
@@ -9,6 +9,7 @@ import { INACTIVE_ENROLLMENT_STATUSES } from "@/lib/zod/schemas/partners";
import { FraudRuleType, ProgramEnrollment } from "@prisma/client";
import { createFraudEvents } from "./create-fraud-events";
import { isFraudRuleEnabled } from "./get-merged-fraud-rules";
+import { holdPendingCommissions } from "./hold-pending-commissions";
// Check for duplicate identities: if multiple partners share the same identity,
// create fraud events for all their active program enrollments to flag potential fraud
@@ -130,5 +131,7 @@ export async function detectDuplicateIdentityFraud({
}
}
- await createFraudEvents(fraudEvents);
+ const { affectedGroups } = await createFraudEvents(fraudEvents);
+
+ await holdPendingCommissions(affectedGroups);
}
diff --git a/apps/web/lib/api/fraud/detect-duplicate-payout-method-fraud.ts b/apps/web/lib/api/fraud/detect-duplicate-payout-method-fraud.ts
index e988a6a151..193757e65e 100644
--- a/apps/web/lib/api/fraud/detect-duplicate-payout-method-fraud.ts
+++ b/apps/web/lib/api/fraud/detect-duplicate-payout-method-fraud.ts
@@ -4,6 +4,7 @@ import { INACTIVE_ENROLLMENT_STATUSES } from "@/lib/zod/schemas/partners";
import { FraudRuleType, ProgramEnrollment } from "@prisma/client";
import { createFraudEvents } from "./create-fraud-events";
import { isFraudRuleEnabled } from "./get-merged-fraud-rules";
+import { holdPendingCommissions } from "./hold-pending-commissions";
type DetectDuplicatePayoutMethodFraudOptions =
| { payoutMethodHash: string; cryptoWalletAddress?: never }
@@ -106,5 +107,7 @@ export async function detectDuplicatePayoutMethodFraud({
}
}
- await createFraudEvents(fraudEvents);
+ const { affectedGroups } = await createFraudEvents(fraudEvents);
+
+ await holdPendingCommissions(affectedGroups);
}
diff --git a/apps/web/lib/api/fraud/hold-pending-commissions.ts b/apps/web/lib/api/fraud/hold-pending-commissions.ts
new file mode 100644
index 0000000000..a30273993b
--- /dev/null
+++ b/apps/web/lib/api/fraud/hold-pending-commissions.ts
@@ -0,0 +1,46 @@
+import { prisma } from "@/lib/prisma";
+import { chunk } from "@dub/utils";
+import { CommissionStatus, ProgramEnrollment } from "@prisma/client";
+import { syncTotalCommissions } from "../partners/sync-total-commissions";
+
+export async function holdPendingCommissions(
+ programEnrollments: Pick<ProgramEnrollment, "programId" | "partnerId">[],
+) {
+ if (programEnrollments.length === 0) {
+ return;
+ }
+
+ const uniquePairs = [
+ ...new Map(
+ programEnrollments.map((e) => [`${e.programId}:${e.partnerId}`, e]),
+ ).values(),
+ ];
+
+ const chunks = chunk(uniquePairs, 50);
+
+ for (const chunk of chunks) {
+ const { count } = await prisma.commission.updateMany({
+ where: {
+ OR: chunk.map(({ programId, partnerId }) => ({
+ programId,
+ partnerId,
+ })),
+ status: CommissionStatus.pending,
+ },
+ data: {
+ status: CommissionStatus.hold,
+ },
+ });
+
+ if (count > 0) {
+ await Promise.all(
+ uniquePairs.map(({ programId, partnerId }) =>
+ syncTotalCommissions({
+ programId,
+ partnerId,
+ }),
+ ),
+ );
+ }
+ }
+}
diff --git a/apps/web/lib/api/fraud/report-cross-program-ban-to-network.ts b/apps/web/lib/api/fraud/report-cross-program-ban-to-network.ts
index ff8e112021..1300c579b7 100644
--- a/apps/web/lib/api/fraud/report-cross-program-ban-to-network.ts
+++ b/apps/web/lib/api/fraud/report-cross-program-ban-to-network.ts
@@ -3,6 +3,7 @@ import { isFraudRuleEnabled } from "@/lib/api/fraud/get-merged-fraud-rules";
import { prisma } from "@/lib/prisma";
import { INACTIVE_ENROLLMENT_STATUSES } from "@/lib/zod/schemas/partners";
import { FraudRuleType, PartnerBannedReason } from "@prisma/client";
+import { holdPendingCommissions } from "./hold-pending-commissions";
// Creates partnerCrossProgramBan fraud events in other programs where the partner is enrolled.
// Used when a program bans a partner so that other programs can be alerted about cross-program
@@ -56,7 +57,7 @@ export async function reportCrossProgramBanToNetwork({
return;
}
- await createFraudEvents(
+ const { affectedGroups } = await createFraudEvents(
affectedProgramEnrollments.map((affectedEnrollment) => ({
programId: affectedEnrollment.programId,
partnerId: affectedEnrollment.partnerId,
@@ -68,4 +69,6 @@ export async function reportCrossProgramBanToNetwork({
},
})),
);
+
+ await holdPendingCommissions(affectedGroups);
}