Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

update getDiscoverabilityRequirements logic

Steven Teyd255299a4771
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/profile/use-partner-discovery-requirements.ts b/apps/web/app/(ee)/partners.dub.co/(dashboard)/profile/use-partner-discovery-requirements.ts
index cce1a4a837..df33a11c88 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/profile/use-partner-discovery-requirements.ts
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/profile/use-partner-discovery-requirements.ts
@@ -12,7 +12,6 @@ export function usePartnerDiscoveryRequirements() {
const checklistProgress = getPartnerProfileChecklistProgress({
partner,
- programEnrollments,
});
return checklistProgress.tasks;
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/marketplace/[programSlug]/header-controls.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/marketplace/[programSlug]/header-controls.tsx
index 65e4574cd5..790ff847bc 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/marketplace/[programSlug]/header-controls.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/marketplace/[programSlug]/header-controls.tsx
@@ -4,6 +4,7 @@ import { acceptProgramInviteAction } from "@/lib/actions/partners/accept-program
import { getPartnerProfileChecklistProgress } from "@/lib/network/get-partner-profile-checklist-progress";
import { mutatePrefix } from "@/lib/swr/mutate";
import usePartnerProfile from "@/lib/swr/use-partner-profile";
+import useProgramEnrollment from "@/lib/swr/use-program-enrollment";
import useProgramEnrollments from "@/lib/swr/use-program-enrollments";
import { NetworkProgramProps } from "@/lib/types";
import { useProgramApplicationSheet } from "@/ui/partners/program-application-sheet";
@@ -50,32 +51,25 @@ function ApplyButton({ program }: { program: NetworkProgramProps }) {
});
const { partner } = usePartnerProfile();
- const { programEnrollments } = useProgramEnrollments();
- const programEnrollment = useMemo(
- () =>
- programEnrollments?.find(
- (programEnrollment) => programEnrollment.program.slug === program.slug,
- ),
- [programEnrollments, program.slug],
- );
+ const { programEnrollment } = useProgramEnrollment();
const checklistProgress = useMemo(() => {
- return partner && programEnrollments
+ return partner
? getPartnerProfileChecklistProgress({
partner,
- programEnrollments,
})
: undefined;
- }, [partner, programEnrollments]);
+ }, [partner]);
const disabledTooltip: ReactNode =
- programEnrollment?.status === "banned" ? (
- "You are banned from this program"
- ) : programEnrollment?.status === "pending" ? (
+ programEnrollment?.status === "pending" ? (
"Your application is under review"
- ) : programEnrollment?.status === "rejected" ? (
- "Your application was rejected"
+ ) : programEnrollment?.status &&
+ ["banned", "rejected", "deactivated"].includes(
+ programEnrollment.status,
+ ) ? (
+ `You were ${programEnrollment.status} from this program`
) : checklistProgress && !checklistProgress.isComplete ? (
<div className="max-w-xs p-4">
<div className="text-content-default text-sm leading-5">
diff --git a/apps/web/lib/actions/partners/create-program-application.ts b/apps/web/lib/actions/partners/create-program-application.ts
index 1e9447845a..a1aeb264c2 100644
--- a/apps/web/lib/actions/partners/create-program-application.ts
+++ b/apps/web/lib/actions/partners/create-program-application.ts
@@ -192,7 +192,6 @@ export const createProgramApplicationAction = actionClient
({ salesChannel }) => salesChannel,
),
},
- programEnrollments: existingPartner.programs,
});
if (!isComplete) {
diff --git a/apps/web/lib/network/get-discoverability-requirements.ts b/apps/web/lib/network/get-discoverability-requirements.ts
index f36df8f258..75d06aabe2 100644
--- a/apps/web/lib/network/get-discoverability-requirements.ts
+++ b/apps/web/lib/network/get-discoverability-requirements.ts
@@ -29,7 +29,6 @@ export const partnerIsNotBanned = (
export function getDiscoverabilityRequirements({
partner,
- programEnrollments,
}: {
partner: Pick<
PartnerProps,
@@ -40,10 +39,6 @@ export function getDiscoverabilityRequirements({
| "salesChannels"
| "platforms"
>;
- programEnrollments: Pick<
- EnrolledPartnerProps,
- "programId" | "status" | "totalCommissions"
- >[];
}) {
return [
{
@@ -79,9 +74,5 @@ export function getDiscoverabilityRequirements({
href: "#channels",
completed: Boolean(partner.salesChannels?.length),
},
- {
- label: "Maintain a healthy partner profile",
- completed: partnerIsNotBanned(programEnrollments),
- },
];
}
diff --git a/apps/web/lib/network/get-partner-profile-checklist-progress.ts b/apps/web/lib/network/get-partner-profile-checklist-progress.ts
index 392faf3649..a0f4464b9b 100644
--- a/apps/web/lib/network/get-partner-profile-checklist-progress.ts
+++ b/apps/web/lib/network/get-partner-profile-checklist-progress.ts
@@ -1,9 +1,8 @@
-import { EnrolledPartnerProps, PartnerProps } from "../types";
+import { PartnerProps } from "../types";
import { getDiscoverabilityRequirements } from "./get-discoverability-requirements";
export function getPartnerProfileChecklistProgress({
partner,
- programEnrollments,
}: {
partner: Pick<
PartnerProps,
@@ -14,14 +13,9 @@ export function getPartnerProfileChecklistProgress({
| "salesChannels"
| "platforms"
>;
- programEnrollments: Pick<
- EnrolledPartnerProps,
- "programId" | "status" | "totalCommissions"
- >[];
}) {
const tasks = getDiscoverabilityRequirements({
partner,
- programEnrollments,
});
const completedCount = tasks.filter(({ completed }) => completed).length;