The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
fold the spam hold into application screening criteria
Pedro Ladeirad364ddee5369
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/application-settings-sheet.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/application-settings-sheet.tsxindex 7e7ee20555..6ad363293b 100644--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/application-settings-sheet.tsx+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/application-settings-sheet.tsx@@ -18,7 +18,6 @@ import {Button,Sheet,Sparkle3,- Switch,ToggleGroup,useEnterSubmit,} from "@dub/ui";@@ -44,7 +43,6 @@ type FormData = {categories: Category[];eligibilityConditions: EligibilityCondition[];applicationScreeningCriteria: string;- aiAutoApproveEnabled: boolean;};function ApplicationSettingsSheetContent({@@ -54,7 +52,6 @@ function ApplicationSettingsSheetContent({const { program } = useProgram<ProgramProps & {applicationScreeningCriteria: string | null;- aiAutoApproveEnabledAt: Date | null;}>();const { id: workspaceId, defaultProgramId } = useWorkspace();@@ -79,7 +76,6 @@ function ApplicationSettingsSheetContent({categories: [],eligibilityConditions: [],applicationScreeningCriteria: "",- aiAutoApproveEnabled: false,},});@@ -103,7 +99,6 @@ function ApplicationSettingsSheetContent({.filter((c) => c.key === "country").map((c) => ({ ...c, key: "country" as const, id: generateId() })),applicationScreeningCriteria: program.applicationScreeningCriteria ?? "",- aiAutoApproveEnabled: Boolean(program.aiAutoApproveEnabledAt),});}, [program?.id, reset]);@@ -132,7 +127,6 @@ function ApplicationSettingsSheetContent({...hiddenEligibilityConditions.current,],applicationScreeningCriteria: data.applicationScreeningCriteria,- aiAutoApproveEnabled: data.aiAutoApproveEnabled,}).then((result) => {if (result?.serverError || result?.validationErrors) {throw new Error(@@ -251,7 +245,7 @@ function ApplicationSettingsSheetContent({{...register("applicationScreeningCriteria")}maxLength={2000}rows={4}- placeholder="Partners that offer SEO, backlinking, paid advertising, or affiliate marketing services."+ placeholder="Block spam applications / partners that run paid ads or coupon sites"onKeyDown={handleKeyDown}className={cn("w-full rounded-lg border border-neutral-300 text-neutral-900 placeholder-neutral-400 focus:border-neutral-500 focus:outline-none focus:ring-neutral-500 sm:text-sm",@@ -266,32 +260,6 @@ function ApplicationSettingsSheetContent({loading={groupsLoading}autoApprove={autoApprove}/>-- <label className="flex cursor-pointer select-none items-start gap-3">- <Controller- control={control}- name="aiAutoApproveEnabled"- render={({ field }) => (- <span className="mt-0.5 inline-flex">- <Switch- checked={field.value}- fn={field.onChange}- disabled={groupsLoading}- />- </span>- )}- />- <span>- <span className="flex items-center gap-1 text-sm font-medium leading-5 tracking-[-0.02em] text-neutral-800">- <Sparkle3 variant="fill" className="size-4 shrink-0" />- Hold spam applications for review- </span>- <span className="mt-0.5 block text-xs font-normal leading-4 tracking-[-0.02em] text-neutral-500">- When auto-approving, high-confidence spam or clearly- irrelevant applications stay pending.- </span>- </span>- </label></div></>)}diff --git a/apps/web/lib/actions/partners/update-application-settings.ts b/apps/web/lib/actions/partners/update-application-settings.tsindex 24979e6d46..bb65ad8190 100644--- a/apps/web/lib/actions/partners/update-application-settings.ts+++ b/apps/web/lib/actions/partners/update-application-settings.ts@@ -14,7 +14,6 @@ const schema = z.object({categories: z.array(z.enum(Category)).optional(),eligibilityConditions: applicationRequirementsSchema.optional(),applicationScreeningCriteria: z.string().max(2000).optional(),- aiAutoApproveEnabled: z.boolean().optional(),});export const updateApplicationSettingsAction = authActionClient@@ -26,7 +25,6 @@ export const updateApplicationSettingsAction = authActionClientcategories,eligibilityConditions,applicationScreeningCriteria,- aiAutoApproveEnabled,} = parsedInput;throwIfNoPermission({@@ -36,18 +34,6 @@ export const updateApplicationSettingsAction = authActionClientconst programId = getDefaultProgramIdOrThrow(workspace);- const aiAutoApproveEnabledAt =- aiAutoApproveEnabled === false- ? null- : aiAutoApproveEnabled === true- ? (- await prisma.program.findUnique({- where: { id: programId },- select: { aiAutoApproveEnabledAt: true },- })- )?.aiAutoApproveEnabledAt ?? new Date()- : undefined;-const program = await prisma.program.update({where: {id: programId,@@ -67,9 +53,6 @@ export const updateApplicationSettingsAction = authActionClientapplicationScreeningCriteria:applicationScreeningCriteria.trim() || null,}),- ...(aiAutoApproveEnabledAt !== undefined && {- aiAutoApproveEnabledAt,- }),},});diff --git a/apps/web/lib/ai/evaluate-partner-application.ts b/apps/web/lib/ai/evaluate-partner-application.tsindex c8a3647451..b149f7a18c 100644--- a/apps/web/lib/ai/evaluate-partner-application.ts+++ b/apps/web/lib/ai/evaluate-partner-application.ts@@ -17,7 +17,7 @@ type ApplicationEvaluationFields = Pick<| "tiktok">;-export const JEV_MATCH_THRESHOLD = 0.85;+export const JEV_MATCH_THRESHOLD = 0.7;const MAX_TEXT_LENGTH = 500;const JEV_EVALUATE_TIMEOUT_MS = 2_000;@@ -65,28 +65,6 @@ export function isConfidentMatch(probability: number | null | undefined) {);}-export async function evaluatePartnerApplication(- input: EvaluatePartnerApplicationInput,-): Promise<JevEvaluation> {- const state = buildPartnerApplicationState(input);-- if (!state) {- return { status: "skipped" };- }-- return await evaluateBooleanQuestion({- state,- questionKey: "poorFit",- instructions:- "Is this application spam or clearly irrelevant to this program?",- criteria: {- true: "Spam or clearly irrelevant to the program",- false: "Plausible fit, or not enough signal to reject",- },- tag: "jev-partner-auto-approve",- });-}-export async function evaluateApplicationScreening({screeningCriteria,...inputdiff --git a/apps/web/lib/fetchers/get-program.ts b/apps/web/lib/fetchers/get-program.tsindex ad26b39f79..d5b1fe5f66 100644--- a/apps/web/lib/fetchers/get-program.ts+++ b/apps/web/lib/fetchers/get-program.ts@@ -14,12 +14,10 @@ type Result = Program & {export function omitInternalProgramFields<T extends {applicationScreeningCriteria?: string | null;- aiAutoApproveEnabledAt?: Date | null;},>(program: T) {const {applicationScreeningCriteria: _applicationScreeningCriteria,- aiAutoApproveEnabledAt: _aiAutoApproveEnabledAt,...publicProgram} = program;diff --git a/apps/web/lib/jobs/handlers/auto-approve-program-application-job.ts b/apps/web/lib/jobs/handlers/auto-approve-program-application-job.tsindex 53c653a9e9..86fde64a3d 100644--- a/apps/web/lib/jobs/handlers/auto-approve-program-application-job.ts+++ b/apps/web/lib/jobs/handlers/auto-approve-program-application-job.ts@@ -1,7 +1,5 @@-import { evaluatePartnerApplication } from "@/lib/ai/evaluate-partner-application";import { DubApiError } from "@/lib/api/errors";import { getProgramApplicationRisks } from "@/lib/api/fraud/get-program-application-risks";-import { logger } from "@/lib/axiom/server";import { evaluateApplicationRequirements } from "@/lib/partners/evaluate-application-requirements";import { getPlanCapabilities } from "@/lib/plan-capabilities";import { prisma } from "@/lib/prisma";@@ -69,7 +67,6 @@ export const autoApproveProgramApplicationJob = defineJob({description: true,applicationRequirements: true,applicationScreeningCriteria: true,- aiAutoApproveEnabledAt: true,workspace: {select: {plan: true,@@ -220,35 +217,6 @@ export const autoApproveProgramApplicationJob = defineJob({}}- if (program.aiAutoApproveEnabledAt) {- const evaluation = await evaluatePartnerApplication({- program: {- name: program.name,- description: program.description,- },- partner,- application: programApplication,- landerData: partnerGroup.landerData,- });-- logger.info("jev.partner.auto-approve", {- programId,- partnerId,- status: evaluation.status,- probability: evaluation.probability,- error: evaluation.error,- usage: evaluation.usage,- });- await logger.flush();-- if (evaluation.status === "matched") {- console.warn(- `Partner ${partnerId} held from auto-approve (Jev poorFit=${evaluation.probability}).`,- );- return;- }- }-try {// The group is resolved from the application itself, falling back to the// program's default groupdiff --git a/apps/web/lib/zod/schemas/programs.ts b/apps/web/lib/zod/schemas/programs.tsindex ba944af67c..47789ea57b 100644--- a/apps/web/lib/zod/schemas/programs.ts+++ b/apps/web/lib/zod/schemas/programs.ts@@ -88,7 +88,6 @@ export const ProgramSchema = z.object({export const ProgramSchemaWithInviteEmailData = ProgramSchema.extend({inviteEmailData: programInviteEmailDataSchema,applicationScreeningCriteria: z.string().nullish(),- aiAutoApproveEnabledAt: z.date().nullish(),});export const updateProgramSchema = z.object({diff --git a/apps/web/prisma/schema/program.prisma b/apps/web/prisma/schema/program.prismaindex ee4bf86b80..644b077ce5 100644--- a/apps/web/prisma/schema/program.prisma+++ b/apps/web/prisma/schema/program.prisma@@ -52,7 +52,6 @@ model Program {messagingEnabledAt DateTime?partnerNetworkEnabledAt DateTime?- aiAutoApproveEnabledAt DateTime?createdAt DateTime @default(now())updatedAt DateTime @updatedAtstartedAt DateTime?diff --git a/apps/web/tests/partners/program-config-exposure.test.ts b/apps/web/tests/partners/program-config-exposure.test.tsindex ba8c722464..b015219b2a 100644--- a/apps/web/tests/partners/program-config-exposure.test.ts+++ b/apps/web/tests/partners/program-config-exposure.test.ts@@ -22,7 +22,6 @@ const programRow = {defaultFolderId: "fold_1",defaultGroupId: "grp_1",applicationScreeningCriteria: "reject anyone doing SEO or backlinking",- aiAutoApproveEnabledAt: new Date(),createdAt: new Date(),updatedAt: new Date(),};@@ -45,21 +44,18 @@ describe("program config exposure", () => {});expect(parsed.program).not.toHaveProperty("applicationScreeningCriteria");- expect(parsed.program).not.toHaveProperty("aiAutoApproveEnabledAt");});it("is stripped from the bare ProgramSchema", () => {const parsed = ProgramSchema.parse(programRow);expect(parsed).not.toHaveProperty("applicationScreeningCriteria");- expect(parsed).not.toHaveProperty("aiAutoApproveEnabledAt");});it("is stripped from the public program loader", () => {const publicProgram = omitInternalProgramFields(programRow);expect(publicProgram).not.toHaveProperty("applicationScreeningCriteria");- expect(publicProgram).not.toHaveProperty("aiAutoApproveEnabledAt");expect(publicProgram).toEqual({id: programRow.id,name: programRow.name,@@ -87,6 +83,5 @@ describe("program config exposure", () => {expect(parsed.applicationScreeningCriteria).toBe("reject anyone doing SEO or backlinking",);- expect(parsed.aiAutoApproveEnabledAt).toBeInstanceOf(Date);});});