Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Make sure `performanceCount` doesn't exceed `condition.value`

Steven Teyd5258df1564f
diff --git a/apps/web/lib/bounty/api/upsert-draft-bounty-submissions.ts b/apps/web/lib/bounty/api/upsert-draft-bounty-submissions.ts
index 5de2d64e7c..1d35f80e85 100644
--- a/apps/web/lib/bounty/api/upsert-draft-bounty-submissions.ts
+++ b/apps/web/lib/bounty/api/upsert-draft-bounty-submissions.ts
@@ -101,7 +101,7 @@ export function planDraftBountySubmissionUpserts({
programId,
partnerId: partner.id,
bountyId,
- performanceCount,
+ performanceCount: conditionMet ? condition.value : performanceCount,
...(conditionMet && {
status: "submitted",
completedAt: new Date(),
@@ -114,7 +114,7 @@ export function planDraftBountySubmissionUpserts({
if (existing.performanceCount !== performanceCount || conditionMet) {
toUpdate.push({
id: existing.id,
- performanceCount,
+ performanceCount: conditionMet ? condition.value : performanceCount,
promoteToSubmitted: conditionMet,
});
}
diff --git a/apps/web/tests/bounties/upsert-draft-bounty-submissions.test.ts b/apps/web/tests/bounties/upsert-draft-bounty-submissions.test.ts
index 6fabaa8e1b..62cf300da4 100644
--- a/apps/web/tests/bounties/upsert-draft-bounty-submissions.test.ts
+++ b/apps/web/tests/bounties/upsert-draft-bounty-submissions.test.ts
@@ -211,7 +211,7 @@ describe("planDraftBountySubmissionUpserts", () => {
expect(toCreate).toHaveLength(1);
expect(toCreate[0]).toMatchObject({
- performanceCount: 15_000,
+ performanceCount: condition.value,
status: "submitted",
completedAt: expect.any(Date),
});
@@ -248,7 +248,7 @@ describe("planDraftBountySubmissionUpserts", () => {
expect(toUpdate).toEqual([
{
id: "bnty_sub_1",
- performanceCount: 12_000,
+ performanceCount: condition.value,
promoteToSubmitted: true,
},
]);