The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Improve "Matching customer email" fraud checking (#3596)
Kiran Kd53d73b61705
diff --git a/apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts b/apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.tsindex aea752d78d..4698cd8e17 100644--- a/apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts+++ b/apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts@@ -505,7 +505,10 @@ export async function checkoutSessionCompleted(program: { id: link.programId },partner: pick(webhookPartner, ["id", "email", "name"]),programEnrollment: pick(programEnrollment, ["status"]),- customer: pick(customer, ["id", "email", "name"]),+ customer: {+ ...pick(customer, ["id", "email", "name"]),+ isFirstConversion: firstConversionFlag,+ },link: pick(link, ["id"]),click: pick(saleData, ["url", "referer"]),event: { id: saleData.event_id },diff --git a/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts b/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.tsindex c0fb43b0c8..1ce63a3c55 100644--- a/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts+++ b/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts@@ -184,6 +184,7 @@ export async function invoicePaid(event: Stripe.Event, mode: StripeMode) {},include: includeTags,}),+// update workspace sales usageprisma.project.update({where: {@@ -273,7 +274,10 @@ export async function invoicePaid(event: Stripe.Event, mode: StripeMode) {program: { id: link.programId },partner: pick(webhookPartner, ["id", "email", "name"]),programEnrollment: pick(programEnrollment, ["status"]),- customer: pick(customer, ["id", "email", "name"]),+ customer: {+ ...pick(customer, ["id", "email", "name"]),+ isFirstConversion: firstConversionFlag,+ },link: pick(link, ["id"]),click: pick(saleData, ["url", "referer"]),event: { id: saleData.event_id },diff --git a/apps/web/lib/api/conversions/track-sale.ts b/apps/web/lib/api/conversions/track-sale.tsindex 25b293f39d..5fc3eb47c8 100644--- a/apps/web/lib/api/conversions/track-sale.ts+++ b/apps/web/lib/api/conversions/track-sale.ts@@ -593,7 +593,10 @@ const _trackSale = async ({program: { id: link.programId },partner: pick(webhookPartner, ["id", "email", "name"]),programEnrollment: pick(programEnrollment, ["status"]),- customer: pick(customer, ["id", "email", "name"]),+ customer: {+ ...pick(customer, ["id", "email", "name"]),+ isFirstConversion: firstConversionFlag,+ },link: pick(link, ["id"]),click: pick(saleData, ["url", "referer"]),event: { id: saleData.event_id },diff --git a/apps/web/lib/api/fraud/rules/check-customer-email-match.ts b/apps/web/lib/api/fraud/rules/check-customer-email-match.tsindex e6fc335b6a..d2a48a801c 100644--- a/apps/web/lib/api/fraud/rules/check-customer-email-match.ts+++ b/apps/web/lib/api/fraud/rules/check-customer-email-match.ts@@ -60,29 +60,36 @@ export const checkCustomerEmailMatch = defineFraudRule({// 3. Historical domain match — customer's email domain matches// a previously referred customer from the same partner- const historicalMatch = await prisma.customer.findFirst({- where: {- programId: program.id,- partnerId: partner.id,- id: {- not: customer.id,++ const shouldCheckHistoricalDomainMatch =+ ("isFirstConversion" in customer && customer.isFirstConversion) ||+ !("isFirstConversion" in customer);++ if (shouldCheckHistoricalDomainMatch) {+ const previousCustomer = await prisma.customer.findFirst({+ where: {+ programId: program.id,+ partnerId: partner.id,+ id: {+ not: customer.id,+ },+ email: {+ endsWith: `@${customerEmailDomain}`,+ },},- email: {- endsWith: `@${customerEmailDomain}`,+ select: {+ id: true,},- },- select: {- id: true,- },- });+ });- if (historicalMatch) {- return {- triggered: true,- metadata: {- matchType: CustomerEmailMatchType.HISTORICAL_DOMAIN_MATCH,- },- };+ if (previousCustomer) {+ return {+ triggered: true,+ metadata: {+ matchType: CustomerEmailMatchType.HISTORICAL_DOMAIN_MATCH,+ },+ };+ }}return {diff --git a/apps/web/lib/integrations/shopify/create-sale.ts b/apps/web/lib/integrations/shopify/create-sale.tsindex 783526dd52..f94ddecda7 100644--- a/apps/web/lib/integrations/shopify/create-sale.ts+++ b/apps/web/lib/integrations/shopify/create-sale.ts@@ -190,7 +190,10 @@ export async function createShopifySale({program: { id: link.programId },partner: pick(webhookPartner, ["id", "email", "name"]),programEnrollment: pick(programEnrollment, ["status"]),- customer: pick(customer, ["id", "email", "name"]),+ customer: {+ ...pick(customer, ["id", "email", "name"]),+ isFirstConversion: firstConversionFlag,+ },link: pick(link, ["id"]),click: pick(saleData, ["url", "referer"]),event: { id: saleData.event_id },diff --git a/apps/web/lib/zod/schemas/schemas.ts b/apps/web/lib/zod/schemas/schemas.tsindex f7a2503a22..6fd751dac0 100644--- a/apps/web/lib/zod/schemas/schemas.ts+++ b/apps/web/lib/zod/schemas/schemas.ts@@ -17,6 +17,7 @@ export const fraudEventContext = z.object({id: z.string(),email: z.string().nullable(),name: z.string().nullable(),+ isFirstConversion: z.boolean().nullish(),}),link: z.object({id: z.string().nullable().optional(),diff --git a/apps/web/scripts/misc/cleanup-fraud-events.ts b/apps/web/scripts/misc/cleanup-fraud-events.tsnew file mode 100644index 0000000000..729729b9f7--- /dev/null+++ b/apps/web/scripts/misc/cleanup-fraud-events.ts@@ -0,0 +1,79 @@+import "dotenv-flow/config";++import { prisma } from "@dub/prisma";++async function main() {+ const fraudEvents = await prisma.fraudEvent.findMany({+ where: {+ fraudEventGroup: {+ type: "customerEmailMatch",+ resolvedAt: null,+ },+ metadata: {+ path: "$.matchType",+ equals: "historicalDomainMatch",+ },+ customer: {+ sales: {+ gt: 1,+ },+ },+ },+ select: {+ id: true,+ fraudEventGroup: {+ select: {+ id: true,+ },+ },+ },+ orderBy: {+ createdAt: "desc",+ },+ });++ console.table(fraudEvents);++ // Remove fraud events+ if (fraudEvents.length > 0) {+ const { count } = await prisma.fraudEvent.deleteMany({+ where: {+ id: {+ in: fraudEvents.map((event) => event.id),+ },+ },+ });++ console.log(`Removed ${count} fraud events`);+ }++ // Remove fraud group if no events left+ const fraudEventGroupsWithNoEvents = await prisma.fraudEventGroup.findMany({+ where: {+ fraudEvents: {+ none: {},+ },+ },+ select: {+ id: true,+ },+ });++ console.log(+ `Found ${fraudEventGroupsWithNoEvents.length} with no events left.`,+ );++ if (fraudEventGroupsWithNoEvents.length > 0) {+ const { count } = await prisma.fraudEventGroup.deleteMany({+ where: {+ id: {+ in: fraudEventGroupsWithNoEvents.map((group) => group.id),+ },+ },+ });++ console.log(`Removed ${count} fraud event groups`);+ }+}++main();