The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Improve sale reward e2e tests
Steven Teyd65437e418a9
diff --git a/apps/web/tests/rewards/lead-reward.test.ts b/apps/web/tests/rewards/lead-reward.test.tsindex 95456359ec..abf28bc906 100644--- a/apps/web/tests/rewards/lead-reward.test.ts+++ b/apps/web/tests/rewards/lead-reward.test.ts@@ -18,9 +18,7 @@ describe.concurrent("Lead rewards", async () => {const clickResponse = await http.post<{ clickId: string }>({path: "/track/click",headers: E2E_TRACK_CLICK_HEADERS,- body: {- ...E2E_PARTNERS[0].shortLink,- },+ body: E2E_PARTNERS[0].shortLink,});expect(clickResponse.status).toEqual(200);diff --git a/apps/web/tests/rewards/sale-reward.test.ts b/apps/web/tests/rewards/sale-reward.test.tsindex c1e82a7d49..addec9ae7d 100644--- a/apps/web/tests/rewards/sale-reward.test.ts+++ b/apps/web/tests/rewards/sale-reward.test.ts@@ -6,8 +6,8 @@ import {} from "tests/utils/helpers";import {E2E_CUSTOMER_COUNTRY_CONDITIONS_EXTERNAL_ID,- E2E_CUSTOMER_SALE_CONDITIONS_EXTERNAL_ID,E2E_CUSTOMER_SIGNUP_DATE_CONDITIONS_EXTERNAL_ID,+ E2E_PARTNERS,E2E_SALE_REWARD,E2E_TRACK_CLICK_HEADERS,} from "tests/utils/resource";@@ -19,6 +19,28 @@ describe("Sale rewards with conditions", async () => {const h = new IntegrationHarness();const { http } = await h.init();+ const clickResponse = await http.post<{ clickId: string }>({+ path: "/track/click",+ headers: E2E_TRACK_CLICK_HEADERS,+ body: E2E_PARTNERS[0].shortLink,+ });+ expect(clickResponse.status).toEqual(200);+ const clickId = clickResponse.data.clickId;+ const newCustomer = randomCustomer();+ const trackLeadResponse = await http.post<TrackLeadResponse>({+ path: "/track/lead",+ body: {+ clickId,+ eventName: "Signup",+ customerExternalId: newCustomer.externalId,+ customerName: newCustomer.name,+ customerEmail: newCustomer.email,+ customerAvatar: newCustomer.avatar,+ mode: "wait",+ },+ });+ expect(trackLeadResponse.status).toEqual(200);+const randomSale = (eventName = "Payment") => ({eventName,currency: "usd",@@ -27,15 +49,90 @@ describe("Sale rewards with conditions", async () => {invoiceId: `INV_${randomId()}`,});+ describe.sequential("sequential track/sale tests", () => {+ test("when {Sale} {Type} is {new} vs {recurring}", async () => {+ const clickResponse = await http.post<{ clickId: string }>({+ path: "/track/click",+ headers: E2E_TRACK_CLICK_HEADERS,+ body: {+ domain: "getacme.link",+ key: "marvin",+ },+ });+ expect(clickResponse.status).toEqual(200);+ const trackedClickId = clickResponse.data.clickId;+ expect(trackedClickId).toStrictEqual(expect.any(String));++ const trackLeadResponse = await http.post<TrackLeadResponse>({+ path: "/track/lead",+ body: {+ clickId: trackedClickId,+ eventName: "E2E lead for new/recurring sale test",+ customerExternalId: newCustomer.externalId,+ customerName: newCustomer.name,+ customerEmail: newCustomer.email,+ customerAvatar: newCustomer.avatar,+ mode: "wait",+ },+ });++ expect(trackLeadResponse.status).toEqual(200);++ const sale = randomSale("E2E first sale");++ const trackSaleResponse = await http.post<TrackSaleResponse>({+ path: "/track/sale",+ body: {+ ...sale,+ customerExternalId: newCustomer.externalId,+ },+ });++ expect(trackSaleResponse.status).toEqual(200);++ await new Promise((resolve) => setTimeout(resolve, 3000));++ await verifyCommission({+ http,+ invoiceId: sale.invoiceId,+ expectedEarnings: E2E_SALE_REWARD.modifiers[5].amountInCents!,+ });++ // no need to verify second sale since it will be verified below+ // in the {Customer} {Subscription Duration} is {less than or equal to} {3} test+ });++ test("when {Customer} {Subscription Duration} is {less than or equal to} {3}", async () => {+ const sale = randomSale("E2E customer subscription duration condition");+ const trackSaleResponse = await http.post<TrackSaleResponse>({+ path: "/track/sale",+ body: {+ ...sale,+ customerExternalId: newCustomer.externalId,+ },+ });++ expect(trackSaleResponse.status).toEqual(200);++ await verifyCommission({+ http,+ invoiceId: sale.invoiceId,+ expectedEarnings: E2E_SALE_REWARD.modifiers[3].amountInCents!,+ });+ });+ });+describe.concurrent("concurrent track/sale tests", () => {- test("When {Sale} {Product ID} is {regularProductId}", async () => {+ // skipping this for now because we're using a newCustomer for each test,+ // and {Customer} {Subscription Duration} is {less than or equal to} {3} blocks the base case+ test.skip("When {Sale} {Product ID} is {regularProductId}", async () => {const sale = randomSale("E2E base condition");const response = await http.post<TrackSaleResponse>({path: "/track/sale",body: {...sale,- customerExternalId: E2E_CUSTOMER_SALE_CONDITIONS_EXTERNAL_ID,+ customerExternalId: newCustomer.externalId,metadata: {productId: "regularProductId",},@@ -58,7 +155,7 @@ describe("Sale rewards with conditions", async () => {path: "/track/sale",body: {...sale,- customerExternalId: E2E_CUSTOMER_SALE_CONDITIONS_EXTERNAL_ID,+ customerExternalId: newCustomer.externalId,metadata: {productId: "premiumProductId",},@@ -82,7 +179,7 @@ describe("Sale rewards with conditions", async () => {body: {...sale,amount: 17500,- customerExternalId: E2E_CUSTOMER_SALE_CONDITIONS_EXTERNAL_ID,+ customerExternalId: newCustomer.externalId,metadata: {productId: "premiumProductId",},@@ -138,79 +235,4 @@ describe("Sale rewards with conditions", async () => {});});});-- const newCustomer = randomCustomer();-- describe.sequential("sequential track/sale tests", () => {- test("when {Sale} {Type} is {new} vs {recurring}", async () => {- const clickResponse = await http.post<{ clickId: string }>({- path: "/track/click",- headers: E2E_TRACK_CLICK_HEADERS,- body: {- domain: "getacme.link",- key: "marvin",- },- });- expect(clickResponse.status).toEqual(200);- const trackedClickId = clickResponse.data.clickId;- expect(trackedClickId).toStrictEqual(expect.any(String));-- const trackLeadResponse = await http.post<TrackLeadResponse>({- path: "/track/lead",- body: {- clickId: trackedClickId,- eventName: "E2E lead for new/recurring sale test",- customerExternalId: newCustomer.externalId,- customerName: newCustomer.name,- customerEmail: newCustomer.email,- customerAvatar: newCustomer.avatar,- mode: "wait",- },- });-- expect(trackLeadResponse.status).toEqual(200);-- const sale = randomSale("E2E first sale");-- const trackSaleResponse = await http.post<TrackSaleResponse>({- path: "/track/sale",- body: {- ...sale,- customerExternalId: newCustomer.externalId,- },- });-- expect(trackSaleResponse.status).toEqual(200);-- await new Promise((resolve) => setTimeout(resolve, 3000));-- await verifyCommission({- http,- invoiceId: sale.invoiceId,- expectedEarnings: E2E_SALE_REWARD.modifiers[5].amountInCents!,- });-- // no need to verify second sale since it will be verified below- // in the {Customer} {Subscription Duration} is {less than or equal to} {3} test- });-- test("when {Customer} {Subscription Duration} is {less than or equal to} {3}", async () => {- const sale = randomSale("E2E customer subscription duration condition");- const trackSaleResponse = await http.post<TrackSaleResponse>({- path: "/track/sale",- body: {- ...sale,- customerExternalId: newCustomer.externalId,- },- });-- expect(trackSaleResponse.status).toEqual(200);-- await verifyCommission({- http,- invoiceId: sale.invoiceId,- expectedEarnings: E2E_SALE_REWARD.modifiers[3].amountInCents!,- });- });- });});diff --git a/apps/web/tests/utils/resource.ts b/apps/web/tests/utils/resource.tsindex 170d13a364..364be22105 100644--- a/apps/web/tests/utils/resource.ts+++ b/apps/web/tests/utils/resource.ts@@ -39,8 +39,6 @@ export const E2E_PUBLIC_ANALYTICS_FOLDER_ID = "fold_1JP8FXWM7PECSA4SA7FMGHDWE";// Different customer external IDs for different reward conditionsexport const E2E_CUSTOMER_ID = "cm25onzuv0001s1bbxchrc0ae";export const E2E_CUSTOMER_EXTERNAL_ID = "cus_jTrfVKYN3Buc3F80JoqBiY0g";-export const E2E_CUSTOMER_SALE_CONDITIONS_EXTERNAL_ID =- "cus_pqc8qRtofpu6ZqvutyNDGAU2";export const E2E_CUSTOMER_COUNTRY_CONDITIONS_EXTERNAL_ID ="cus_LnZbkb8boLsOn1YGLPxZGZMU";export const E2E_CUSTOMER_SIGNUP_DATE_CONDITIONS_EXTERNAL_ID =diff --git a/apps/web/tests/workflows/move-group-workflow.test.ts b/apps/web/tests/workflows/move-group-workflow.test.tsindex 15453d8129..a074fd56ce 100644--- a/apps/web/tests/workflows/move-group-workflow.test.ts+++ b/apps/web/tests/workflows/move-group-workflow.test.ts@@ -132,6 +132,8 @@ describe.sequential("Workflow - MoveGroup", async () => {expect(removeStatus).toEqual(200);+ await new Promise((resolve) => setTimeout(resolve, 5000));+const { data: deletedWorkflow } = await http.get<any>({path: "/e2e/workflows",query: { groupId: group.id },@@ -494,10 +496,11 @@ describe.sequential("Workflow - MoveGroup", async () => {const slug = "e2e-target-skip-partner-move";// Get the current group of E2E_PARTNER- const { data: partner, status: partnerStatus } =- await http.get<EnrolledPartnerProps>({- path: `/partners/${E2E_PARTNER.id}`,- });+ const { data: partner, status: partnerStatus } = await http.get<+ EnrolledPartnerProps & { groupMoveDisabledAt: Date }+ >({+ path: `/partners/${E2E_PARTNER.id}`,+ });expect(partnerStatus).toEqual(200);expect(partner).not.toBeNull();@@ -547,7 +550,9 @@ describe.sequential("Workflow - MoveGroup", async () => {expectedGroupId: partner.groupId!,});- const { data: partnerAfter } = await http.get<EnrolledPartnerProps>({+ const { data: partnerAfter } = await http.get<+ EnrolledPartnerProps & { groupMoveDisabledAt: Date }+ >({path: `/partners/${partner.id}`,});