Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Return an empty object when a link update keeps its partner

Cursor Agentd762dbafc562
diff --git a/apps/web/app/api/links/[linkId]/route.ts b/apps/web/app/api/links/[linkId]/route.ts
index 56956be034..cfd72bd730 100644
--- a/apps/web/app/api/links/[linkId]/route.ts
+++ b/apps/web/app/api/links/[linkId]/route.ts
@@ -117,7 +117,7 @@ export const PATCH = withWorkspace(
: link.expiresAt,
geo: link.geo as NewLinkProps["geo"],
...body,
- ...(partnerRemovalOverrides(body) ?? {}),
+ ...partnerRemovalOverrides(body),
// Only pass UTM tags to processLink when explicitly provided in body (preserves existing values otherwise)
...Object.fromEntries(
UTMTags.filter((tag) => tag in body).map((tag) => [tag, body[tag]]),
diff --git a/apps/web/app/api/links/bulk/route.ts b/apps/web/app/api/links/bulk/route.ts
index 3feecee9d1..cfa7fcc3c7 100644
--- a/apps/web/app/api/links/bulk/route.ts
+++ b/apps/web/app/api/links/bulk/route.ts
@@ -508,7 +508,7 @@ export const PATCH = withWorkspace(
}
}
- const removal = partnerRemovalOverrides(data) ?? {};
+ const removal = partnerRemovalOverrides(data);
const processedLinks = await Promise.all(
links.map(async (link) =>
diff --git a/apps/web/app/api/links/upsert/route.ts b/apps/web/app/api/links/upsert/route.ts
index 2e9b4e4b0f..b86e9ca474 100644
--- a/apps/web/app/api/links/upsert/route.ts
+++ b/apps/web/app/api/links/upsert/route.ts
@@ -76,7 +76,7 @@ export const PUT = withWorkspace(
? link.testStartedAt.toISOString()
: link.testStartedAt,
...body,
- ...(partnerRemovalOverrides(body) ?? {}),
+ ...partnerRemovalOverrides(body),
};
// if link and updatedLink are identical, return the link
diff --git a/apps/web/lib/api/links/partner-removal.ts b/apps/web/lib/api/links/partner-removal.ts
index 4a12bc5271..9aca28081f 100644
--- a/apps/web/lib/api/links/partner-removal.ts
+++ b/apps/web/lib/api/links/partner-removal.ts
@@ -11,9 +11,9 @@
export function partnerRemovalOverrides(patch: {
partnerId?: string | null;
programId?: string | null;
-}): { partnerId: null; programId: null } | null {
+}): { partnerId: null; programId: null } | Record<string, never> {
if (patch.partnerId !== null || patch.programId) {
- return null;
+ return {};
}
return { partnerId: null, programId: null };
diff --git a/apps/web/tests/links/partner-removal.test.ts b/apps/web/tests/links/partner-removal.test.ts
index eaaad12830..bb1f0ea909 100644
--- a/apps/web/tests/links/partner-removal.test.ts
+++ b/apps/web/tests/links/partner-removal.test.ts
@@ -5,11 +5,11 @@ import { describe, expect, test } from "vitest";
describe("partnerRemovalOverrides", () => {
test("leaves an update that does not clear the partner unchanged", () => {
- expect(partnerRemovalOverrides({})).toBeNull();
- expect(partnerRemovalOverrides({ partnerId: "pn_1" })).toBeNull();
+ expect(partnerRemovalOverrides({})).toEqual({});
+ expect(partnerRemovalOverrides({ partnerId: "pn_1" })).toEqual({});
expect(
partnerRemovalOverrides({ partnerId: "pn_1", programId: "prog_1" }),
- ).toBeNull();
+ ).toEqual({});
});
test("clears the program when the partner is removed and no new program is sent", () => {
@@ -28,7 +28,7 @@ describe("partnerRemovalOverrides", () => {
test("keeps an explicit program so a tenant can still enroll a partner", () => {
expect(
partnerRemovalOverrides({ partnerId: null, programId: "prog_1" }),
- ).toBeNull();
+ ).toEqual({});
});
});