Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Harden Tremendous campaign creation and label payout QStash jobs

Kiran Kdc2e234fb745
diff --git a/apps/web/app/(ee)/api/cron/payouts/charge-succeeded/utils.ts b/apps/web/app/(ee)/api/cron/payouts/charge-succeeded/utils.ts
index d86fc42cd3..cfed583dad 100644
--- a/apps/web/app/(ee)/api/cron/payouts/charge-succeeded/utils.ts
+++ b/apps/web/app/(ee)/api/cron/payouts/charge-succeeded/utils.ts
@@ -35,6 +35,7 @@ export async function scheduleDelayedPayouts({
url: `${APP_DOMAIN_WITH_NGROK}/api/cron/payouts/charge-succeeded`,
delay: delaySeconds + 5 * 60, // 5 minutes delay to give some buffer for the card charge to settle fully
deduplicationId: `retry-delayed-payouts-${invoice.id}`, // The deduplication window is 10 minutes
+ label: invoice.id,
flowControl: {
key: invoice.id,
rate: 1,
diff --git a/apps/web/app/(ee)/api/stripe/webhook/charge-succeeded.ts b/apps/web/app/(ee)/api/stripe/webhook/charge-succeeded.ts
index 274221f147..9ef5e43077 100644
--- a/apps/web/app/(ee)/api/stripe/webhook/charge-succeeded.ts
+++ b/apps/web/app/(ee)/api/stripe/webhook/charge-succeeded.ts
@@ -89,6 +89,7 @@ async function processPayoutInvoice({ invoice }: { invoice: Invoice }) {
const qstashResponse = await qstash.publishJSON({
url: `${APP_DOMAIN_WITH_NGROK}/api/cron/payouts/charge-succeeded`,
+ label: invoice.id,
flowControl: {
key: invoice.id,
rate: 1,
diff --git a/apps/web/lib/axiom/server.ts b/apps/web/lib/axiom/server.ts
index 520a3fd979..d3213880e0 100644
--- a/apps/web/lib/axiom/server.ts
+++ b/apps/web/lib/axiom/server.ts
@@ -61,3 +61,18 @@ export const withAxiomBodyLog = createAxiomRouteHandler(logger, {
});
export const withAxiom = createAxiomRouteHandler(logger);
+
+export function toErrorFields(error: unknown) {
+ const response =
+ error && typeof error === "object" && "response" in error
+ ? (error as { response?: { status?: number; data?: unknown } }).response
+ : undefined;
+
+ return {
+ name: error instanceof Error ? error.name : undefined,
+ message: error instanceof Error ? error.message : String(error),
+ stack: error instanceof Error ? error.stack : undefined,
+ status: response?.status,
+ response: response?.data,
+ };
+}
diff --git a/apps/web/lib/tremendous/create-tremendous-campaign.ts b/apps/web/lib/tremendous/create-tremendous-campaign.ts
index fdb65946cd..d040ff54ec 100644
--- a/apps/web/lib/tremendous/create-tremendous-campaign.ts
+++ b/apps/web/lib/tremendous/create-tremendous-campaign.ts
@@ -1,3 +1,4 @@
+import { logger, toErrorFields } from "@/lib/axiom/server";
import { prisma } from "@/lib/prisma";
import { Program } from "@prisma/client";
import { CampaignsApi, CreateCampaign200Response } from "tremendous";
@@ -13,25 +14,40 @@ export async function createTremendousCampaign(
const campaignsApi = new CampaignsApi(tremendousConfiguration);
- const { data } = await campaignsApi.createCampaign({
- name: `${program.name} Partners`,
- description: `Earn gift cards for referring new partners to ${program.name}`,
- products: TREMENDOUS_PRODUCT_IDS,
- fee_charged_to: "RECIPIENT",
- webpage_style: {
- headline: `${program.name} sent you a {{ amount }} gift card`,
- logo_image_url: program.logo,
- },
- });
+ try {
+ const { data } = await campaignsApi.createCampaign({
+ name: `${program.name} Partners`,
+ description: `Earn gift cards for referring new partners to ${program.name}`,
+ products: TREMENDOUS_PRODUCT_IDS,
+ fee_charged_to: "RECIPIENT",
+ webpage_style: {
+ headline: `${program.name} sent you a {{ amount }} gift card`,
+ logo_image_url: program.logo,
+ },
+ });
- const { campaign } = data as CreateCampaign200Response;
+ const { campaign } = data as CreateCampaign200Response;
- await prisma.program.update({
- where: {
- id: program.id,
- },
- data: {
- tremendousCampaignId: campaign.id,
- },
- });
+ await prisma.program.updateMany({
+ where: {
+ id: program.id,
+ tremendousCampaignId: null,
+ },
+ data: {
+ tremendousCampaignId: campaign.id,
+ },
+ });
+ } catch (error) {
+ logger.error("create_campaign_failed", {
+ service: "tremendous",
+ error: toErrorFields(error),
+ correlation: {
+ programId: program.id,
+ },
+ });
+
+ await logger.flush();
+
+ throw error;
+ }
}