Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Remove `af_ua` and `af_ip` params for AppsFlyer links (#3994)

Steven Teyddb664c387f8
diff --git a/apps/web/lib/integrations/appsflyer/constants.ts b/apps/web/lib/integrations/appsflyer/constants.ts
index 496baab85a..bfecdcd0d5 100644
--- a/apps/web/lib/integrations/appsflyer/constants.ts
+++ b/apps/web/lib/integrations/appsflyer/constants.ts
@@ -14,16 +14,6 @@ export const APPSFLYER_HARDCODED_PARAMETERS = [
value: "{dub_id}",
description: "Dub click ID",
},
- {
- key: "af_ua",
- value: "{userAgent}",
- description: "User agent",
- },
- {
- key: "af_ip",
- value: "{ipAddress}",
- description: "IP address",
- },
];
export const APPSFLYER_REQUIRED_PARAMETERS = [
diff --git a/apps/web/lib/middleware/utils/get-final-url.ts b/apps/web/lib/middleware/utils/get-final-url.ts
index 4d0e6127b0..dffec203ae 100644
--- a/apps/web/lib/middleware/utils/get-final-url.ts
+++ b/apps/web/lib/middleware/utils/get-final-url.ts
@@ -68,12 +68,6 @@ export const getFinalUrl = (
urlObj.searchParams.set("clickid", clickId);
}
- urlObj.searchParams.set("af_ua", ua);
-
- if (ip) {
- urlObj.searchParams.set("af_ip", ip);
- }
-
// set dynamic params (if not exist)
if (!urlObj.searchParams.has("c") && via) {
urlObj.searchParams.set("c", via);
diff --git a/apps/web/tests/redirects/index.test.ts b/apps/web/tests/redirects/index.test.ts
index 2252018719..803fb80a41 100644
--- a/apps/web/tests/redirects/index.test.ts
+++ b/apps/web/tests/redirects/index.test.ts
@@ -183,11 +183,9 @@ describe.runIf(env.CI)("Link Redirects", async () => {
test("appsflyer tracking url", async () => {
const response = await fetch(`${h.baseUrl}/appsflyer`, fetchOptions);
- // location to include clickid, af_siteid, af_ip, af_ua query params
+ // location to include clickid, af_siteid query params
expect(response.headers.get("location")).toMatch(/pid=dubinc_int/);
expect(response.headers.get("location")).toMatch(/clickid=[a-zA-Z0-9]+/);
- expect(response.headers.get("location")).toMatch(/af_ua=.+/);
- expect(response.headers.get("location")).toMatch(/af_ip=[a-zA-Z0-9.]+/);
expect(response.headers.get("x-powered-by")).toBe(poweredBy);
expect(response.status).toBe(302);
});