Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

address CR feedback

Steven Teyded2e167f404
diff --git a/apps/web/lib/api/fraud/detect-duplicate-identity-fraud.ts b/apps/web/lib/api/fraud/detect-duplicate-identity-fraud.ts
index bdbdaa9eba..052f20473c 100644
--- a/apps/web/lib/api/fraud/detect-duplicate-identity-fraud.ts
+++ b/apps/web/lib/api/fraud/detect-duplicate-identity-fraud.ts
@@ -134,8 +134,11 @@ export async function detectDuplicateIdentityFraud({
const { affectedGroups } = await createFraudEvents(fraudEvents);
- await Promise.allSettled([
+ const results = await Promise.allSettled([
holdPendingCommissions(affectedGroups),
holdProcessedCommissions(affectedGroups),
]);
+ results
+ .filter((r): r is PromiseRejectedResult => r.status === "rejected")
+ .forEach((r) => console.error("Failed to hold commissions:", r.reason));
}
diff --git a/apps/web/lib/api/fraud/detect-duplicate-payout-method-fraud.ts b/apps/web/lib/api/fraud/detect-duplicate-payout-method-fraud.ts
index 6767983b4b..a2226e21e1 100644
--- a/apps/web/lib/api/fraud/detect-duplicate-payout-method-fraud.ts
+++ b/apps/web/lib/api/fraud/detect-duplicate-payout-method-fraud.ts
@@ -110,8 +110,11 @@ export async function detectDuplicatePayoutMethodFraud({
const { affectedGroups } = await createFraudEvents(fraudEvents);
- await Promise.allSettled([
+ const results = await Promise.allSettled([
holdPendingCommissions(affectedGroups),
holdProcessedCommissions(affectedGroups),
]);
+ results
+ .filter((r): r is PromiseRejectedResult => r.status === "rejected")
+ .forEach((r) => console.error("Failed to hold commissions:", r.reason));
}
diff --git a/apps/web/lib/api/fraud/report-cross-program-ban-to-network.ts b/apps/web/lib/api/fraud/report-cross-program-ban-to-network.ts
index 8df50666a7..af3ee25861 100644
--- a/apps/web/lib/api/fraud/report-cross-program-ban-to-network.ts
+++ b/apps/web/lib/api/fraud/report-cross-program-ban-to-network.ts
@@ -71,8 +71,11 @@ export async function reportCrossProgramBanToNetwork({
})),
);
- await Promise.allSettled([
+ const results = await Promise.allSettled([
holdPendingCommissions(affectedGroups),
holdProcessedCommissions(affectedGroups),
]);
+ results
+ .filter((r): r is PromiseRejectedResult => r.status === "rejected")
+ .forEach((r) => console.error("Failed to hold commissions:", r.reason));
}
diff --git a/apps/web/lib/payouts/retally-payouts-amount.ts b/apps/web/lib/payouts/retally-payouts-amount.ts
index 88bd6819b9..4000ebc0b8 100644
--- a/apps/web/lib/payouts/retally-payouts-amount.ts
+++ b/apps/web/lib/payouts/retally-payouts-amount.ts
@@ -2,26 +2,30 @@ import { prisma } from "@/lib/prisma";
export const retallyPayoutsAmount = async (payoutIdsToRetally: string[]) => {
for (const payoutId of payoutIdsToRetally) {
- const commissionsSum = await prisma.commission.aggregate({
- where: {
- payoutId,
- },
- _sum: {
- earnings: true,
- },
- });
- const payoutAmount = commissionsSum._sum?.earnings ?? 0;
- if (payoutAmount > 0) {
- await prisma.payout.update({
- where: { id: payoutId },
- data: { amount: payoutAmount },
+ try {
+ const commissionsSum = await prisma.commission.aggregate({
+ where: {
+ payoutId,
+ },
+ _sum: {
+ earnings: true,
+ },
});
- console.log(`Updated payout ${payoutId} with amount ${payoutAmount}`);
- } else {
- await prisma.payout.delete({
- where: { id: payoutId },
- });
- console.log(`Deleted payout ${payoutId} because it has no earnings`);
+ const payoutAmount = commissionsSum._sum?.earnings ?? 0;
+ if (payoutAmount > 0) {
+ await prisma.payout.update({
+ where: { id: payoutId },
+ data: { amount: payoutAmount },
+ });
+ console.log(`Updated payout ${payoutId} with amount ${payoutAmount}`);
+ } else {
+ await prisma.payout.delete({
+ where: { id: payoutId },
+ });
+ console.log(`Deleted payout ${payoutId} because it has no earnings`);
+ }
+ } catch (error) {
+ console.error(`Error retallying payout ${payoutId}:`, error);
}
}
};