Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Remove leftover hold status handling from payout UI and API

Kiran Kdf2ae4c72541
diff --git a/apps/web/app/(ee)/api/programs/[programId]/payouts/eligible/count/route.ts b/apps/web/app/(ee)/api/programs/[programId]/payouts/eligible/count/route.ts
index 985e231446..c6e86e7aa6 100644
--- a/apps/web/app/(ee)/api/programs/[programId]/payouts/eligible/count/route.ts
+++ b/apps/web/app/(ee)/api/programs/[programId]/payouts/eligible/count/route.ts
@@ -31,7 +31,6 @@ export const GET = withWorkspace(async ({ workspace, searchParams }) => {
if (cutoffPeriodValue) {
const eligiblePayouts = await getEligiblePayouts({
program,
- workspace,
cutoffPeriod,
selectedPayoutIds,
excludedPayoutIds,
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/[payoutId]/page.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/[payoutId]/page.tsx
index 0a7eb7da4b..bcd6285876 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/[payoutId]/page.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/[payoutId]/page.tsx
@@ -59,6 +59,8 @@ type PayoutActivityItem = {
user?: PayoutResponse["user"];
};
+const terminalStatuses = ["completed", "sent", "failed", "canceled"] as const;
+
export default function PayoutDetailsPage() {
const { slug, id: workspaceId } = useWorkspace();
const { payout, loading, error } = usePayout();
@@ -281,13 +283,6 @@ function PayoutDetailsContent({
});
}
- const terminalStatuses = [
- "completed",
- "sent",
- "failed",
- "canceled",
- "hold",
- ] as const;
const terminalStatus = terminalStatuses.find((s) => s === payout.status);
if (terminalStatus) {
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/use-payout-filters.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/use-payout-filters.tsx
index fbe3a7c25b..ddadffa399 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/use-payout-filters.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/use-payout-filters.tsx
@@ -79,9 +79,7 @@ export function usePayoutFilters() {
)}
/>
),
- ...(value !== "hold" && {
- right: nFormatter(count || 0, { full: true }),
- }),
+ right: nFormatter(count || 0, { full: true }),
};
},
),