Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

improve tests

Steven Teye1efe51dbc36
diff --git a/apps/web/app/api/workspaces/route.ts b/apps/web/app/api/workspaces/route.ts
index 4b5800a467..6e143aa899 100644
--- a/apps/web/app/api/workspaces/route.ts
+++ b/apps/web/app/api/workspaces/route.ts
@@ -1,3 +1,4 @@
+import { isCI } from "@/lib/api/environment";
import { DubApiError } from "@/lib/api/errors";
import { generateRandomString } from "@/lib/api/utils/generate-random-string";
import { createWorkspaceId } from "@/lib/api/workspaces/create-workspace-id";
@@ -89,7 +90,8 @@ export const POST = withSession(async ({ req, session }) => {
},
});
- if (freeWorkspaces >= FREE_WORKSPACES_LIMIT) {
+ // apply free workspaces limit (if not in CI)
+ if (freeWorkspaces >= FREE_WORKSPACES_LIMIT && !isCI) {
throw new DubApiError({
code: "exceeded_limit",
message: `You can only create up to ${FREE_WORKSPACES_LIMIT} free workspaces. Additional workspaces require a paid plan.`,
diff --git a/apps/web/lib/zod/schemas/commissions.ts b/apps/web/lib/zod/schemas/commissions.ts
index a9fa096481..d440f5bbe8 100644
--- a/apps/web/lib/zod/schemas/commissions.ts
+++ b/apps/web/lib/zod/schemas/commissions.ts
@@ -499,7 +499,7 @@ const createCustomCommissionSchema = z.object({
}),
)
.describe(
- "The commission amount in cents. Use a negative amount to create a clawback.",
+ "The commission earnings amount in cents. Use a negative amount to create a clawback.",
),
date: parseDateSchema
.nullish()
@@ -652,8 +652,7 @@ const createSaleCommissionSchema = z
data.date != null && "date",
data.saleAmount != null && "saleAmount",
data.saleEventDate != null && "saleEventDate",
- (data.invoiceId != null || data.sale?.invoiceId != null) &&
- "invoiceId",
+ (data.invoiceId != null || data.sale?.invoiceId != null) && "invoiceId",
(data.productId != null || data.sale?.metadata?.productId != null) &&
"productId",
].filter((field): field is string => Boolean(field));
diff --git a/apps/web/playwright/api/clawbacks/clawbacks.spec.ts b/apps/web/playwright/api/commissions/clawbacks.spec.ts
similarity index 100%
rename from apps/web/playwright/api/clawbacks/clawbacks.spec.ts
rename to apps/web/playwright/api/commissions/clawbacks.spec.ts