Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Share workflow condition validation across bounty, campaign, and group move.

Kiran Ke290d435a8bd
diff --git a/apps/web/app/(ee)/api/bounties/[bountyId]/route.ts b/apps/web/app/(ee)/api/bounties/[bountyId]/route.ts
index d99c535729..922486ecda 100644
--- a/apps/web/app/(ee)/api/bounties/[bountyId]/route.ts
+++ b/apps/web/app/(ee)/api/bounties/[bountyId]/route.ts
@@ -4,6 +4,7 @@ import { throwIfInvalidGroupIds } from "@/lib/api/groups/throw-if-invalid-group-
import { getDefaultProgramIdOrThrow } from "@/lib/api/programs/get-default-program-id-or-throw";
import { parseRequestBody } from "@/lib/api/utils";
import { WorkflowCondition } from "@/lib/api/workflows/types";
+import { validateWorkflowConditions } from "@/lib/api/workflows/validate-workflow-conditions";
import { withWorkspace } from "@/lib/auth";
import { generatePerformanceBountyName } from "@/lib/bounty/api/generate-performance-bounty-name";
import { getBountyWithDetails } from "@/lib/bounty/api/get-bounty-with-details";
@@ -97,6 +98,13 @@ export const PATCH = withWorkspace(
performanceScope: bounty.performanceScope,
});
+ if (bounty.type === "performance" && performanceCondition) {
+ await validateWorkflowConditions({
+ conditions: [performanceCondition],
+ workflowType: "awardBounty",
+ });
+ }
+
if (
submissionRequirements !== undefined &&
submissionRequirements?.socialMetrics &&
diff --git a/apps/web/app/(ee)/api/bounties/route.ts b/apps/web/app/(ee)/api/bounties/route.ts
index dba50dfda3..e995e591a0 100644
--- a/apps/web/app/(ee)/api/bounties/route.ts
+++ b/apps/web/app/(ee)/api/bounties/route.ts
@@ -6,6 +6,7 @@ import { getDefaultProgramIdOrThrow } from "@/lib/api/programs/get-default-progr
import { getProgramEnrollmentOrThrow } from "@/lib/api/programs/get-program-enrollment-or-throw";
import { parseRequestBody } from "@/lib/api/utils";
import { WorkflowAction } from "@/lib/api/workflows/types";
+import { validateWorkflowConditions } from "@/lib/api/workflows/validate-workflow-conditions";
import { withWorkspace } from "@/lib/auth";
import { generatePerformanceBountyName } from "@/lib/bounty/api/generate-performance-bounty-name";
import { validateBounty } from "@/lib/bounty/api/validate-bounty";
@@ -174,6 +175,13 @@ export const POST = withWorkspace(
validateBounty(parsedBody);
+ if (type === "performance" && performanceCondition) {
+ await validateWorkflowConditions({
+ conditions: [performanceCondition],
+ workflowType: "awardBounty",
+ });
+ }
+
const { canUseBountySocialMetrics, canSendEmailCampaigns } =
getPlanCapabilities(workspace.plan);
diff --git a/apps/web/app/(ee)/api/campaigns/[campaignId]/route.ts b/apps/web/app/(ee)/api/campaigns/[campaignId]/route.ts
index 4ba951dbb3..b5c864af79 100644
--- a/apps/web/app/(ee)/api/campaigns/[campaignId]/route.ts
+++ b/apps/web/app/(ee)/api/campaigns/[campaignId]/route.ts
@@ -8,6 +8,7 @@ import { throwIfInvalidGroupIds } from "@/lib/api/groups/throw-if-invalid-group-
import { getDefaultProgramIdOrThrow } from "@/lib/api/programs/get-default-program-id-or-throw";
import { parseRequestBody } from "@/lib/api/utils";
import { parseWorkflowConfig } from "@/lib/api/workflows/parse-workflow-config";
+import { validateWorkflowConditions } from "@/lib/api/workflows/validate-workflow-conditions";
import { withWorkspace } from "@/lib/auth";
import { qstash } from "@/lib/cron";
import { prisma } from "@/lib/prisma";
@@ -76,6 +77,13 @@ export const PATCH = withWorkspace(
campaign,
});
+ if (triggerCondition) {
+ await validateWorkflowConditions({
+ conditions: [triggerCondition],
+ workflowType: "sendCampaign",
+ });
+ }
+
// if groupIds is provided and is different from the current groupIds, update the groups
let updatedPartnerGroups: PartnerGroup[] | undefined = undefined;
let shouldUpdateGroups = false;
diff --git a/apps/web/app/(ee)/api/cron/bounties/create-draft-submissions/route.ts b/apps/web/app/(ee)/api/cron/bounties/create-draft-submissions/route.ts
index ff0234134c..bf6f63a73d 100644
--- a/apps/web/app/(ee)/api/cron/bounties/create-draft-submissions/route.ts
+++ b/apps/web/app/(ee)/api/cron/bounties/create-draft-submissions/route.ts
@@ -1,11 +1,11 @@
import { createId } from "@/lib/api/create-id";
import { handleAndReturnErrorResponse } from "@/lib/api/errors";
-import { awardBountyConditionSchema } from "@/lib/api/workflows/award-bounty/schema";
import { evaluateWorkflowConditions } from "@/lib/api/workflows/evaluate-workflow-conditions";
import { qstash } from "@/lib/cron";
import { verifyQstashSignature } from "@/lib/cron/verify-qstash";
import { aggregatePartnerLinksStats } from "@/lib/partners/aggregate-partner-links-stats";
import { prisma } from "@/lib/prisma";
+import { workflowConditionsSchema } from "@/lib/zod/schemas/workflows";
import { APP_DOMAIN_WITH_NGROK, log, toCentsNumber } from "@dub/utils";
import { Prisma } from "@prisma/client";
import { differenceInMinutes } from "date-fns";
@@ -132,9 +132,9 @@ export async function POST(req: Request) {
);
// Find the workflow condition
- const condition = z
- .array(awardBountyConditionSchema)
- .parse(bounty.workflow.triggerConditions)[0];
+ const condition = workflowConditionsSchema.parse(
+ bounty.workflow.triggerConditions,
+ )[0];
// Partners with their link metrics
const partners = programEnrollments.map((programEnrollment) => {
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty/use-add-edit-bounty-form.ts b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty/use-add-edit-bounty-form.ts
index bb3a34a85c..5e03a6c3ef 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty/use-add-edit-bounty-form.ts
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty/use-add-edit-bounty-form.ts
@@ -1,6 +1,5 @@
"use client";
-import { awardBountyConditionSchema } from "@/lib/api/workflows/award-bounty/schema";
import { isCurrencyAttribute } from "@/lib/api/workflows/utils";
import { generatePerformanceBountyName } from "@/lib/bounty/api/generate-performance-bounty-name";
import {
@@ -13,6 +12,7 @@ import { useApiMutation } from "@/lib/swr/use-api-mutation";
import useWorkspace from "@/lib/swr/use-workspace";
import { BountyProps } from "@/lib/types";
import { bountySocialContentRequirementsSchema } from "@/lib/zod/schemas/bounties";
+import { workflowConditionSchema } from "@/lib/zod/schemas/workflows";
import { formatDate } from "@dub/utils";
import { BountySubmissionFrequency } from "@prisma/client";
import { Dispatch, SetStateAction, useEffect, useMemo, useState } from "react";
@@ -124,9 +124,11 @@ export function useAddEditBountyForm({
performanceCondition: bounty?.performanceCondition
? {
...bounty.performanceCondition,
- value: isCurrencyAttribute(bounty.performanceCondition.attribute)
- ? bounty.performanceCondition.value / 100
- : bounty.performanceCondition.value,
+ value:
+ typeof bounty.performanceCondition.value === "number" &&
+ isCurrencyAttribute(bounty.performanceCondition.attribute)
+ ? bounty.performanceCondition.value / 100
+ : bounty.performanceCondition.value,
}
: {
operator: "gte",
@@ -480,7 +482,11 @@ export function useAddEditBountyForm({
return "Performance value is required.";
}
- if (condition?.value !== null && condition.value < 0) {
+ if (
+ condition?.value !== null &&
+ typeof condition.value === "number" &&
+ condition.value < 0
+ ) {
return "Performance value must be greater than or equal to 0.";
}
@@ -540,7 +546,7 @@ export function useAddEditBountyForm({
numAmount != null && numAmount > 0 ? numAmount * 100 : null;
if (data.type === "performance") {
- const result = awardBountyConditionSchema.safeParse(
+ const result = workflowConditionSchema.safeParse(
data.performanceCondition,
);
@@ -555,9 +561,11 @@ export function useAddEditBountyForm({
condition = {
...condition,
- value: isCurrencyAttribute(condition.attribute)
- ? condition.value * 100
- : condition.value,
+ value:
+ typeof condition.value === "number" &&
+ isCurrencyAttribute(condition.attribute)
+ ? condition.value * 100
+ : condition.value,
};
data.performanceCondition = condition;
@@ -608,14 +616,14 @@ export function useAddEditBountyForm({
type === "performance" && performanceCondition
? generatePerformanceBountyName({
rewardAmount: rewardAmount ? rewardAmount * 100 : 0,
- condition: isCurrencyAttribute(
- performanceCondition?.attribute,
- )
- ? {
- ...performanceCondition,
- value: performanceCondition?.value * 100,
- }
- : performanceCondition,
+ condition:
+ typeof performanceCondition?.value === "number" &&
+ isCurrencyAttribute(performanceCondition?.attribute)
+ ? {
+ ...performanceCondition,
+ value: performanceCondition.value * 100,
+ }
+ : performanceCondition,
})
: name || "New bounty",
startsAt: startsAt || new Date(),
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/campaigns/[campaignId]/duplicate-logic-warning.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/campaigns/[campaignId]/duplicate-logic-warning.tsx
index c79f402973..0353eaa6b3 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/campaigns/[campaignId]/duplicate-logic-warning.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/campaigns/[campaignId]/duplicate-logic-warning.tsx
@@ -1,6 +1,6 @@
-import { sendCampaignConditionSchema } from "@/lib/api/workflows/send-campaign/schema";
import useWorkspace from "@/lib/swr/use-workspace";
import { CampaignList } from "@/lib/types";
+import { workflowConditionSchema } from "@/lib/zod/schemas/workflows";
import { ChevronUp, Copy, LoadingSpinner } from "@dub/ui";
import { cn, fetcher } from "@dub/utils";
import Link from "next/link";
@@ -21,7 +21,7 @@ export function DuplicateLogicWarning() {
const triggerCondition = useWatch({ control, name: "triggerCondition" });
const parsedTriggerCondition = triggerCondition
- ? sendCampaignConditionSchema.safeParse(triggerCondition)
+ ? workflowConditionSchema.safeParse(triggerCondition)
: undefined;
const { data: campaigns, isLoading } = useSWR<CampaignList[]>(
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/settings/group-additional-settings.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/settings/group-additional-settings.tsx
index 526426711e..dfa1440c34 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/settings/group-additional-settings.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/settings/group-additional-settings.tsx
@@ -1,7 +1,7 @@
"use client";
import { findGroupsWithMatchingRules } from "@/lib/api/groups/find-groups-with-matching-rules";
-import { validateGroupMoveRules } from "@/lib/api/groups/validate-group-move-rules";
+import { validateWorkflowConditions } from "@/lib/api/workflows/validate-workflow-conditions";
import { PAYOUT_HOLDING_PERIOD_DAYS } from "@/lib/constants/payouts";
import { mutatePrefix } from "@/lib/swr/mutate";
import { useApiMutation } from "@/lib/swr/use-api-mutation";
@@ -119,12 +119,14 @@ function GroupAdditionalSettingsForm({
if (!group) return;
if (data.moveRules && data.moveRules.length > 0) {
try {
- validateGroupMoveRules({
- rules: data.moveRules,
- destinationGroupId: group.id,
+ await validateWorkflowConditions({
+ conditions: data.moveRules,
+ workflowType: "moveGroup",
});
} catch (error) {
- toast.error(error.message);
+ toast.error(
+ error instanceof Error ? error.message : "Invalid group move rules.",
+ );
return;
}
diff --git a/apps/web/lib/api/groups/upsert-group-move-rules.ts b/apps/web/lib/api/groups/upsert-group-move-rules.ts
index d4e1167c8f..5718b60068 100644
--- a/apps/web/lib/api/groups/upsert-group-move-rules.ts
+++ b/apps/web/lib/api/groups/upsert-group-move-rules.ts
@@ -8,9 +8,9 @@ import { pluralize } from "@dub/utils";
import { PartnerGroup, WorkflowTrigger } from "@prisma/client";
import { createId } from "../create-id";
import { DubApiError } from "../errors";
+import { validateWorkflowConditions } from "../workflows/validate-workflow-conditions";
import { findGroupsWithMatchingRules } from "./find-groups-with-matching-rules";
import { getGroupMoveRules } from "./get-group-move-rules";
-import { validateGroupMoveRules } from "./validate-group-move-rules";
export async function upsertGroupMoveRules({
workspace,
@@ -50,18 +50,10 @@ export async function upsertGroupMoveRules({
};
}
- try {
- validateGroupMoveRules({
- rules: moveRules,
- destinationGroupId: group.id,
- });
- } catch (error) {
- throw new DubApiError({
- code: "bad_request",
- message:
- error instanceof Error ? error.message : "Invalid group move rules.",
- });
- }
+ await validateWorkflowConditions({
+ conditions: moveRules,
+ workflowType: "moveGroup",
+ });
const groupsWithMatchingRules = findGroupsWithMatchingRules({
groups: await getGroupMoveRules(group.programId),
diff --git a/apps/web/lib/api/groups/validate-group-move-rules.ts b/apps/web/lib/api/groups/validate-group-move-rules.ts
deleted file mode 100644
index 578dc1d4dd..0000000000
--- a/apps/web/lib/api/groups/validate-group-move-rules.ts
+++ /dev/null
@@ -1,101 +0,0 @@
-import {
- GROUP_MOVE_ATTRIBUTES,
- GROUP_MOVE_OPERATORS,
-} from "@/lib/api/workflows/move-group/schema";
-import type {
- GroupMoveAttributeKey,
- GroupMoveCondition,
- GroupMoveRules,
-} from "@/lib/api/workflows/move-group/types";
-import { WORKFLOW_OPERATORS } from "@/lib/api/workflows/operator-definitions";
-
-type GroupMoveAttributeValidator = (params: {
- rule: GroupMoveCondition;
- ruleIndex: number;
- destinationGroupId: string;
-}) => void;
-
-// Add business rules for each attribute
-// NOTE: Keeping this empty for now, next PR will use this
-const GROUP_MOVE_ATTRIBUTE_VALIDATORS: Record<
- GroupMoveAttributeKey,
- GroupMoveAttributeValidator
-> = {
- // Operator validators already cover performance value shape/constraints.
- totalLeads: () => {},
- totalConversions: () => {},
- totalSaleAmount: () => {},
- totalCommissions: () => {},
-};
-
-export const validateGroupMoveRules = ({
- rules,
- destinationGroupId,
-}: {
- rules?: GroupMoveRules;
- destinationGroupId: string;
-}) => {
- if (!rules || rules.length === 0) {
- return;
- }
-
- for (let i = 0; i < rules.length; i++) {
- validateRule({
- rule: rules[i],
- ruleIndex: i,
- destinationGroupId,
- });
- }
-};
-
-// Validates a single group move rule
-const validateRule = ({
- rule,
- ruleIndex,
- destinationGroupId,
-}: {
- rule: GroupMoveCondition;
- ruleIndex: number;
- destinationGroupId: string;
-}) => {
- if (!rule.attribute) {
- throw new Error(`Rule ${ruleIndex + 1}: Please select an activity.`);
- }
-
- // Check if operator is valid for the attribute
- const allowedOperators = GROUP_MOVE_ATTRIBUTES[rule.attribute]
- .operators as readonly string[];
-
- const operatorLabel = GROUP_MOVE_OPERATORS[rule.operator].label;
-
- if (!allowedOperators.includes(rule.operator)) {
- throw new Error(
- `Operator "${operatorLabel}" is not valid for the activity "${rule.attribute}".`,
- );
- }
-
- // Check if value is set
- if (rule.value == null || rule.value === undefined) {
- throw new Error(`Rule ${ruleIndex + 1}: Please enter a value.`);
- }
-
- // Validate value shape/constraints for the selected operator
- const operator = WORKFLOW_OPERATORS[rule.operator];
-
- if (operator) {
- try {
- operator.validate(rule.value);
- } catch (error) {
- throw new Error(
- `Rule ${ruleIndex + 1}: ${error instanceof Error ? error.message : "Invalid value."}`,
- );
- }
- }
-
- // Validate attribute-specific constraints (business rules)
- GROUP_MOVE_ATTRIBUTE_VALIDATORS[rule.attribute]({
- rule,
- ruleIndex,
- destinationGroupId,
- });
-};
diff --git a/apps/web/lib/api/workflows/award-bounty/schema.ts b/apps/web/lib/api/workflows/award-bounty/schema.ts
index 2a1b19813c..ed499a1f37 100644
--- a/apps/web/lib/api/workflows/award-bounty/schema.ts
+++ b/apps/web/lib/api/workflows/award-bounty/schema.ts
@@ -1,8 +1,7 @@
import { WORKFLOW_OPERATORS } from "@/lib/api/workflows/operator-definitions";
-import * as z from "zod/v4";
import { WORKFLOW_ATTRIBUTES } from "../attribute-definitions";
-const AWARD_BOUNTY_ATTRIBUTES = {
+export const AWARD_BOUNTY_ATTRIBUTES = {
totalLeads: WORKFLOW_ATTRIBUTES.totalLeads,
totalConversions: WORKFLOW_ATTRIBUTES.totalConversions,
totalSaleAmount: WORKFLOW_ATTRIBUTES.totalSaleAmount,
@@ -16,13 +15,3 @@ export const AWARD_BOUNTY_ATTRIBUTE_KEYS = Object.keys(
export const AWARD_BOUNTY_OPERATORS = {
gte: WORKFLOW_OPERATORS.gte,
};
-
-const AWARD_BOUNTY_OPERATOR_KEYS = Object.keys(
- AWARD_BOUNTY_OPERATORS,
-) as readonly (keyof typeof AWARD_BOUNTY_OPERATORS)[];
-
-export const awardBountyConditionSchema = z.object({
- attribute: z.enum(AWARD_BOUNTY_ATTRIBUTE_KEYS),
- operator: z.enum(AWARD_BOUNTY_OPERATOR_KEYS).default("gte"),
- value: z.number(),
-});
diff --git a/apps/web/lib/api/workflows/award-bounty/types.ts b/apps/web/lib/api/workflows/award-bounty/types.ts
index 0e19452781..c97edf46b4 100644
--- a/apps/web/lib/api/workflows/award-bounty/types.ts
+++ b/apps/web/lib/api/workflows/award-bounty/types.ts
@@ -1,4 +1,3 @@
-import type * as z from "zod/v4";
-import type { awardBountyConditionSchema } from "./schema";
+import type { WorkflowCondition } from "@/lib/api/workflows/types";
-export type AwardBountyCondition = z.infer<typeof awardBountyConditionSchema>;
+export type AwardBountyCondition = WorkflowCondition;
diff --git a/apps/web/lib/api/workflows/move-group/schema.ts b/apps/web/lib/api/workflows/move-group/schema.ts
index f58593dc2a..cc9124bd90 100644
--- a/apps/web/lib/api/workflows/move-group/schema.ts
+++ b/apps/web/lib/api/workflows/move-group/schema.ts
@@ -1,5 +1,3 @@
-import { WORKFLOW_OPERATORS } from "@/lib/api/workflows/operator-definitions";
-import * as z from "zod/v4";
import { WORKFLOW_ATTRIBUTES } from "../attribute-definitions";
export const GROUP_MOVE_ATTRIBUTES = {
@@ -24,26 +22,3 @@ export const GROUP_MOVE_ATTRIBUTES = {
export const GROUP_MOVE_ATTRIBUTE_KEYS = Object.keys(
GROUP_MOVE_ATTRIBUTES,
) as readonly (keyof typeof GROUP_MOVE_ATTRIBUTES)[];
-
-export const GROUP_MOVE_OPERATORS = {
- gte: WORKFLOW_OPERATORS.gte,
- between: WORKFLOW_OPERATORS.between,
-};
-
-const GROUP_MOVE_OPERATOR_KEYS = Object.keys(
- GROUP_MOVE_OPERATORS,
-) as readonly (keyof typeof GROUP_MOVE_OPERATORS)[];
-
-const groupMoveConditionSchema = z.object({
- attribute: z.enum(GROUP_MOVE_ATTRIBUTE_KEYS),
- operator: z.enum(GROUP_MOVE_OPERATOR_KEYS).default("gte"),
- value: z.union([
- z.number(),
- z.object({
- min: z.number(),
- max: z.number(),
- }),
- ]),
-});
-
-export const groupMoveRulesSchema = z.array(groupMoveConditionSchema);
diff --git a/apps/web/lib/api/workflows/move-group/types.ts b/apps/web/lib/api/workflows/move-group/types.ts
index 8c0919213e..6b21775fc7 100644
--- a/apps/web/lib/api/workflows/move-group/types.ts
+++ b/apps/web/lib/api/workflows/move-group/types.ts
@@ -1,10 +1,9 @@
-import type * as z from "zod/v4";
+import type { WorkflowCondition } from "@/lib/api/workflows/types";
+import type { GROUP_MOVE_ATTRIBUTES } from "./schema";
-import type { GROUP_MOVE_ATTRIBUTES, groupMoveRulesSchema } from "./schema";
+export type GroupMoveCondition = WorkflowCondition;
-export type GroupMoveRules = z.infer<typeof groupMoveRulesSchema>;
-
-export type GroupMoveCondition = GroupMoveRules[number];
+export type GroupMoveRules = WorkflowCondition[];
export type GroupMoveAttributeKey = keyof typeof GROUP_MOVE_ATTRIBUTES;
diff --git a/apps/web/lib/api/workflows/send-campaign/schema.ts b/apps/web/lib/api/workflows/send-campaign/schema.ts
index 8b04698ba0..cb15f9eb3a 100644
--- a/apps/web/lib/api/workflows/send-campaign/schema.ts
+++ b/apps/web/lib/api/workflows/send-campaign/schema.ts
@@ -1,5 +1,3 @@
-import { WORKFLOW_OPERATORS } from "@/lib/api/workflows/operator-definitions";
-import * as z from "zod/v4";
import { WORKFLOW_ATTRIBUTES } from "../attribute-definitions";
export const SEND_CAMPAIGN_ATTRIBUTES = {
@@ -14,17 +12,3 @@ export const SEND_CAMPAIGN_ATTRIBUTES = {
export const SEND_CAMPAIGN_ATTRIBUTE_KEYS = Object.keys(
SEND_CAMPAIGN_ATTRIBUTES,
) as readonly (keyof typeof SEND_CAMPAIGN_ATTRIBUTES)[];
-
-const SEND_CAMPAIGN_OPERATORS = {
- gte: WORKFLOW_OPERATORS.gte,
-};
-
-const SEND_CAMPAIGN_OPERATOR_KEYS = Object.keys(
- SEND_CAMPAIGN_OPERATORS,
-) as readonly (keyof typeof SEND_CAMPAIGN_OPERATORS)[];
-
-export const sendCampaignConditionSchema = z.object({
- attribute: z.enum(SEND_CAMPAIGN_ATTRIBUTE_KEYS),
- operator: z.enum(SEND_CAMPAIGN_OPERATOR_KEYS).default("gte"),
- value: z.number(),
-});
diff --git a/apps/web/lib/api/workflows/send-campaign/types.ts b/apps/web/lib/api/workflows/send-campaign/types.ts
index c015901fff..1483e4b19d 100644
--- a/apps/web/lib/api/workflows/send-campaign/types.ts
+++ b/apps/web/lib/api/workflows/send-campaign/types.ts
@@ -1,5 +1,3 @@
-import type * as z from "zod/v4";
+import type { WorkflowCondition } from "@/lib/api/workflows/types";
-import type { sendCampaignConditionSchema } from "./schema";
-
-export type SendCampaignCondition = z.infer<typeof sendCampaignConditionSchema>;
+export type SendCampaignCondition = WorkflowCondition;
diff --git a/apps/web/lib/api/workflows/types.ts b/apps/web/lib/api/workflows/types.ts
index 41d7d84769..19874ba543 100644
--- a/apps/web/lib/api/workflows/types.ts
+++ b/apps/web/lib/api/workflows/types.ts
@@ -34,3 +34,5 @@ export interface WorkflowContext {
aggregated?: PartnerMetrics;
};
}
+
+export type WorkflowType = "awardBounty" | "sendCampaign" | "moveGroup";
diff --git a/apps/web/lib/api/workflows/validate-workflow-conditions.ts b/apps/web/lib/api/workflows/validate-workflow-conditions.ts
new file mode 100644
index 0000000000..bce6a99dd2
--- /dev/null
+++ b/apps/web/lib/api/workflows/validate-workflow-conditions.ts
@@ -0,0 +1,86 @@
+import { AWARD_BOUNTY_ATTRIBUTES } from "@/lib/api/workflows/award-bounty/schema";
+import { GROUP_MOVE_ATTRIBUTES } from "@/lib/api/workflows/move-group/schema";
+import { WORKFLOW_OPERATORS } from "@/lib/api/workflows/operator-definitions";
+import { SEND_CAMPAIGN_ATTRIBUTES } from "@/lib/api/workflows/send-campaign/schema";
+import type { WorkflowType } from "@/lib/api/workflows/types";
+
+// Map of workflow type to its attributes
+const WORKFLOW_TYPE_ATTRIBUTES = {
+ awardBounty: AWARD_BOUNTY_ATTRIBUTES,
+ sendCampaign: SEND_CAMPAIGN_ATTRIBUTES,
+ moveGroup: GROUP_MOVE_ATTRIBUTES,
+} as const satisfies Record<
+ WorkflowType,
+ Record<string, { operators: readonly string[] }>
+>;
+
+type WorkflowConditionInput = {
+ attribute: string;
+ operator: string;
+ value: unknown;
+};
+
+export async function validateWorkflowConditions({
+ conditions,
+ workflowType,
+}: {
+ conditions?: WorkflowConditionInput[] | null;
+ workflowType: WorkflowType;
+}): Promise<void> {
+ if (!conditions || conditions.length === 0) {
+ return;
+ }
+
+ const attributes = WORKFLOW_TYPE_ATTRIBUTES[workflowType];
+
+ for (let i = 0; i < conditions.length; i++) {
+ const condition = conditions[i];
+ const conditionIndex = i;
+
+ if (!condition.attribute) {
+ throw new Error(
+ `Condition ${conditionIndex + 1}: Please select an activity.`,
+ );
+ }
+
+ // Find the attribute definition
+ const attributeDefinition =
+ attributes[condition.attribute as keyof typeof attributes];
+
+ if (!attributeDefinition) {
+ throw new Error(`Condition ${conditionIndex + 1}: Invalid activity.`);
+ }
+
+ // Find the operator definition
+ const operatorDefinition =
+ WORKFLOW_OPERATORS[condition.operator as keyof typeof WORKFLOW_OPERATORS];
+
+ if (!operatorDefinition) {
+ throw new Error(`Condition ${conditionIndex + 1}: Invalid operator.`);
+ }
+
+ if (
+ !(attributeDefinition.operators as readonly string[]).includes(
+ condition.operator,
+ )
+ ) {
+ const operatorLabel = operatorDefinition?.label ?? condition.operator;
+
+ throw new Error(
+ `Operator "${operatorLabel}" is not valid for the activity "${condition.attribute}".`,
+ );
+ }
+
+ if (condition.value == null || condition.value === undefined) {
+ throw new Error(`Condition ${conditionIndex + 1}: Please enter a value.`);
+ }
+
+ try {
+ operatorDefinition.validate(condition.value as any);
+ } catch (error) {
+ throw new Error(
+ `Condition ${conditionIndex + 1}: ${error instanceof Error ? error.message : "Invalid value."}`,
+ );
+ }
+ }
+}
diff --git a/apps/web/lib/bounty/api/generate-performance-bounty-name.ts b/apps/web/lib/bounty/api/generate-performance-bounty-name.ts
index f40428076b..4a7aa764bd 100644
--- a/apps/web/lib/bounty/api/generate-performance-bounty-name.ts
+++ b/apps/web/lib/bounty/api/generate-performance-bounty-name.ts
@@ -12,10 +12,14 @@ export const generatePerformanceBountyName = ({
}) => {
const isCurrency = isCurrencyAttribute(condition.attribute);
const attributeLabel =
- PERFORMANCE_BOUNTY_SCOPE_ATTRIBUTES[condition.attribute];
+ PERFORMANCE_BOUNTY_SCOPE_ATTRIBUTES[
+ condition.attribute as keyof typeof PERFORMANCE_BOUNTY_SCOPE_ATTRIBUTES
+ ];
+ const value =
+ typeof condition.value === "number" ? condition.value : condition.value.min;
const valueFormatted = isCurrency
- ? `${currencyFormatter(condition.value, { trailingZeroDisplay: "stripIfInteger" })} in`
- : `${nFormatter(condition.value, { full: true })}`;
+ ? `${currencyFormatter(value, { trailingZeroDisplay: "stripIfInteger" })} in`
+ : `${nFormatter(value, { full: true })}`;
return `Earn ${currencyFormatter(rewardAmount, { trailingZeroDisplay: "stripIfInteger" })} after generating ${valueFormatted} ${attributeLabel.toLowerCase()}`;
};
diff --git a/apps/web/lib/zod/schemas/bounties.ts b/apps/web/lib/zod/schemas/bounties.ts
index 19e9128c85..60d4ad5478 100644
--- a/apps/web/lib/zod/schemas/bounties.ts
+++ b/apps/web/lib/zod/schemas/bounties.ts
@@ -18,13 +18,13 @@ import {
BountyType,
} from "@prisma/client";
import * as z from "zod/v4";
-import { awardBountyConditionSchema } from "../../api/workflows/award-bounty/schema";
import { CommissionSchema } from "./commissions";
import { GroupSchema } from "./groups";
import { booleanQuerySchema, getPaginationQuerySchema } from "./misc";
import { EnrolledPartnerSchema } from "./partners";
import { UserSchema } from "./users";
import { nullableCountSchema, parseDateSchema } from "./utils";
+import { workflowConditionSchema } from "./workflows";
// Eg: for each additional 1000 views, earn $1, up to $100
export const bountySocialContentIncrementalBonusSchema = z
@@ -117,7 +117,7 @@ export const createBountySchema = z.object({
.nullish(),
submissionRequirements: submissionRequirementsSchema.nullish(),
groupIds: z.array(z.string()).nullable(),
- performanceCondition: awardBountyConditionSchema.nullish(),
+ performanceCondition: workflowConditionSchema.nullish(),
performanceScope: z.enum(BountyPerformanceScope).nullish(),
sendNotificationEmails: z.boolean().optional(),
});
@@ -149,7 +149,7 @@ export const BountySchema = z.object({
maxSubmissions: z.number(),
rewardAmount: z.number().nullable(),
rewardDescription: z.string().nullable(),
- performanceCondition: awardBountyConditionSchema.nullable().default(null),
+ performanceCondition: workflowConditionSchema.nullable().default(null),
performanceScope: z.enum(BountyPerformanceScope).nullable(),
submissionRequirements: submissionRequirementsSchema.nullable().default(null),
socialMetricsLastSyncedAt: z.date().nullable().optional(),
diff --git a/apps/web/lib/zod/schemas/campaigns.ts b/apps/web/lib/zod/schemas/campaigns.ts
index c60ec31e74..d0998ef27d 100644
--- a/apps/web/lib/zod/schemas/campaigns.ts
+++ b/apps/web/lib/zod/schemas/campaigns.ts
@@ -1,10 +1,10 @@
import { CampaignStatus, CampaignType } from "@prisma/client";
import * as z from "zod/v4";
-import { sendCampaignConditionSchema } from "../../api/workflows/send-campaign/schema";
import { GroupSchema } from "./groups";
import { getPaginationQuerySchema } from "./misc";
import { EnrolledPartnerSchema } from "./partners";
import { parseDateSchema } from "./utils";
+import { workflowConditionSchema } from "./workflows";
export const EMAIL_TEMPLATE_VARIABLES = [
"PartnerName",
@@ -21,7 +21,7 @@ export const CampaignSchema = z.object({
bodyJson: z.record(z.string(), z.any()),
type: z.enum(CampaignType),
status: z.enum(CampaignStatus),
- triggerCondition: sendCampaignConditionSchema.nullable().default(null),
+ triggerCondition: workflowConditionSchema.nullable().default(null),
groups: z.array(GroupSchema.pick({ id: true })),
scheduledAt: z.date().nullable(),
createdAt: z.date(),
@@ -54,7 +54,7 @@ export const updateCampaignSchema = z
preview: z.string().nullish(),
from: z.email().trim().toLowerCase(),
bodyJson: z.record(z.string(), z.any()),
- triggerCondition: sendCampaignConditionSchema.nullish(),
+ triggerCondition: workflowConditionSchema.nullish(),
groupIds: z.array(z.string()).nullable(),
scheduledAt: parseDateSchema.nullish(),
status: z.enum([
@@ -77,7 +77,7 @@ export const getCampaignsQuerySchema = z
.pipe(
z.preprocess(
(input: string) => JSON.parse(input),
- sendCampaignConditionSchema,
+ workflowConditionSchema,
),
)
.optional(),
diff --git a/apps/web/lib/zod/schemas/groups.ts b/apps/web/lib/zod/schemas/groups.ts
index 413c22330e..f512fa55a1 100644
--- a/apps/web/lib/zod/schemas/groups.ts
+++ b/apps/web/lib/zod/schemas/groups.ts
@@ -5,7 +5,6 @@ import { validSlugRegex } from "@dub/utils";
import { PartnerLinkStructure } from "@prisma/client";
import slugify from "@sindresorhus/slugify";
import * as z from "zod/v4";
-import { groupMoveRulesSchema } from "../../api/workflows/move-group/schema";
import { DiscountSchema } from "./discount";
import { GroupBountySummarySchema } from "./group-bounties";
import { booleanQuerySchema, getPaginationQuerySchema } from "./misc";
@@ -14,6 +13,7 @@ import { programLanderSchema } from "./program-lander";
import { RewardSchema } from "./rewards";
import { centsSchemaWithDefault, parseUrlSchema } from "./utils";
import { UTMTemplateSchema } from "./utm";
+import { workflowConditionsSchema } from "./workflows";
export const DEFAULT_PARTNER_GROUP = {
name: "Default Group",
@@ -73,7 +73,7 @@ export const GroupSchema = z.object({
additionalLinks: z.array(additionalPartnerLinkSchema).nullable(),
maxPartnerLinks: z.number(),
linkStructure: z.enum(PartnerLinkStructure),
- moveRules: groupMoveRulesSchema.nullish().default(null),
+ moveRules: workflowConditionsSchema.nullish().default(null),
});
export const GroupWithFormDataSchema = GroupSchema.extend({
@@ -152,7 +152,7 @@ export const updateGroupSchema = createGroupSchema.partial().extend({
autoApprovePartners: z.coerce.boolean().optional(),
updateAutoApprovePartnersForAllGroups: z.coerce.boolean().optional(),
updateHoldingPeriodDaysForAllGroups: z.coerce.boolean().optional(),
- moveRules: groupMoveRulesSchema.optional(),
+ moveRules: workflowConditionsSchema.optional(),
});
export const PartnerGroupDefaultLinkSchema = z.object({
diff --git a/apps/web/lib/zod/schemas/partner-profile.ts b/apps/web/lib/zod/schemas/partner-profile.ts
index baa1d344f7..0051acea7f 100644
--- a/apps/web/lib/zod/schemas/partner-profile.ts
+++ b/apps/web/lib/zod/schemas/partner-profile.ts
@@ -2,7 +2,6 @@ import {
DATE_RANGE_INTERVAL_PRESETS,
DUB_PARTNERS_ANALYTICS_INTERVAL,
} from "@/lib/analytics/constants";
-import { awardBountyConditionSchema } from "@/lib/api/workflows/award-bounty/schema";
import { PARTNER_CUSTOMERS_MAX_PAGE_SIZE } from "@/lib/constants/partner-profile";
import {
CommissionType,
@@ -28,6 +27,7 @@ import { getPaginationQuerySchema } from "./misc";
import { payoutsQuerySchema } from "./payouts";
import { submittedLeadFormDataSchema } from "./submitted-lead-form";
import { centsSchema } from "./utils";
+import { workflowConditionSchema } from "./workflows";
export const PartnerEarningsSchema = CommissionSchema.omit({
userId: true,
@@ -164,7 +164,7 @@ export const PartnerBountySchema = BountySchema.omit({
socialMetricsLastSyncedAt: true,
}).extend({
submissions: z.array(partnerBountySubmissionSchema),
- performanceCondition: awardBountyConditionSchema.nullable().default(null),
+ performanceCondition: workflowConditionSchema.nullable().default(null),
partner: z.object({
totalClicks: z.number(),
totalLeads: z.number(),
diff --git a/apps/web/lib/zod/schemas/workflows.ts b/apps/web/lib/zod/schemas/workflows.ts
index 9a6c688c22..7ce0441064 100644
--- a/apps/web/lib/zod/schemas/workflows.ts
+++ b/apps/web/lib/zod/schemas/workflows.ts
@@ -45,6 +45,9 @@ export const workflowConditionSchema = z.object({
]),
});
+// Array of conditions
+export const workflowConditionsSchema = z.array(workflowConditionSchema);
+
// Individual action
export const workflowActionSchema = z.discriminatedUnion("type", [
z.object({