Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Missing shortcuts

Marcus Farrelle31a65c547cd
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-controls.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-controls.tsx
index aa892b7e59..78f184506a 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-controls.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-controls.tsx
@@ -56,9 +56,9 @@ export function PartnerLinkControls({
useKeyboardShortcut(
["e", "q", "d", "x"],
- (e) => {
+ (_, key) => {
setOpenPopover(false);
- switch (e.key) {
+ switch (key) {
case "e":
setShowPartnerLinkModal(true);
break;
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/links/tags/tag-card.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/links/tags/tag-card.tsx
index 609234990c..80144f0192 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/links/tags/tag-card.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/links/tags/tag-card.tsx
@@ -199,9 +199,9 @@ export function TagCard({
{({ hovered }) => (
<TagCardKeyboardShortcuts
enabled={openPopover || (hovered && openMenuTagId === null)}
- onKeyDown={(e) => {
+ onKeyDown={(_, key) => {
setOpenPopover(false);
- switch (e.key) {
+ switch (key) {
case "e":
setShowAddEditTagModal(true);
break;
@@ -226,7 +226,7 @@ function TagCardKeyboardShortcuts({
onKeyDown,
}: {
enabled: boolean;
- onKeyDown: (e: KeyboardEvent) => void;
+ onKeyDown: (e: KeyboardEvent, pressedKey: string) => void;
}) {
useKeyboardShortcut(["e", "i", "x"], onKeyDown, {
enabled,
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/links/utm/template-card.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/links/utm/template-card.tsx
index f6b47fe291..fc809321c5 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/links/utm/template-card.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/links/utm/template-card.tsx
@@ -173,9 +173,9 @@ export function TemplateCard({
{({ hovered }) => (
<TemplateCardKeyboardShortcuts
enabled={openPopover || (hovered && openMenuTemplateId === null)}
- onKeyDown={(e) => {
+ onKeyDown={(_, key) => {
setOpenPopover(false);
- switch (e.key) {
+ switch (key) {
case "e":
setShowAddEditUtmTemplateModal(true);
break;
@@ -197,7 +197,7 @@ function TemplateCardKeyboardShortcuts({
onKeyDown,
}: {
enabled: boolean;
- onKeyDown: (e: KeyboardEvent) => void;
+ onKeyDown: (e: KeyboardEvent, pressedKey: string) => void;
}) {
useKeyboardShortcut(["e", "x"], onKeyDown, {
enabled,
diff --git a/apps/web/ui/folders/folder-actions.tsx b/apps/web/ui/folders/folder-actions.tsx
index 0478d2fd5f..0eb156bc41 100644
--- a/apps/web/ui/folders/folder-actions.tsx
+++ b/apps/web/ui/folders/folder-actions.tsx
@@ -74,9 +74,9 @@ export const FolderActions = ({
useKeyboardShortcut(
["r", "e", "i", "x", "a", "s", "d"],
- (e) => {
+ (_, key) => {
setOpenPopover(false);
- switch (e.key) {
+ switch (key) {
case "a":
if (!unsortedLinks) {
router.push(
diff --git a/apps/web/ui/links/link-controls.tsx b/apps/web/ui/links/link-controls.tsx
index 719b213f5c..8d8e535ab9 100644
--- a/apps/web/ui/links/link-controls.tsx
+++ b/apps/web/ui/links/link-controls.tsx
@@ -150,9 +150,9 @@ export function LinkControls({
useKeyboardShortcut(
options.map((o) => OPTIONS[o]),
- (e) => {
+ (_, key) => {
setOpenPopover(false);
- switch (e.key) {
+ switch (key) {
case "e":
canManageLink && openLinkBuilder();
break;
diff --git a/apps/web/ui/links/links-toolbar.tsx b/apps/web/ui/links/links-toolbar.tsx
index 45f5d7d24d..5c2285c0f9 100644
--- a/apps/web/ui/links/links-toolbar.tsx
+++ b/apps/web/ui/links/links-toolbar.tsx
@@ -173,9 +173,9 @@ export const LinksToolbar = memo(
bulkActions
.map(({ keyboardShortcut }) => keyboardShortcut)
.filter(Boolean) as string[],
- (e) => {
+ (_, key) => {
const action = bulkActions.find(
- ({ keyboardShortcut }) => keyboardShortcut === e.key,
+ ({ keyboardShortcut }) => keyboardShortcut === key,
);
if (action && !action.disabledTooltip && hasAllFolderPermissions)
action.action();
diff --git a/packages/ui/src/date-picker/date-range-picker.tsx b/packages/ui/src/date-picker/date-range-picker.tsx
index efa5c2aca0..34d8dcf790 100644
--- a/packages/ui/src/date-picker/date-range-picker.tsx
+++ b/packages/ui/src/date-picker/date-range-picker.tsx
@@ -146,8 +146,8 @@ const DateRangePickerInner = ({
(presets
?.filter((preset) => preset.shortcut)
.map((preset) => preset.shortcut) as string[]) ?? [],
- (e) => {
- const preset = presets?.find((preset) => preset.shortcut === e.key);
+ (_, key) => {
+ const preset = presets?.find((preset) => preset.shortcut === key);
if (preset) onPresetSelected(preset);
},
);
diff --git a/packages/ui/src/hooks/use-keyboard-shortcut.tsx b/packages/ui/src/hooks/use-keyboard-shortcut.tsx
index 8b091c229a..b96528e939 100644
--- a/packages/ui/src/hooks/use-keyboard-shortcut.tsx
+++ b/packages/ui/src/hooks/use-keyboard-shortcut.tsx
@@ -43,7 +43,7 @@ export function KeyboardShortcutProvider({
export function useKeyboardShortcut(
key: KeyboardShortcutListener["key"],
- callback: (e: KeyboardEvent) => void,
+ callback: (e: KeyboardEvent, pressedKey: string) => void,
options: Pick<
KeyboardShortcutListener,
"enabled" | "priority" | "modal" | "sheet"
@@ -112,7 +112,7 @@ export function useKeyboardShortcut(
if (topListener.id !== id) return;
e.preventDefault();
- callback(e);
+ callback(e, pressedKey);
},
[
key,