Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Add `rewardSpendLimit` flag

Steven Teye641f6b0abf0
diff --git a/apps/web/lib/actions/partners/create-reward.ts b/apps/web/lib/actions/partners/create-reward.ts
index 493e4b740a..2a3e1f9999 100644
--- a/apps/web/lib/actions/partners/create-reward.ts
+++ b/apps/web/lib/actions/partners/create-reward.ts
@@ -8,6 +8,7 @@ import { serializeReward } from "@/lib/api/partners/serialize-reward";
import { getDefaultProgramIdOrThrow } from "@/lib/api/programs/get-default-program-id-or-throw";
import { queueRewardProcessing } from "@/lib/api/rewards/queue-reward-processing";
import { validateReward } from "@/lib/api/rewards/validate-reward";
+import { getFeatureFlags } from "@/lib/edge-config";
import { getPlanCapabilities } from "@/lib/plan-capabilities";
import { prisma } from "@/lib/prisma";
import { PARTNER_LEVEL_REWARDS_PLAN_ERROR } from "@/lib/rewards/constants";
@@ -48,11 +49,8 @@ export const createRewardAction = authActionClient
});
const programId = getDefaultProgramIdOrThrow(workspace);
- const {
- canUseAdvancedRewardLogic,
- canSetRewardSpendLimit,
- canCreateReferralReward,
- } = getPlanCapabilities(workspace.plan);
+ const { canUseAdvancedRewardLogic, canCreateReferralReward } =
+ getPlanCapabilities(workspace.plan);
if (event === "referral" && !canCreateReferralReward) {
throw new Error(
@@ -70,10 +68,14 @@ export const createRewardAction = authActionClient
);
}
- if ((spendLimitAmount || spendLimitInterval) && !canSetRewardSpendLimit) {
- throw new Error(
- "Spend limits are only available on the Enterprise plan.",
- );
+ if (spendLimitAmount || spendLimitInterval) {
+ const flags = await getFeatureFlags({
+ workspaceId: workspace.id,
+ });
+
+ if (!flags?.rewardSpendLimit) {
+ throw new Error("Spend limits are not enabled on your workspace.");
+ }
}
const group = await getGroupOrThrow({
diff --git a/apps/web/lib/actions/partners/update-reward.ts b/apps/web/lib/actions/partners/update-reward.ts
index 65d260d65c..f7aa288db8 100644
--- a/apps/web/lib/actions/partners/update-reward.ts
+++ b/apps/web/lib/actions/partners/update-reward.ts
@@ -8,6 +8,7 @@ import { getDefaultProgramIdOrThrow } from "@/lib/api/programs/get-default-progr
import { revalidateProgramPublicPages } from "@/lib/api/programs/revalidate-program-public-pages";
import { queueRewardProcessing } from "@/lib/api/rewards/queue-reward-processing";
import { validateReward } from "@/lib/api/rewards/validate-reward";
+import { getFeatureFlags } from "@/lib/edge-config";
import { getPlanCapabilities } from "@/lib/plan-capabilities";
import { prisma } from "@/lib/prisma";
import { updateRewardSchema } from "@/lib/zod/schemas/rewards";
@@ -48,11 +49,8 @@ export const updateRewardAction = authActionClient
programId,
});
- const {
- canUseAdvancedRewardLogic,
- canSetRewardSpendLimit,
- canCreateReferralReward,
- } = getPlanCapabilities(workspace.plan);
+ const { canUseAdvancedRewardLogic, canCreateReferralReward } =
+ getPlanCapabilities(workspace.plan);
if (reward.event === "referral" && !canCreateReferralReward) {
throw new Error(
@@ -66,10 +64,14 @@ export const updateRewardAction = authActionClient
);
}
- if ((spendLimitAmount || spendLimitInterval) && !canSetRewardSpendLimit) {
- throw new Error(
- "Spend limits are only available on the Enterprise plan.",
- );
+ if (spendLimitAmount || spendLimitInterval) {
+ const flags = await getFeatureFlags({
+ workspaceId: workspace.id,
+ });
+
+ if (!flags?.rewardSpendLimit) {
+ throw new Error("Spend limits are not enabled on your workspace.");
+ }
}
validateReward({
diff --git a/apps/web/lib/edge-config/get-feature-flags.ts b/apps/web/lib/edge-config/get-feature-flags.ts
index 3787459667..270a9387ce 100644
--- a/apps/web/lib/edge-config/get-feature-flags.ts
+++ b/apps/web/lib/edge-config/get-feature-flags.ts
@@ -18,6 +18,7 @@ export const getFeatureFlags = async ({
const workspaceFeatures: Record<BetaFeatures, boolean> = {
analyticsSettingsSiteVisitTracking: false,
noProrationUpgrade: false,
+ rewardSpendLimit: false,
};
if (!process.env.EDGE_CONFIG) {
diff --git a/apps/web/lib/plan-capabilities.ts b/apps/web/lib/plan-capabilities.ts
index 7ce50df77b..bffe211aca 100644
--- a/apps/web/lib/plan-capabilities.ts
+++ b/apps/web/lib/plan-capabilities.ts
@@ -14,7 +14,6 @@ export const getPlanCapabilities = (
canExportAuditLogs: !!plan && ["enterprise"].includes(plan),
canUseAdvancedRewardLogic:
!!plan && ["enterprise", "advanced"].includes(plan),
- canSetRewardSpendLimit: !!plan && ["enterprise"].includes(plan),
canMessagePartners: !!plan && ["enterprise", "advanced"].includes(plan),
canSendEmailCampaigns: !!plan && ["enterprise", "advanced"].includes(plan),
canDiscoverPartners: !!plan && ["enterprise", "advanced"].includes(plan),
diff --git a/apps/web/lib/types.ts b/apps/web/lib/types.ts
index 4e7f0dafe8..8b953820ee 100644
--- a/apps/web/lib/types.ts
+++ b/apps/web/lib/types.ts
@@ -278,7 +278,8 @@ export type PlanProps = (typeof plans)[number];
export type BetaFeatures =
| "analyticsSettingsSiteVisitTracking"
- | "noProrationUpgrade";
+ | "noProrationUpgrade"
+ | "rewardSpendLimit";
export type PartnerBetaFeatures = "postbacks";
diff --git a/apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx b/apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx
index eb0a2e31a2..2289868299 100644
--- a/apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx
+++ b/apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx
@@ -43,9 +43,9 @@ import { motion } from "motion/react";
import { useAction } from "next-safe-action/hooks";
import {
Dispatch,
- MutableRefObject,
PropsWithChildren,
ReactNode,
+ RefObject,
SetStateAction,
useContext,
useEffect,
@@ -223,7 +223,7 @@ function RewardSheetContent({
hasPendingChangesRef,
}: RewardSheetProps & {
nested?: boolean;
- hasPendingChangesRef: MutableRefObject<boolean>;
+ hasPendingChangesRef: RefObject<boolean>;
}) {
const { group, mutateGroup } = useGroup({
groupIdOrSlug: groupIdOrSlug ?? undefined,
@@ -261,6 +261,7 @@ function RewardSheetContent({
slug: workspaceSlug,
defaultProgramId,
plan,
+ flags,
} = useWorkspace({
// lower dedupingInterval + revalidateOnFocus in case user upgrades their plan in another tab
swrOpts: {
@@ -374,11 +375,8 @@ function RewardSheetContent({
// Compute amount based on type
const amount = type === "flat" ? amountInCents : amountInPercentage;
- const {
- canCreateReferralReward,
- canSetRewardSpendLimit,
- canUseAdvancedRewardLogic,
- } = getPlanCapabilities(plan);
+ const { canCreateReferralReward, canUseAdvancedRewardLogic } =
+ getPlanCapabilities(plan);
const isAiRewardEvent =
selectedEvent !== "referral" && selectedEvent !== "custom";
@@ -392,9 +390,9 @@ function RewardSheetContent({
hasPendingChangesRef.current = isDirty || aiBuilder.isReviewing;
const spendLimitEnabled =
- canSetRewardSpendLimit && spendLimitInterval != null;
+ flags?.rewardSpendLimit && spendLimitInterval != null;
const hasIncompleteMainSpendLimit =
- canSetRewardSpendLimit &&
+ flags?.rewardSpendLimit &&
spendLimitInterval != null &&
(spendLimitAmount == null || isNaN(spendLimitAmount));
@@ -657,7 +655,7 @@ function RewardSheetContent({
{modifiers?.length ? (
<> for all other {selectedEvent}s</>
) : null}
- {canSetRewardSpendLimit ? (
+ {flags?.rewardSpendLimit ? (
<>
{", "}with{" "}
<InlineBadgePopover