Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Name workflows kebab-case ending in -workflow so outbox routing is consistent.

Kiran Ke718ba188532
diff --git a/apps/web/app/(ee)/api/e2e/trigger-merge-accounts/route.ts b/apps/web/app/(ee)/api/e2e/trigger-merge-accounts/route.ts
index 1830d5ac7d..74b1d7fd10 100644
--- a/apps/web/app/(ee)/api/e2e/trigger-merge-accounts/route.ts
+++ b/apps/web/app/(ee)/api/e2e/trigger-merge-accounts/route.ts
@@ -53,7 +53,7 @@ export const POST = withWorkspace(
const userId = `e2e-merge-${nanoid()}`;
const res = await dispatchWorkflows({
- name: "mergePartnerAccounts",
+ name: "merge-partner-accounts-workflow",
payload: {
userId,
sourceEmail,
diff --git a/apps/web/app/(ee)/api/partner-profile/referrals/route.ts b/apps/web/app/(ee)/api/partner-profile/referrals/route.ts
index ccb2c7e673..7955b2601e 100644
--- a/apps/web/app/(ee)/api/partner-profile/referrals/route.ts
+++ b/apps/web/app/(ee)/api/partner-profile/referrals/route.ts
@@ -58,7 +58,7 @@ export const GET = withPartnerProfile(async ({ partner, searchParams }) => {
);
await dispatchWorkflows({
- name: "partnerApproved",
+ name: "partner-approved-workflow",
payload: {
programId: NETWORK_PROGRAM_ID,
partnerId: partner.id,
diff --git a/apps/web/lib/actions/partners/bulk-approve-partners.ts b/apps/web/lib/actions/partners/bulk-approve-partners.ts
index 7a10b8b34f..f1e3f5a67a 100644
--- a/apps/web/lib/actions/partners/bulk-approve-partners.ts
+++ b/apps/web/lib/actions/partners/bulk-approve-partners.ts
@@ -145,7 +145,7 @@ export const bulkApprovePartnersAction = authActionClient
dispatchWorkflows(
updatedEnrollments.map(({ partnerId, programId }) => ({
- name: "partnerApproved",
+ name: "partner-approved-workflow",
payload: {
programId,
partnerId,
diff --git a/apps/web/lib/actions/partners/merge-partner-accounts.ts b/apps/web/lib/actions/partners/merge-partner-accounts.ts
index cfc9e7f3be..a727605aa2 100644
--- a/apps/web/lib/actions/partners/merge-partner-accounts.ts
+++ b/apps/web/lib/actions/partners/merge-partner-accounts.ts
@@ -341,7 +341,7 @@ const mergeAccounts = async ({ userId }: { userId: string }) => {
const { sourceEmail, targetEmail } = accounts;
await dispatchWorkflows({
- name: "mergePartnerAccounts",
+ name: "merge-partner-accounts-workflow",
payload: {
userId,
sourceEmail,
diff --git a/apps/web/lib/api/partners/applications/approve-partner.ts b/apps/web/lib/api/partners/applications/approve-partner.ts
index 4b2097c120..0bb6267549 100644
--- a/apps/web/lib/api/partners/applications/approve-partner.ts
+++ b/apps/web/lib/api/partners/applications/approve-partner.ts
@@ -157,7 +157,7 @@ export async function approvePartner({
}),
dispatchWorkflows({
- name: "partnerApproved",
+ name: "partner-approved-workflow",
payload: {
programId,
partnerId,
diff --git a/apps/web/lib/jobs/publish-workflows.ts b/apps/web/lib/jobs/publish-workflows.ts
index 614ce17677..d1997a5c57 100644
--- a/apps/web/lib/jobs/publish-workflows.ts
+++ b/apps/web/lib/jobs/publish-workflows.ts
@@ -39,12 +39,7 @@ export async function dispatchWorkflows(
id,
name: job.name,
payload: job.payload,
- // Default deduplicationId to the job id so inline publish and the
- // retry cron cannot deliver the same workflow twice
- options: {
- ...job.options,
- deduplicationId: job.options?.deduplicationId ?? id,
- },
+ options: job.options,
};
});
diff --git a/apps/web/lib/jobs/send-workflows.ts b/apps/web/lib/jobs/send-workflows.ts
index cde6de27e2..b618d65feb 100644
--- a/apps/web/lib/jobs/send-workflows.ts
+++ b/apps/web/lib/jobs/send-workflows.ts
@@ -2,6 +2,7 @@ import { logger, toErrorFields } from "@/lib/axiom/server";
import { APP_DOMAIN_WITH_NGROK, chunk, serializeError } from "@dub/utils";
import { PublishRequest } from "@upstash/qstash";
import { Client, TriggerOptions } from "@upstash/workflow";
+import * as z from "zod/v4";
import { LAST_ERROR_MAX_LENGTH, QSTASH_BATCH_CHUNK_SIZE } from "./constants";
import type { PersistableJob, PublishResult } from "./types";
@@ -16,12 +17,24 @@ const workflowClient = new Client({
}),
});
+export const workflowNameSchema = z
+ .string()
+ .regex(
+ /^[a-z][a-z0-9]*(-[a-z0-9]+)*-workflow$/,
+ 'Workflow name must be kebab-case ending in "-workflow"',
+ );
+
const workflowPathMap = {
- partnerApproved: "/api/workflows/partner-approved",
- mergePartnerAccounts: "/api/workflows/merge-partner-accounts",
- createPartnerCommission: "/api/workflows/create-partner-commission",
+ "partner-approved-workflow": "/api/workflows/partner-approved",
+ "merge-partner-accounts-workflow": "/api/workflows/merge-partner-accounts",
+ "create-partner-commission-workflow":
+ "/api/workflows/create-partner-commission",
} as const;
+for (const name of Object.keys(workflowPathMap)) {
+ workflowNameSchema.parse(name);
+}
+
export type WorkflowName = keyof typeof workflowPathMap;
export type WorkflowOptions = Pick<
diff --git a/apps/web/lib/partners/queue-partner-commission-creation.ts b/apps/web/lib/partners/queue-partner-commission-creation.ts
index 26578b09ba..51b7d89147 100644
--- a/apps/web/lib/partners/queue-partner-commission-creation.ts
+++ b/apps/web/lib/partners/queue-partner-commission-creation.ts
@@ -20,7 +20,7 @@ export const queuePartnerCommissionCreation = async (
const { partner, links, ...programEnrollment } = result;
await dispatchWorkflows({
- name: "createPartnerCommission",
+ name: "create-partner-commission-workflow",
payload: params,
options: {
flowControl: {