Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

fix(advanced-filters): appropriate extraction functions for numeric metadata comparisons

Pedro Ladeirae989305b8cda
diff --git a/packages/tinybird/pipes/v3_count.pipe b/packages/tinybird/pipes/v3_count.pipe
index 7ded0fddf3..35f4d0b082 100644
--- a/packages/tinybird/pipes/v3_count.pipe
+++ b/packages/tinybird/pipes/v3_count.pipe
@@ -274,13 +274,13 @@ SQL >
{% elif operator == 'notEquals' %}
AND JSONExtractString(metadata, {{ metadataKey }}) != {{ value }}
{% elif operator == 'greaterThan' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) > {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) > toFloat64OrNull({{ value }})
{% elif operator == 'lessThan' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) < {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) < toFloat64OrNull({{ value }})
{% elif operator == 'greaterThanOrEqual' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) >= {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) >= toFloat64OrNull({{ value }})
{% elif operator == 'lessThanOrEqual' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) <= {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) <= toFloat64OrNull({{ value }})
{% end %}
{% elif item.get('field', '') %}
{% set field = item.get('field', '') %}
diff --git a/packages/tinybird/pipes/v3_events.pipe b/packages/tinybird/pipes/v3_events.pipe
index 658a92cc8e..6270eb74b7 100644
--- a/packages/tinybird/pipes/v3_events.pipe
+++ b/packages/tinybird/pipes/v3_events.pipe
@@ -128,13 +128,13 @@ SQL >
{% elif operator == 'notEquals' %}
AND JSONExtractString(metadata, {{ metadataKey }}) != {{ value }}
{% elif operator == 'greaterThan' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) > {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) > toFloat64OrNull({{ value }})
{% elif operator == 'lessThan' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) < {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) < toFloat64OrNull({{ value }})
{% elif operator == 'greaterThanOrEqual' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) >= {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) >= toFloat64OrNull({{ value }})
{% elif operator == 'lessThanOrEqual' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) <= {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) <= toFloat64OrNull({{ value }})
{% end %}
{% elif item.get('field', '') %}
{% set field = item.get('field', '') %}
@@ -292,13 +292,13 @@ SQL >
{% elif operator == 'notEquals' %}
AND JSONExtractString(metadata, {{ metadataKey }}) != {{ value }}
{% elif operator == 'greaterThan' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) > {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) > toFloat64OrNull({{ value }})
{% elif operator == 'lessThan' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) < {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) < toFloat64OrNull({{ value }})
{% elif operator == 'greaterThanOrEqual' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) >= {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) >= toFloat64OrNull({{ value }})
{% elif operator == 'lessThanOrEqual' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) <= {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) <= toFloat64OrNull({{ value }})
{% end %}
{% elif item.get('field', '') %}
{% set field = item.get('field', '') %}
diff --git a/packages/tinybird/pipes/v3_group_by.pipe b/packages/tinybird/pipes/v3_group_by.pipe
index 6934575f23..9dc57bdd71 100644
--- a/packages/tinybird/pipes/v3_group_by.pipe
+++ b/packages/tinybird/pipes/v3_group_by.pipe
@@ -169,13 +169,13 @@ SQL >
{% elif operator == 'notEquals' %}
AND JSONExtractString(metadata, {{ metadataKey }}) != {{ value }}
{% elif operator == 'greaterThan' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) > {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) > toFloat64OrNull({{ value }})
{% elif operator == 'lessThan' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) < {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) < toFloat64OrNull({{ value }})
{% elif operator == 'greaterThanOrEqual' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) >= {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) >= toFloat64OrNull({{ value }})
{% elif operator == 'lessThanOrEqual' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) <= {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) <= toFloat64OrNull({{ value }})
{% end %}
{% elif item.get('field', '') %}
{% set field = item.get('field', '') %}
@@ -388,13 +388,13 @@ SQL >
{% elif operator == 'notEquals' %}
AND JSONExtractString(metadata, {{ metadataKey }}) != {{ value }}
{% elif operator == 'greaterThan' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) > {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) > toFloat64OrNull({{ value }})
{% elif operator == 'lessThan' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) < {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) < toFloat64OrNull({{ value }})
{% elif operator == 'greaterThanOrEqual' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) >= {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) >= toFloat64OrNull({{ value }})
{% elif operator == 'lessThanOrEqual' %}
- AND JSONExtractString(metadata, {{ metadataKey }}) <= {{ value }}
+ AND toFloat64OrNull(JSONExtractString(metadata, {{ metadataKey }})) <= toFloat64OrNull({{ value }})
{% end %}
{% elif item.get('field', '') %}
{% set field = item.get('field', '') %}