Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

fix link analytics href

Steven Teyea743df11d24
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/page-client.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/page-client.tsx
index 556e56289b..e907915704 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/page-client.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/page-client.tsx
@@ -27,7 +27,6 @@ import {
getApexDomain,
getPrettyUrl,
} from "@dub/utils";
-import Link from "next/link";
import { useParams, useRouter } from "next/navigation";
import { useMemo } from "react";
import { usePartnerCustomerFilters } from "./use-partner-customer-filters";
@@ -132,8 +131,9 @@ export function ProgramCustomersPageClient() {
accessorKey: "activity.link",
cell: ({ row }) =>
row.original.activity.link ? (
- <Link
- href={`/programs/${programSlug}/links?domain=${row.original.activity.link.domain}&key=${row.original.activity.link.key}`}
+ <a
+ href={`/programs/${programSlug}/analytics?linkId=${row.original.activity.link.id}`}
+ target="_blank"
className="flex cursor-alias items-center gap-3 decoration-dotted underline-offset-2 hover:underline"
>
<LinkLogo
@@ -148,7 +148,7 @@ export function ProgramCustomersPageClient() {
>
{getPrettyUrl(row.original.activity.link.shortLink)}
</span>
- </Link>
+ </a>
) : (
"-"
),
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx
index 5fd5129ef1..aa2bcde436 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx
@@ -182,7 +182,7 @@ const StatsBadge = memo(({ link }: { link: PartnerProfileLinkProps }) => {
const As = showDetailedAnalytics ? Link : "div";
return (
<As
- href={`/programs/${programEnrollment?.program.slug}/analytics?domain=${link.domain}&key=${link.key}`}
+ href={`/programs/${programEnrollment?.program.slug}/analytics?linkId=${link.id}`}
className="flex items-center gap-0.5 rounded-md border border-neutral-200 bg-neutral-50 p-0.5 text-sm text-neutral-600"
>
{[
@@ -291,8 +291,7 @@ const StatsCharts = memo(({ link }: { link: PartnerProfileLinkProps }) => {
key={chart.key}
href={`/programs/${programEnrollment?.program.slug}/analytics${getQueryString(
{
- domain: link.domain,
- key: link.key,
+ linkId: link.id,
event: chart.key === "saleAmount" ? "sales" : chart.key,
},
)}`}
diff --git a/apps/web/ui/customers/customer-activity-list.tsx b/apps/web/ui/customers/customer-activity-list.tsx
index 17ef1c5245..7166f524e5 100644
--- a/apps/web/ui/customers/customer-activity-list.tsx
+++ b/apps/web/ui/customers/customer-activity-list.tsx
@@ -28,7 +28,7 @@ const activityData = {
<Link
href={
programSlug
- ? `${analyticsBaseUrl}?domain=${event.link.domain}&key=${event.link.key}`
+ ? `${analyticsBaseUrl}?linkId=${event.link.id}`
: `/${slug}/links/${getPrettyUrl(event.link.shortLink)}`
}
target="_blank"
diff --git a/apps/web/ui/customers/customer-details-column.tsx b/apps/web/ui/customers/customer-details-column.tsx
index 380d47fbfa..551ff1a882 100644
--- a/apps/web/ui/customers/customer-details-column.tsx
+++ b/apps/web/ui/customers/customer-details-column.tsx
@@ -335,7 +335,7 @@ export function CustomerDetailsColumn({
workspaceSlug
? `/${workspaceSlug}/links/${link.domain}/${link.key}`
: programSlug
- ? `/programs/${programSlug}/analytics?domain=${encodeURIComponent(link.domain)}&key=${encodeURIComponent(link.key)}`
+ ? `/programs/${programSlug}/analytics?linkId=${link.id}`
: undefined
}
target="_blank"
diff --git a/apps/web/ui/domains/domain-card.tsx b/apps/web/ui/domains/domain-card.tsx
index cbded462ee..0f2e941ee4 100644
--- a/apps/web/ui/domains/domain-card.tsx
+++ b/apps/web/ui/domains/domain-card.tsx
@@ -201,7 +201,7 @@ export default function DomainCard({ props }: { props: DomainProps }) {
}
>
<Link
- href={`/${slug}/analytics?domain=${domain}&key=_root`}
+ href={`/${slug}/analytics?linkId=${props.link?.id}`}
className="flex items-center space-x-1 whitespace-nowrap rounded-md border border-neutral-200 bg-neutral-50 px-3 py-1 transition-colors hover:bg-neutral-100"
>
<CursorRays className="h-4 w-4 text-neutral-700" />
diff --git a/apps/web/ui/links/link-analytics-badge.tsx b/apps/web/ui/links/link-analytics-badge.tsx
index e4f2604406..b6a265095c 100644
--- a/apps/web/ui/links/link-analytics-badge.tsx
+++ b/apps/web/ui/links/link-analytics-badge.tsx
@@ -86,7 +86,7 @@ export function LinkAnalyticsBadge({
return isMobile ? (
<Link
- href={`/${slug}/analytics?domain=${domain}&key=${key}`}
+ href={`/${slug}/analytics?linkId=${link.id}`}
className="flex items-center gap-1 rounded-md border border-neutral-200 bg-neutral-50 px-2 py-0.5 text-sm text-neutral-800"
>
<CursorRays className="h-4 w-4 text-neutral-600" />
@@ -147,7 +147,7 @@ export function LinkAnalyticsBadge({
}
>
<Link
- href={`/${slug}/analytics?domain=${domain}&key=${key}${url ? `&url=${url}` : ""}&interval=${plan === "free" ? "30d" : plan === "pro" ? "1y" : "all"}`}
+ href={`/${slug}/analytics?linkId=${link.id}`}
className={cn(
"block overflow-hidden rounded-md border border-neutral-200 bg-neutral-50 p-0.5 text-sm text-neutral-600 transition-colors",
variant === "loose" ? "hover:bg-neutral-100" : "hover:bg-white",