Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Respect saleUnit on events tab sales totals and charts.

Kiran Kef486baaa30e
diff --git a/apps/web/ui/analytics/events/events-tabs.tsx b/apps/web/ui/analytics/events/events-tabs.tsx
index 6e5f08e5f4..d5aa866e24 100644
--- a/apps/web/ui/analytics/events/events-tabs.tsx
+++ b/apps/web/ui/analytics/events/events-tabs.tsx
@@ -33,6 +33,7 @@ export default function EventsTabs() {
totalEvents,
totalEventsLoading,
fetchCompositeStats,
+ saleUnit,
} = useContext(AnalyticsContext);
const { data: timeseriesData, isLoading: isLoadingTimeseries } =
@@ -74,18 +75,9 @@ export default function EventsTabs() {
if (tab !== "sales" && sortBy !== "timestamp") queryParams({ del: "sort" });
}, [tab, searchParams.get("sort")]);
- const tabNumberValue = (event: "clicks" | "leads" | "sales") => {
- if (totalEvents === undefined) return undefined;
- if (Array.isArray(totalEvents)) return 0;
- if (event === "sales") {
- return (totalEvents.saleAmount ?? 0) / 100;
- }
- return totalEvents[event] ?? 0;
- };
-
return (
<div className="grid w-full grid-cols-3 gap-2 overflow-x-auto sm:gap-4">
- {["clicks", "leads", "sales"].map((event) => (
+ {(["clicks", "leads", "sales"] as const).map((event) => (
<button
key={event}
className={cn(
@@ -102,14 +94,16 @@ export default function EventsTabs() {
{totalEvents !== undefined ? (
<NumberFlow
value={
- tabNumberValue(event as "clicks" | "leads" | "sales") ?? 0
+ event === "sales" && saleUnit === "saleAmount"
+ ? (totalEvents.saleAmount ?? 0) / 100
+ : (totalEvents[event] ?? 0)
}
className={cn(
"text-2xl transition-opacity",
totalEventsLoading && "opacity-40",
)}
format={
- event === "sales"
+ event === "sales" && saleUnit === "saleAmount"
? {
style: "currency",
currency: "USD",
@@ -118,9 +112,7 @@ export default function EventsTabs() {
}
: {
notation:
- (tabNumberValue(
- event as "clicks" | "leads" | "sales",
- ) ?? 0) > 999999
+ (totalEvents[event] ?? 0) > 999999
? "compact"
: "standard",
}
@@ -143,9 +135,9 @@ export default function EventsTabs() {
timeseriesData?.map((d) => ({
date: new Date(d.start),
value:
- ((event === "sales" ? d?.saleAmount : d?.[event]) as
- | number
- | undefined) ?? 0,
+ (event === "sales" && saleUnit === "saleAmount"
+ ? d.saleAmount
+ : d[event]) ?? 0,
})) || []
}
/>